<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 17, 2016, at 11:49 PM, Amarnath Valluri <<a href="mailto:amarnath.valluri@intel.com" class="">amarnath.valluri@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class=""><p class=""><br class="">
</p>
<br class="">
<div class="moz-cite-prefix">On Friday 14 October 2016 05:13 PM,
Khem Raj wrote:<br class="">
</div>
<blockquote cite="mid:CAMKF1soK1czJxYNo2H=gQsk2SvvvYexL9DSa7p+Yz8Yw3FL+zQ@mail.gmail.com" type="cite" class="">
<pre wrap="" class="">On Fri, Oct 14, 2016 at 3:21 PM, Amarnath Valluri
<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:amarnath.valluri@intel.com"><amarnath.valluri@intel.com></a> wrote:
</pre>
<blockquote type="cite" style="" class="">
<pre wrap="" class=""><span class="moz-txt-citetags">> </span>The failure was:
<span class="moz-txt-citetags">> </span>| ../src/image-reader.cpp: In member function 'bool PNGReader::init(const
<span class="moz-txt-citetags">> </span>string&)':
<span class="moz-txt-citetags">> </span>| ../src/image-reader.cpp:123:16: error: 'unique_ptr' in namespace 'std' does
<span class="moz-txt-citetags">> </span>not name a template type
<span class="moz-txt-citetags">></span>
<span class="moz-txt-citetags">> </span>This change enables c++11 features, as code useing them.
<span class="moz-txt-citetags">></span>
<span class="moz-txt-citetags">> </span>Signed-off-by: Amarnath Valluri <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:amarnath.valluri@intel.com"><amarnath.valluri@intel.com></a>
<span class="moz-txt-citetags">> </span>---
<span class="moz-txt-citetags">> </span> meta-oe/recipes-benchmark/glmark2/glmark2_git.bb | 3 +++
<span class="moz-txt-citetags">> </span> 1 file changed, 3 insertions(+)
<span class="moz-txt-citetags">></span>
<span class="moz-txt-citetags">> </span>diff --git a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
<span class="moz-txt-citetags">> </span>index 396ae70..4cb233b 100644
<span class="moz-txt-citetags">> </span>--- a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
<span class="moz-txt-citetags">> </span>+++ b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
<span class="moz-txt-citetags">> </span>@@ -28,6 +28,9 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'x11-gl
<span class="moz-txt-citetags">> </span> ${@bb.utils.contains('DISTRO_FEATURES', 'wayland opengl', 'wayland-gl wayland-gles2', '', d)} \
<span class="moz-txt-citetags">> </span> drm-gl drm-gles2"
<span class="moz-txt-citetags">></span>
<span class="moz-txt-citetags">> </span>+# Enable C++11 features
<span class="moz-txt-citetags">> </span>+CXXFLAGS += "--std=c++11"
</pre>
</blockquote>
<pre wrap="" class="">gcc6 now defaults to -std=gnu++14,so I have couple of questions here
Are you pinning it to c++11 because it doesnt compile with c++14 ? or
is it because package is explicitly overrding the std option. In latter case
perhaps its better to patch the package and also submit it upstream
</pre>
</blockquote>
This failure was visible with gcc version 5.4(GCCVERSION=5.%). With
gcc6 It built successfully.<br class="">
<br class=""></div></div></blockquote><div><br class=""></div><div>I see, you should mention such things in commit message.</div><br class=""><blockquote type="cite" class=""><div class=""><div bgcolor="#FFFFFF" text="#000000" class="">
- Amarnath<br class="">
<br class="">
<br class=""><p class="">---------------------------------------------------------------------<br class="">
Intel Finland Oy<br class="">
Registered Address: PL 281, 00181 Helsinki <br class="">
Business Identity Code: 0357606 - 4 <br class="">
Domiciled in Helsinki </p><p class="">This e-mail and any attachments may contain confidential material for<br class="">
the sole use of the intended recipient(s). Any review or distribution<br class="">
by others is strictly prohibited. If you are not the intended<br class="">
recipient, please contact the sender and delete all copies.</p></div>
</div></blockquote></div><br class=""></body></html>