<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 21, 2016 at 12:05 AM, Mikko Ylinen <span dir="ltr"><<a href="mailto:mikko.ylinen@intel.com" target="_blank">mikko.ylinen@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":2sa" class="a3s aXjCH m157e6228ee82d47a">The change to get rid of FuncFailed exceptions changed the behavior<br>
of how missing uid/gid error are be handled. Instead of catching<br>
the exception and handling that via bb.parse.SkipPackage(), a fatal<br>
error was called.<br>
<br>
This won't work with recipes that are unused and therefore do not have<br>
UID/GIDs defined. The problem triggers when parsing all recipes (e.g.,<br>
oe-selftest runs bitbake -p).<br>
<br>
The right way to handle this is to raise bb.parse.SkipPackage(). This<br>
will error correctly once the recipe is needed.<br>
<br>
Signed-off-by: Mikko Ylinen <<a href="mailto:mikko.ylinen@intel.com">mikko.ylinen@intel.com</a>><br>
---<br>
meta/classes/useradd-<wbr>staticids.bbclass | 5 ++---<br>
1 file changed, 2 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/meta/classes/useradd-<wbr>staticids.bbclass b/meta/classes/useradd-<wbr>staticids.bbclass<br>
index afb580a..4162774 100644<br>
--- a/meta/classes/useradd-<wbr>staticids.bbclass<br>
+++ b/meta/classes/useradd-<wbr>staticids.bbclass<br>
@@ -53,8 +53,7 @@ def update_useradd_static_config(<wbr>d):<br>
def handle_missing_id(id, type, pkg):<br>
# For backwards compatibility we accept "1" in addition to "error"<br>
if d.getVar('USERADD_ERROR_<wbr>DYNAMIC', True) == 'error' or d.getVar('USERADD_ERROR_<wbr>DYNAMIC', True) == '1':<br>
- #bb.error("Skipping recipe %s, package %s which adds %sname %s does not have a static ID defined." % (d.getVar('PN', True), pkg, type, id))<br>
- bb.fatal("%s - %s: %sname %s does not have a static ID defined." % (d.getVar('PN', True), pkg, type, id))<br>
+ raise NotImplementedError("%s - %s: %sname %s does not have a static ID defined. Skipping it." % (d.getVar('PN', True), pkg, type, id))<br>
elif d.getVar('USERADD_ERROR_<wbr>DYNAMIC', True) == 'warn':<br>
bb.warn("%s - %s: %sname %s does not have a static ID defined." % (d.getVar('PN', True), pkg, type, id))<br>
<br>
@@ -323,7 +322,7 @@ python __anonymous() {<br>
and not bb.data.inherits_class('<wbr>native', d):<br>
try:<br>
update_useradd_static_config(<wbr>d)<br>
- except bb.build.FuncFailed as f:<br>
+ except NotImplementedError as f:<br>
bb.debug(1, "Skipping recipe %s: %s" % (d.getVar('PN', True), f))<br>
raise bb.parse.SkipPackage(f)</div></blockquote></div><br>NotImplementedError is not the right exception for this.<br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>