<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On 10 November 2016 at 12:18, Maciej Borzecki <span dir="ltr"><<a href="mailto:maciej.borzecki@rndity.com" target="_blank">maciej.borzecki@rndity.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div id="gmail-:1kf" class="gmail-a3s gmail-aXjCH gmail-m1584e35ea3494c0f"> def test_qemux86_directdisk(self):<br>
"""Test creation of qemux-86-directdisk image"""<br>
image = "qemux86-directdisk"<br>
- self.assertEqual(0, runCmd("wic create %s -e core-image-minimal" \<br>
- % image).status)<br>
+ wic_cmd_vars = {<br>
+ 'wks': image,<br>
+ 'image': self.OE_IMAGE,<br>
+ }<br>
+ self.assertEqual(0, runCmd("wic create %(wks)s -e %(image)s" \<br>
+ % wic_cmd_vars).status)</div></blockquote></div><br>Is it just me who thinks that this is more understandable then?</div><div class="gmail_extra"><br></div><div class="gmail_extra">def test_qemux86_directdisk(self):<br></div><div class="gmail_extra"> self.assertEqual(0, runCmd("wic create qemux86-directdisk -e core-image-minimal").status)</div><div class="gmail_extra"> self.assertEqual(1, len(glob(os.path.join(self.resultdir, "core-image-minimal-*direct"))))</div><div class="gmail_extra"><br></div><div class="gmail_extra">Not my test case so just an opinion :)</div><div class="gmail_extra"><br></div><div class="gmail_extra">Ross</div></div>