<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Carlos<div class=""><br class=""></div><div class="">webkitgtk fails now e.g. see</div><div class=""><br class=""></div><div class=""><a href="http://errors.yoctoproject.org/Errors/Details/111221/" class="">http://errors.yoctoproject.org/Errors/Details/111221/</a></div><div class=""><br class=""></div><div class=""><div class="">fatal error: 'stdlib.h' file not found</div><div class="">#include_next <stdlib.h></div></div><div class=""><br class=""></div><div class="">This is when building with clang, I think its too early to drop this patch. </div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 8, 2016, at 9:52 AM, Carlos Alberto Lopez Perez <<a href="mailto:clopez@igalia.com" class="">clopez@igalia.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""> * This patch is not longer needed. Upstream has fixed this issue in:<br class=""> <a href="https://trac.webkit.org/changeset/205672" class="">https://trac.webkit.org/changeset/205672</a> which is already included<br class=""> in WebKitGTK+ >= 2.14.0<br class=""><br class="">Signed-off-by: Carlos Alberto Lopez Perez <<a href="mailto:clopez@igalia.com" class="">clopez@igalia.com</a>><br class="">---<br class=""> ...bKitMacros-Append-to-I-and-not-to-isystem.patch | 181 ---------------------<br class=""> meta/recipes-sato/webkit/webkitgtk_2.14.1.bb | 1 -<br class=""> 2 files changed, 182 deletions(-)<br class=""> delete mode 100644 meta/recipes-sato/webkit/files/0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch<br class=""><br class="">diff --git a/meta/recipes-sato/webkit/files/0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch b/meta/recipes-sato/webkit/files/0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch<br class="">deleted file mode 100644<br class="">index ef209c8..0000000<br class="">--- a/meta/recipes-sato/webkit/files/0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch<br class="">+++ /dev/null<br class="">@@ -1,181 +0,0 @@<br class="">-From 20ee11dd188e1538f8cdd17a289dc6f9c63a011e Mon Sep 17 00:00:00 2001<br class="">-From: Khem Raj <<a href="mailto:raj.khem@gmail.com" class="">raj.khem@gmail.com</a>><br class="">-Date: Sun, 17 Apr 2016 12:35:41 -0700<br class="">-Subject: [PATCH] WebKitMacros: Append to -I and not to -isystem<br class="">-<br class="">-gcc-6 has now introduced stdlib.h in libstdc++ for better<br class="">-compliance and its including the C library stdlib.h using<br class="">-include_next which is sensitive to order of system header<br class="">-include paths. Its infact better to not tinker with the<br class="">-system header include paths at all. Since adding /usr/include<br class="">-to -system is redundant and compiler knows about it moreover<br class="">-now with gcc6 it interferes with compiler's functioning<br class="">-and ends up with compile errors e.g.<br class="">-<br class="">-/usr/include/c++/6.0.0/cstdlib:75:25: fatal error: stdlib.h: No such file or directory<br class="">-<br class="">-Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com" class="">raj.khem@gmail.com</a>><br class="">-Upstream-Status: Pending<br class="">----<br class="">- Source/JavaScriptCore/shell/CMakeLists.txt | 2 +-<br class="">- Source/WebCore/PlatformGTK.cmake | 6 +++---<br class="">- Source/WebKit2/PlatformGTK.cmake | 2 +-<br class="">- Source/cmake/WebKitMacros.cmake | 2 +-<br class="">- Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt | 2 +-<br class="">- Tools/ImageDiff/CMakeLists.txt | 2 +-<br class="">- Tools/MiniBrowser/gtk/CMakeLists.txt | 2 +-<br class="">- Tools/TestWebKitAPI/PlatformGTK.cmake | 2 +-<br class="">- Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt | 2 +-<br class="">- Tools/WebKitTestRunner/CMakeLists.txt | 2 +-<br class="">- 10 files changed, 12 insertions(+), 12 deletions(-)<br class="">-<br class="">-diff --git a/Source/JavaScriptCore/shell/CMakeLists.txt b/Source/JavaScriptCore/shell/CMakeLists.txt<br class="">-index 155c797..80fe22b 100644<br class="">---- a/Source/JavaScriptCore/shell/CMakeLists.txt<br class="">-+++ b/Source/JavaScriptCore/shell/CMakeLists.txt<br class="">-@@ -20,7 +20,7 @@ WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()<br class="">- <br class="">- WEBKIT_WRAP_SOURCELIST(${JSC_SOURCES})<br class="">- include_directories(./ ${JavaScriptCore_INCLUDE_DIRECTORIES})<br class="">--include_directories(SYSTEM ${JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES})<br class="">-+include_directories(${JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES})<br class="">- add_executable(jsc ${JSC_SOURCES})<br class="">- target_link_libraries(jsc ${JSC_LIBRARIES})<br class="">- <br class="">-diff --git a/Source/WebCore/PlatformGTK.cmake b/Source/WebCore/PlatformGTK.cmake<br class="">-index 567bd79..1fabea8 100644<br class="">---- a/Source/WebCore/PlatformGTK.cmake<br class="">-+++ b/Source/WebCore/PlatformGTK.cmake<br class="">-@@ -340,7 +340,7 @@ if (ENABLE_PLUGIN_PROCESS_GTK2)<br class="">- ${GTK2_INCLUDE_DIRS}<br class="">- ${GDK2_INCLUDE_DIRS}<br class="">- )<br class="">-- target_include_directories(WebCorePlatformGTK2 SYSTEM PRIVATE<br class="">-+ target_include_directories(WebCorePlatformGTK2 PRIVATE<br class="">- ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}<br class="">- )<br class="">- target_link_libraries(WebCorePlatformGTK2<br class="">-@@ -365,7 +365,7 @@ WEBKIT_SET_EXTRA_COMPILER_FLAGS(WebCorePlatformGTK)<br class="">- target_include_directories(WebCorePlatformGTK PRIVATE<br class="">- ${WebCore_INCLUDE_DIRECTORIES}<br class="">- )<br class="">--target_include_directories(WebCorePlatformGTK SYSTEM PRIVATE<br class="">-+target_include_directories(WebCorePlatformGTK PRIVATE<br class="">- ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}<br class="">- ${GTK_INCLUDE_DIRS}<br class="">- ${GDK_INCLUDE_DIRS}<br class="">-@@ -383,7 +383,7 @@ include_directories(<br class="">- "${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}"<br class="">- )<br class="">- <br class="">--include_directories(SYSTEM<br class="">-+include_directories(<br class="">- ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}<br class="">- )<br class="">- <br class="">-diff --git a/Source/WebKit2/PlatformGTK.cmake b/Source/WebKit2/PlatformGTK.cmake<br class="">-index e4805a4..c57df5d 100644<br class="">---- a/Source/WebKit2/PlatformGTK.cmake<br class="">-+++ b/Source/WebKit2/PlatformGTK.cmake<br class="">-@@ -822,7 +822,7 @@ if (ENABLE_PLUGIN_PROCESS_GTK2)<br class="">- target_include_directories(WebKitPluginProcess2 PRIVATE<br class="">- ${WebKit2CommonIncludeDirectories}<br class="">- )<br class="">-- target_include_directories(WebKitPluginProcess2 SYSTEM PRIVATE<br class="">-+ target_include_directories(WebKitPluginProcess2 PRIVATE<br class="">- ${WebKit2CommonSystemIncludeDirectories}<br class="">- ${GTK2_INCLUDE_DIRS}<br class="">- ${GDK2_INCLUDE_DIRS}<br class="">-diff --git a/Source/cmake/WebKitMacros.cmake b/Source/cmake/WebKitMacros.cmake<br class="">-index 043e78e..8b3b642 100644<br class="">---- a/Source/cmake/WebKitMacros.cmake<br class="">-+++ b/Source/cmake/WebKitMacros.cmake<br class="">-@@ -224,7 +224,7 @@ endmacro()<br class="">- <br class="">- macro(WEBKIT_FRAMEWORK _target)<br class="">- include_directories(${${_target}_INCLUDE_DIRECTORIES})<br class="">-- include_directories(SYSTEM ${${_target}_SYSTEM_INCLUDE_DIRECTORIES})<br class="">-+ include_directories(${${_target}_SYSTEM_INCLUDE_DIRECTORIES})<br class="">- add_library(${_target} ${${_target}_LIBRARY_TYPE}<br class="">- ${${_target}_HEADERS}<br class="">- ${${_target}_SOURCES}<br class="">-diff --git a/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt b/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt<br class="">-index c431667..6dff244 100644<br class="">---- a/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt<br class="">-+++ b/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt<br class="">-@@ -42,7 +42,7 @@ set(WebKitTestNetscapePlugin_SYSTEM_INCLUDE_DIRECTORIES<br class="">- )<br class="">- <br class="">- include_directories(${WebKitTestNetscapePlugin_INCLUDE_DIRECTORIES})<br class="">--include_directories(SYSTEM ${WebKitTestNetscapePlugin_SYSTEM_INCLUDE_DIRECTORIES})<br class="">-+include_directories(${WebKitTestNetscapePlugin_SYSTEM_INCLUDE_DIRECTORIES})<br class="">- <br class="">- set(WebKitTestNetscapePlugin_LIBRARIES<br class="">- ${X11_LIBRARIES}<br class="">-diff --git a/Tools/ImageDiff/CMakeLists.txt b/Tools/ImageDiff/CMakeLists.txt<br class="">-index b15443f..87e03bf 100644<br class="">---- a/Tools/ImageDiff/CMakeLists.txt<br class="">-+++ b/Tools/ImageDiff/CMakeLists.txt<br class="">-@@ -14,6 +14,6 @@ set(IMAGE_DIFF_LIBRARIES<br class="">- WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()<br class="">- <br class="">- include_directories(${IMAGE_DIFF_INCLUDE_DIRECTORIES})<br class="">--include_directories(SYSTEM ${IMAGE_DIFF_SYSTEM_INCLUDE_DIRECTORIES})<br class="">-+include_directories(${IMAGE_DIFF_SYSTEM_INCLUDE_DIRECTORIES})<br class="">- add_executable(ImageDiff ${IMAGE_DIFF_SOURCES})<br class="">- target_link_libraries(ImageDiff ${IMAGE_DIFF_LIBRARIES})<br class="">-diff --git a/Tools/MiniBrowser/gtk/CMakeLists.txt b/Tools/MiniBrowser/gtk/CMakeLists.txt<br class="">-index 0704bc6..619e5a5 100644<br class="">---- a/Tools/MiniBrowser/gtk/CMakeLists.txt<br class="">-+++ b/Tools/MiniBrowser/gtk/CMakeLists.txt<br class="">-@@ -58,7 +58,7 @@ endif ()<br class="">- add_definitions(-DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6)<br class="">- <br class="">- include_directories(${MiniBrowser_INCLUDE_DIRECTORIES})<br class="">--include_directories(SYSTEM ${MiniBrowser_SYSTEM_INCLUDE_DIRECTORIES})<br class="">-+include_directories(${MiniBrowser_SYSTEM_INCLUDE_DIRECTORIES})<br class="">- add_executable(MiniBrowser ${MiniBrowser_SOURCES})<br class="">- target_link_libraries(MiniBrowser ${MiniBrowser_LIBRARIES})<br class="">- <br class="">-diff --git a/Tools/TestWebKitAPI/PlatformGTK.cmake b/Tools/TestWebKitAPI/PlatformGTK.cmake<br class="">-index 7552cc2..2eb44d5 100644<br class="">---- a/Tools/TestWebKitAPI/PlatformGTK.cmake<br class="">-+++ b/Tools/TestWebKitAPI/PlatformGTK.cmake<br class="">-@@ -20,7 +20,7 @@ include_directories(<br class="">- ${WEBKIT2_DIR}/UIProcess/API/gtk<br class="">- )<br class="">- <br class="">--include_directories(SYSTEM<br class="">-+include_directories(<br class="">- ${GDK3_INCLUDE_DIRS}<br class="">- ${GLIB_INCLUDE_DIRS}<br class="">- ${GTK3_INCLUDE_DIRS}<br class="">-diff --git a/Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt b/Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt<br class="">-index b0b4739..434e4ca 100644<br class="">---- a/Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt<br class="">-+++ b/Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt<br class="">-@@ -23,7 +23,7 @@ include_directories(<br class="">- ${TOOLS_DIR}/TestWebKitAPI/gtk/WebKit2Gtk<br class="">- )<br class="">- <br class="">--include_directories(SYSTEM<br class="">-+include_directories(<br class="">- ${ATSPI_INCLUDE_DIRS}<br class="">- ${GLIB_INCLUDE_DIRS}<br class="">- ${GSTREAMER_INCLUDE_DIRS}<br class="">-diff --git a/Tools/WebKitTestRunner/CMakeLists.txt b/Tools/WebKitTestRunner/CMakeLists.txt<br class="">-index 7db90f2..a4f917f 100644<br class="">---- a/Tools/WebKitTestRunner/CMakeLists.txt<br class="">-+++ b/Tools/WebKitTestRunner/CMakeLists.txt<br class="">-@@ -116,7 +116,7 @@ GENERATE_BINDINGS(WebKitTestRunner_SOURCES<br class="">- WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()<br class="">- <br class="">- include_directories(${WebKitTestRunner_INCLUDE_DIRECTORIES})<br class="">--include_directories(SYSTEM ${WebKitTestRunner_SYSTEM_INCLUDE_DIRECTORIES})<br class="">-+include_directories(${WebKitTestRunner_SYSTEM_INCLUDE_DIRECTORIES})<br class="">- <br class="">- add_library(TestRunnerInjectedBundle SHARED ${WebKitTestRunnerInjectedBundle_SOURCES})<br class="">- target_link_libraries(TestRunnerInjectedBundle ${WebKitTestRunner_LIBRARIES})<br class="">--- <br class="">-2.9.3<br class="">-<br class="">diff --git a/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb b/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb<br class="">index a2586de..69c9f11 100644<br class="">--- a/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb<br class="">+++ b/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb<br class="">@@ -18,7 +18,6 @@ SRC_URI = "<a href="http://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz" class="">http://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz</a> \<br class=""> <a href="file:///ppc-musl-fix.patch" class="">file://ppc-musl-fix.patch</a> \<br class=""> <a href="file:///0001-Fix-racy-parallel-build-of-WebKit2-4.0.gir.patch" class="">file://0001-Fix-racy-parallel-build-of-WebKit2-4.0.gir.patch</a> \<br class=""> <a href="file:///0001-Tweak-gtkdoc-settings-so-that-gtkdoc-generation-work.patch" class="">file://0001-Tweak-gtkdoc-settings-so-that-gtkdoc-generation-work.patch</a> \<br class="">- <a href="file:///0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch" class="">file://0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch</a> \<br class=""> "<br class=""><br class=""> SRC_URI[md5sum] = "8d6c60dc41604d3bbd43165a674c07e5"<br class="">-- <br class="">2.1.4<br class=""><br class="">-- <br class="">_______________________________________________<br class="">Openembedded-core mailing list<br class=""><a href="mailto:Openembedded-core@lists.openembedded.org" class="">Openembedded-core@lists.openembedded.org</a><br class="">http://lists.openembedded.org/mailman/listinfo/openembedded-core<br class=""></div></div></blockquote></div><br class=""></div></body></html>