<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 12, 2016 at 3:58 AM, Ed Bartosh <span dir="ltr"><<a href="mailto:ed.bartosh@linux.intel.com" target="_blank">ed.bartosh@linux.intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sat, Dec 10, 2016 at 11:40:38AM -0700, Christopher Larson wrote:<br>
> On Fri, Dec 9, 2016 at 10:46 AM, Ed Bartosh <<a href="mailto:ed.bartosh@linux.intel.com">ed.bartosh@linux.intel.com</a>><br>
> wrote:<br>
><br>
> > Enabled generation of block map(bmap) files for wic images<br>
> > built for edgerouter machine. This should simplify flashing<br>
> > images with bmaptool.<br>
> ><br>
> > [YOCTO #10621]<br>
> ><br>
> > Signed-off-by: Ed Bartosh <<a href="mailto:ed.bartosh@linux.intel.com">ed.bartosh@linux.intel.com</a>><br>
> ><br>
><br>
> I think this is more of a distro decision than machine, whether they want<br>
> to support use of bmaptool for their users/customers. It’d be nice if it<br>
> was easier to control compression from the distro, too. For example, if we<br>
> want to distribute wic.bz2+wic.bmap in our installers, it’d be nice to be<br>
> able to switch to that for all machines that use wic. I’m not sure how best<br>
> to pull that off, however. Something to think about for the future.<br>
<br>
</span>Thanks for pointing out to it. I did it this way for two reasons:<br>
- IMAGE_FSTYPES was already modified in edgerouter.conf<br>
- I wanted to enable generation of wic.bmap for subset of machines, i.e.<br>
only for hardware reference BSPs mentioned in README.hardware<br></blockquote><div><br></div><div>That’s a fair point. As khem indicated, this is a bit of an intersection between distro and machine, hardware capabilities and distro policy. I expect this is fine as is, but something to consider improving going forward. I’m not certain a distro/machine feature makes sense for something like this, but perhaps something else might.</div></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>