<div dir="ltr">On 24 November 2016 at 20:58,  <span dir="ltr">&lt;<a href="mailto:leonardo.sandoval.gonzalez@linux.intel.com" target="_blank">leonardo.sandoval.gonzalez@linux.intel.com</a>&gt;</span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">From: Leonardo Sandoval &lt;<a href="mailto:leonardo.sandoval.gonzalez@linux.intel.com">leonardo.sandoval.gonzalez@<wbr>linux.intel.com</a>&gt;<br>
<br>
core-image-clutter and core-image-weston, both required opengl in distro<br>
features, skip relevant tests if this is not the case.<br>
<br>
Signed-off-by: Leonardo Sandoval &lt;<a href="mailto:leonardo.sandoval.gonzalez@linux.intel.com">leonardo.sandoval.gonzalez@<wbr>linux.intel.com</a>&gt;<br>
---<br>
 meta/lib/oeqa/selftest/<wbr>imagefeatures.py | 4 ++++<br>
 1 file changed, 4 insertions(+)<br>
<br>
diff --git a/meta/lib/oeqa/selftest/<wbr>imagefeatures.py b/meta/lib/oeqa/selftest/<wbr>imagefeatures.py<br>
index d015c49..a61510b 100644<br>
--- a/meta/lib/oeqa/selftest/<wbr>imagefeatures.py<br>
+++ b/meta/lib/oeqa/selftest/<wbr>imagefeatures.py<br>
@@ -78,6 +78,8 @@ class ImageFeatures(oeSelfTest):<br>
         &quot;&quot;&quot;<br>
<br>
         # Build a core-image-clutter<br>
+        if &#39;opengl&#39; not in get_bb_var(&#39;DISTRO_FEATURES&#39;):<br>
+            self.skipTest(&#39;opengl not present on DISTRO_FEATURES so core-image-clutter cannot be built&#39;)<br>
         bitbake(&#39;core-image-clutter&#39;)<br></blockquote><div><br></div><div>I don&#39;t see the point of this test.  Lets save five minutes by just deleting it.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
     @testcase(1117)<br>
@@ -96,6 +98,8 @@ class ImageFeatures(oeSelfTest):<br>
         self.write_config(features)<br>
<br>
         # Build a core-image-weston<br>
+        if &#39;opengl&#39; not in get_bb_var(&#39;DISTRO_FEATURES&#39;):<br>
+            self.skipTest(&#39;opengl not present on DISTRO_FEATURES so core-image-weston cannot be built&#39;)<br>
         bitbake(&#39;core-image-weston&#39;)</blockquote><div><br></div><div>The full test is:</div><div><br></div><div>        features = &#39;DISTRO_FEATURES_append = &quot; wayland&quot;\n&#39;</div><div>        features += &#39;CORE_IMAGE_EXTRA_INSTALL += &quot;wayland weston&quot;&#39;</div><div>        self.write_config(features)</div><div><br></div><div>        # Build a core-image-weston</div><div>        bitbake(&#39;core-image-weston&#39;)</div><div><br></div><div>Adding wayland and weston to IMAGE_INSTALL is pointless as thats what the image does.  Adding wayland is madness if the distro doesn&#39;t support it.</div><div><br></div><div>Can you rewrite this test so it&#39;s basically just &quot;if DISTRO_FEATURES contains opengl and wayland, build core-image-weston&quot;.</div><div><br></div><div>Ross</div></div></div></div>