<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 01/11/2017 11:27 AM, Burton, Ross
wrote:<br>
</div>
<blockquote
cite="mid:CAJTo0LYDAbGZ4E_adYLFGCQ84Fq7Cfs6PJsBqJmapzkemTnAdw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra"><br>
<div class="gmail_quote">On 9 January 2017 at 17:45, <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:leonardo.sandoval.gonzalez@linux.intel.com"
target="_blank">leonardo.sandoval.gonzalez@linux.intel.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div id=":4lo" class="a3s aXjCH m15984507a75cf04f">+++
b/meta/lib/oeqa/selftest/<wbr>imagefeatures.py<br>
@@ -77,6 +77,9 @@ class ImageFeatures(oeSelfTest):<br>
AutomatedBy: Daniel Istrate <<a
moz-do-not-send="true"
href="mailto:daniel.alexandrux.istrate@intel.com">daniel.alexandrux.istrate@<wbr>intel.com</a>><br>
"""<br>
<br>
+ if 'opengl' not in
get_bb_var('DISTRO_FEATURES'):<br>
+ self.skipTest('opengl not present on
DISTRO_FEATURES so core-image-clutter cannot be built')<br>
+<br>
# Build a core-image-clutter<br>
bitbake('core-image-clutter')<br>
</div>
</blockquote>
<div><br>
</div>
<div>This test is pretty pointless, lets just delete it.</div>
</div>
</div>
</div>
</blockquote>
<br>
why is this pointless? if this is the case, we should then remove
the core-image-clutter.bb target.<br>
<br>
<br>
<blockquote
cite="mid:CAJTo0LYDAbGZ4E_adYLFGCQ84Fq7Cfs6PJsBqJmapzkemTnAdw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div id=":4lo" class="a3s aXjCH m15984507a75cf04f">
@@ -91,6 +94,10 @@ class ImageFeatures(oeSelfTest):<br>
AutomatedBy: Daniel Istrate <<a
moz-do-not-send="true"
href="mailto:daniel.alexandrux.istrate@intel.com">daniel.alexandrux.istrate@<wbr>intel.com</a>><br>
"""<br>
<br>
+ distro_features = get_bb_var('DISTRO_FEATURES')<br>
+ if not ('opengl' in distro_features and
'wayland' in distro_features):<br>
+ self.skipTest('neither opengl nor wayland
present on DISTRO_FEATURES so core-image-weston cannot
be built')<br>
+<br>
features = 'DISTRO_FEATURES_append = "
wayland"\n'<br>
features += 'CORE_IMAGE_EXTRA_INSTALL +=
"wayland weston"'<br>
self.write_config(features)</div>
</blockquote>
</div>
<br>
</div>
<div class="gmail_extra">This test is 90% nonsense, let's fix it
whilst we're here. After checking that opengl and wayland are
in DISTRO_FEATURES it can just build core-image-weston:
DISTRO_FEATURES doesn't need appending as it already has
wayland in, and CORE_IMAGE_EXTRA_INSTALL doesn't need
extending as core-image-weston obviously already contains
weston.</div>
<div class="gmail_extra"><br>
</div>
<div class="gmail_extra">Ross</div>
</div>
</blockquote>
<br>
</body>
</html>