<div dir="ltr">Shouldn't we change default <span style="font-size:12.8px">ARM_INSTRUCTION_SET while we're at it as well?</span><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px"><a href="https://bugzilla.yoctoproject.org/show_bug.cgi?id=9213">https://bugzilla.yoctoproject.org/show_bug.cgi?id=9213</a></span><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 7, 2017 at 12:35 AM, Khem Raj <span dir="ltr"><<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><br><div class="gmail_quote"><span class=""><div>On Mon, Mar 6, 2017 at 2:51 PM Andre McCurdy <<a href="mailto:armccurdy@gmail.com" target="_blank">armccurdy@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Mar 6, 2017 at 2:37 PM, Khem Raj <<a href="mailto:raj.khem@gmail.com" class="m_2774803552810199972gmail_msg" target="_blank">raj.khem@gmail.com</a>> wrote:<br class="m_2774803552810199972gmail_msg">
> On Mon, Mar 6, 2017 at 1:47 PM, Andre McCurdy <<a href="mailto:armccurdy@gmail.com" class="m_2774803552810199972gmail_msg" target="_blank">armccurdy@gmail.com</a>> wrote:<br class="m_2774803552810199972gmail_msg">
>> Defaulting to softfp probably isn't the best choice anymore,<br class="m_2774803552810199972gmail_msg">
>> especially as there are now ARM BSP layers which leave DEFAULTTUNE<br class="m_2774803552810199972gmail_msg">
>> entirely up to the distro:<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> <a href="https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html" rel="noreferrer" class="m_2774803552810199972gmail_msg" target="_blank">https://lists.yoctoproject.<wbr>org/pipermail/yocto/2017-<wbr>February/034637.html</a><br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
><br class="m_2774803552810199972gmail_msg">
> I like this patch and want to clarify that it changes the default ISA to thumb2<br class="m_2774803552810199972gmail_msg">
> which we should use anyway due to size reasons and other distros use it as<br class="m_2774803552810199972gmail_msg">
> default too.<br class="m_2774803552810199972gmail_msg">
<br class="m_2774803552810199972gmail_msg">
No, it doesn't. </blockquote><div><br></div></span><div>That's right I wanted to say to make that default while you are at it</div><div><div class="h5"><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The choice between ARM and Thumb(2) is made by the<br class="m_2774803552810199972gmail_msg">
ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means<br class="m_2774803552810199972gmail_msg">
that the ARM_INSTRUCTION_SET variable will not be ignored (it's really<br class="m_2774803552810199972gmail_msg">
a long standing bug that we ever defined DEFAULTTUNE options for ARMv6<br class="m_2774803552810199972gmail_msg">
and above which ignore ARM_INSTRUCTION_SET, but that's a separate<br class="m_2774803552810199972gmail_msg">
topic).<br class="m_2774803552810199972gmail_msg">
<br class="m_2774803552810199972gmail_msg">
> I am not sure of we should change it for armv6 though. since some armv6<br class="m_2774803552810199972gmail_msg">
> has t1 and some has t2 so lets leave that as it is.<br class="m_2774803552810199972gmail_msg">
<br class="m_2774803552810199972gmail_msg">
I'm not aware of any ARMv6 cores which don't support Thumb2. Do you<br class="m_2774803552810199972gmail_msg">
have a reference?<br class="m_2774803552810199972gmail_msg">
<br class="m_2774803552810199972gmail_msg">
(But again, to be clear, this commit doesn't change the default in<br class="m_2774803552810199972gmail_msg">
terms of instruction set - all builds will still use ARM).<br class="m_2774803552810199972gmail_msg">
<br class="m_2774803552810199972gmail_msg">
>> Signed-off-by: Andre McCurdy <<a href="mailto:armccurdy@gmail.com" class="m_2774803552810199972gmail_msg" target="_blank">armccurdy@gmail.com</a>><br class="m_2774803552810199972gmail_msg">
>> ---<br class="m_2774803552810199972gmail_msg">
>> meta/conf/machine/include/arm/<wbr>arch-armv6.inc | 2 +-<br class="m_2774803552810199972gmail_msg">
>> meta/conf/machine/include/arm/<wbr>arch-armv7a.inc | 2 +-<br class="m_2774803552810199972gmail_msg">
>> meta/conf/machine/include/arm/<wbr>arch-armv7ve.inc | 2 +-<br class="m_2774803552810199972gmail_msg">
>> meta/conf/machine/include/<wbr>tune-arm1136jf-s.inc | 2 +-<br class="m_2774803552810199972gmail_msg">
>> meta/conf/machine/include/<wbr>tune-cortexa15.inc | 2 +-<br class="m_2774803552810199972gmail_msg">
>> meta/conf/machine/include/<wbr>tune-cortexa17.inc | 2 +-<br class="m_2774803552810199972gmail_msg">
>> meta/conf/machine/include/<wbr>tune-cortexa5.inc | 2 +-<br class="m_2774803552810199972gmail_msg">
>> meta/conf/machine/include/<wbr>tune-cortexa7.inc | 2 +-<br class="m_2774803552810199972gmail_msg">
>> meta/conf/machine/include/<wbr>tune-cortexa8.inc | 2 +-<br class="m_2774803552810199972gmail_msg">
>> meta/conf/machine/include/<wbr>tune-cortexa9.inc | 2 +-<br class="m_2774803552810199972gmail_msg">
>> 10 files changed, 10 insertions(+), 10 deletions(-)<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> diff --git a/meta/conf/machine/include/<wbr>arm/arch-armv6.inc b/meta/conf/machine/include/<wbr>arm/arch-armv6.inc<br class="m_2774803552810199972gmail_msg">
>> index 91f0f07..5e1f973 100644<br class="m_2774803552810199972gmail_msg">
>> --- a/meta/conf/machine/include/<wbr>arm/arch-armv6.inc<br class="m_2774803552810199972gmail_msg">
>> +++ b/meta/conf/machine/include/<wbr>arm/arch-armv6.inc<br class="m_2774803552810199972gmail_msg">
>> @@ -1,4 +1,4 @@<br class="m_2774803552810199972gmail_msg">
>> -DEFAULTTUNE ?= "armv6"<br class="m_2774803552810199972gmail_msg">
>> +DEFAULTTUNE ?= "armv6thf"<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> TUNEVALID[armv6] = "Enable instructions for ARMv6"<br class="m_2774803552810199972gmail_msg">
>> TUNECONFLICTS[armv6] = "armv4 armv5"<br class="m_2774803552810199972gmail_msg">
>> diff --git a/meta/conf/machine/include/<wbr>arm/arch-armv7a.inc b/meta/conf/machine/include/<wbr>arm/arch-armv7a.inc<br class="m_2774803552810199972gmail_msg">
>> index 5446048..bad1c27 100644<br class="m_2774803552810199972gmail_msg">
>> --- a/meta/conf/machine/include/<wbr>arm/arch-armv7a.inc<br class="m_2774803552810199972gmail_msg">
>> +++ b/meta/conf/machine/include/<wbr>arm/arch-armv7a.inc<br class="m_2774803552810199972gmail_msg">
>> @@ -1,4 +1,4 @@<br class="m_2774803552810199972gmail_msg">
>> -DEFAULTTUNE ?= "armv7a"<br class="m_2774803552810199972gmail_msg">
>> +DEFAULTTUNE ?= "armv7athf"<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"<br class="m_2774803552810199972gmail_msg">
>> TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"<br class="m_2774803552810199972gmail_msg">
>> diff --git a/meta/conf/machine/include/<wbr>arm/arch-armv7ve.inc b/meta/conf/machine/include/<wbr>arm/arch-armv7ve.inc<br class="m_2774803552810199972gmail_msg">
>> index 42d8d04..4d9260f 100644<br class="m_2774803552810199972gmail_msg">
>> --- a/meta/conf/machine/include/<wbr>arm/arch-armv7ve.inc<br class="m_2774803552810199972gmail_msg">
>> +++ b/meta/conf/machine/include/<wbr>arm/arch-armv7ve.inc<br class="m_2774803552810199972gmail_msg">
>> @@ -1,4 +1,4 @@<br class="m_2774803552810199972gmail_msg">
>> -DEFAULTTUNE ?= "armv7ve"<br class="m_2774803552810199972gmail_msg">
>> +DEFAULTTUNE ?= "armv7vethf"<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"<br class="m_2774803552810199972gmail_msg">
>> TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"<br class="m_2774803552810199972gmail_msg">
>> diff --git a/meta/conf/machine/include/<wbr>tune-arm1136jf-s.inc b/meta/conf/machine/include/<wbr>tune-arm1136jf-s.inc<br class="m_2774803552810199972gmail_msg">
>> index 53994ef..2cadbee 100644<br class="m_2774803552810199972gmail_msg">
>> --- a/meta/conf/machine/include/<wbr>tune-arm1136jf-s.inc<br class="m_2774803552810199972gmail_msg">
>> +++ b/meta/conf/machine/include/<wbr>tune-arm1136jf-s.inc<br class="m_2774803552810199972gmail_msg">
>> @@ -1,4 +1,4 @@<br class="m_2774803552810199972gmail_msg">
>> -DEFAULTTUNE ?= "armv6"<br class="m_2774803552810199972gmail_msg">
>> +DEFAULTTUNE ?= "armv6thf"<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> require conf/machine/include/arm/arch-<wbr>armv6.inc<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> diff --git a/meta/conf/machine/include/<wbr>tune-cortexa15.inc b/meta/conf/machine/include/<wbr>tune-cortexa15.inc<br class="m_2774803552810199972gmail_msg">
>> index 03de602..25e99f9 100644<br class="m_2774803552810199972gmail_msg">
>> --- a/meta/conf/machine/include/<wbr>tune-cortexa15.inc<br class="m_2774803552810199972gmail_msg">
>> +++ b/meta/conf/machine/include/<wbr>tune-cortexa15.inc<br class="m_2774803552810199972gmail_msg">
>> @@ -1,4 +1,4 @@<br class="m_2774803552810199972gmail_msg">
>> -DEFAULTTUNE ?= "armv7ve-neon"<br class="m_2774803552810199972gmail_msg">
>> +DEFAULTTUNE ?= "armv7vethf-neon"<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> require conf/machine/include/arm/arch-<wbr>armv7ve.inc<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> diff --git a/meta/conf/machine/include/<wbr>tune-cortexa17.inc b/meta/conf/machine/include/<wbr>tune-cortexa17.inc<br class="m_2774803552810199972gmail_msg">
>> index f659a62..40392f9 100644<br class="m_2774803552810199972gmail_msg">
>> --- a/meta/conf/machine/include/<wbr>tune-cortexa17.inc<br class="m_2774803552810199972gmail_msg">
>> +++ b/meta/conf/machine/include/<wbr>tune-cortexa17.inc<br class="m_2774803552810199972gmail_msg">
>> @@ -1,4 +1,4 @@<br class="m_2774803552810199972gmail_msg">
>> -DEFAULTTUNE ?= "armv7ve-neon"<br class="m_2774803552810199972gmail_msg">
>> +DEFAULTTUNE ?= "armv7vethf-neon"<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> require conf/machine/include/arm/arch-<wbr>armv7ve.inc<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> diff --git a/meta/conf/machine/include/<wbr>tune-cortexa5.inc b/meta/conf/machine/include/<wbr>tune-cortexa5.inc<br class="m_2774803552810199972gmail_msg">
>> index 93f9ca4..1f0cda6 100644<br class="m_2774803552810199972gmail_msg">
>> --- a/meta/conf/machine/include/<wbr>tune-cortexa5.inc<br class="m_2774803552810199972gmail_msg">
>> +++ b/meta/conf/machine/include/<wbr>tune-cortexa5.inc<br class="m_2774803552810199972gmail_msg">
>> @@ -1,4 +1,4 @@<br class="m_2774803552810199972gmail_msg">
>> -DEFAULTTUNE ?= "armv7a-neon"<br class="m_2774803552810199972gmail_msg">
>> +DEFAULTTUNE ?= "armv7athf-neon"<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> require conf/machine/include/arm/arch-<wbr>armv7a.inc<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> diff --git a/meta/conf/machine/include/<wbr>tune-cortexa7.inc b/meta/conf/machine/include/<wbr>tune-cortexa7.inc<br class="m_2774803552810199972gmail_msg">
>> index 52e06b8..52415d9 100644<br class="m_2774803552810199972gmail_msg">
>> --- a/meta/conf/machine/include/<wbr>tune-cortexa7.inc<br class="m_2774803552810199972gmail_msg">
>> +++ b/meta/conf/machine/include/<wbr>tune-cortexa7.inc<br class="m_2774803552810199972gmail_msg">
>> @@ -1,4 +1,4 @@<br class="m_2774803552810199972gmail_msg">
>> -DEFAULTTUNE ?= "armv7ve-neon"<br class="m_2774803552810199972gmail_msg">
>> +DEFAULTTUNE ?= "armv7vethf-neon"<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> require conf/machine/include/arm/arch-<wbr>armv7ve.inc<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> diff --git a/meta/conf/machine/include/<wbr>tune-cortexa8.inc b/meta/conf/machine/include/<wbr>tune-cortexa8.inc<br class="m_2774803552810199972gmail_msg">
>> index a831bd5..8ee8de9 100644<br class="m_2774803552810199972gmail_msg">
>> --- a/meta/conf/machine/include/<wbr>tune-cortexa8.inc<br class="m_2774803552810199972gmail_msg">
>> +++ b/meta/conf/machine/include/<wbr>tune-cortexa8.inc<br class="m_2774803552810199972gmail_msg">
>> @@ -1,4 +1,4 @@<br class="m_2774803552810199972gmail_msg">
>> -DEFAULTTUNE ?= "armv7a-neon"<br class="m_2774803552810199972gmail_msg">
>> +DEFAULTTUNE ?= "armv7athf-neon"<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> require conf/machine/include/arm/arch-<wbr>armv7a.inc<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> diff --git a/meta/conf/machine/include/<wbr>tune-cortexa9.inc b/meta/conf/machine/include/<wbr>tune-cortexa9.inc<br class="m_2774803552810199972gmail_msg">
>> index 8b84e60..0cf323c 100644<br class="m_2774803552810199972gmail_msg">
>> --- a/meta/conf/machine/include/<wbr>tune-cortexa9.inc<br class="m_2774803552810199972gmail_msg">
>> +++ b/meta/conf/machine/include/<wbr>tune-cortexa9.inc<br class="m_2774803552810199972gmail_msg">
>> @@ -1,4 +1,4 @@<br class="m_2774803552810199972gmail_msg">
>> -DEFAULTTUNE ?= "armv7a-neon"<br class="m_2774803552810199972gmail_msg">
>> +DEFAULTTUNE ?= "armv7athf-neon"<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> require conf/machine/include/arm/arch-<wbr>armv7a.inc<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> --<br class="m_2774803552810199972gmail_msg">
>> 1.9.1<br class="m_2774803552810199972gmail_msg">
>><br class="m_2774803552810199972gmail_msg">
>> --<br class="m_2774803552810199972gmail_msg">
>> ______________________________<wbr>_________________<br class="m_2774803552810199972gmail_msg">
>> Openembedded-core mailing list<br class="m_2774803552810199972gmail_msg">
>> <a href="mailto:Openembedded-core@lists.openembedded.org" class="m_2774803552810199972gmail_msg" target="_blank">Openembedded-core@lists.<wbr>openembedded.org</a><br class="m_2774803552810199972gmail_msg">
>> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" class="m_2774803552810199972gmail_msg" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br class="m_2774803552810199972gmail_msg">
</blockquote></div></div></div></div>
<br>--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
<br></blockquote></div><br></div>