<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 21 March 2017 at 02:31, Vedang Patel <span dir="ltr"><<a href="mailto:vedang.patel@intel.com" target="_blank">vedang.patel@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Some options like python bindings, debug support, crypto are hardcoded<br>
inside the recipe. Change that to make those option configurable using<br>
PACKAGECONFIG.<br>
<br>
Signed-off-by: Vedang Patel <<a href="mailto:vedang.patel@intel.com">vedang.patel@intel.com</a>><br>
---<br>
meta/recipes-support/libxslt/<a href="http://libxslt_1.1.29.bb" rel="noreferrer" target="_blank">l<wbr>ibxslt_1.1.29.bb</a> | 9 +++++++--<br>
1 file changed, 7 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/meta/recipes-support/<wbr>libxslt/<a href="http://libxslt_1.1.29.bb" rel="noreferrer" target="_blank">libxslt_1.1.29.bb</a> b/meta/recipes-support/<wbr>libxslt/<a href="http://libxslt_1.1.29.bb" rel="noreferrer" target="_blank">libxslt_1.1.29.bb</a><br>
index be747e608d9d..d362118aa307 100644<br>
--- a/meta/recipes-support/<wbr>libxslt/<a href="http://libxslt_1.1.29.bb" rel="noreferrer" target="_blank">libxslt_1.1.29.bb</a><br>
+++ b/meta/recipes-support/<wbr>libxslt/<a href="http://libxslt_1.1.29.bb" rel="noreferrer" target="_blank">libxslt_1.1.29.bb</a><br>
@@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"<br>
<br>
BINCONFIG = "${bindir}/xslt-config"<br>
<br>
-inherit autotools pkgconfig binconfig-disabled lib_package<br>
+inherit autotools pkgconfig binconfig-disabled lib_package distutils-common-base<br>
<br>
# We don't DEPEND on binutils for ansidecl.h so ensure we don't use the header<br>
do_configure_prepend () {<br>
@@ -33,7 +33,12 @@ do_configure_prepend () {<br>
touch ${S}/doc/xsltproc.1<br>
}<br>
<br>
-EXTRA_OECONF = "--without-python --without-debug --without-mem-debug --without-crypto"<br>
+PACKAGECONFIG ??= "python libxslt-debug libxslt-mem-debug libxslt-crypto"<br></blockquote><div><br></div><div>You change all the defaults, is this on purpose? It should be noted in the commit message in any case.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+PACKAGECONFIG[libxslt-python] = "--with-python=${PYTHON_BASE_<wbr>VERSION}, --without-python"<br>
+PACKAGECONFIG[libxslt-debug] = "--with-debug, --without-debug"<br>
+PACKAGECONFIG[libxslt-mem-<wbr>debug] = "--with-mem-debug, --without-mem-debug"<br>
+PACKAGECONFIG[libxslt-crypto] = "--with-crypto, --without-crypto"<br>
+<br>
# older versions of this recipe had ${PN}-utils<br>
RPROVIDES_${PN}-bin += "${PN}-utils"<br>
RCONFLICTS_${PN}-bin += "${PN}-utils"<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.3<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></blockquote></div><br></div></div>