<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div>Hi Jussi,</div>
<div><br>
</div>
<div>On Tue, 2017-03-21 at 08:36 &#43;0000, Kukkonen, Jussi wrote:</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On 21 March 2017 at 02:31, Vedang Patel <span dir="ltr">
&lt;<a href="mailto:vedang.patel@intel.com" target="_blank">vedang.patel@intel.com</a>&gt;</span> wrote:<br>
<blockquote type="cite">Some options like python bindings, debug support, crypto are hardcoded<br>
inside the recipe. Change that to make those option configurable using<br>
PACKAGECONFIG.<br>
<br>
Signed-off-by: Vedang Patel &lt;<a href="mailto:vedang.patel@intel.com">vedang.patel@intel.com</a>&gt;<br>
---<br>
&nbsp;meta/recipes-support/libxslt/<a href="http://libxslt_1.1.29.bb" rel="noreferrer" target="_blank">l<wbr>ibxslt_1.1.29.bb</a> | 9 &#43;&#43;&#43;&#43;&#43;&#43;&#43;--<br>
&nbsp;1 file changed, 7 insertions(&#43;), 2 deletions(-)<br>
<br>
diff --git a/meta/recipes-support/<wbr>libxslt/<a href="http://libxslt_1.1.29.bb" rel="noreferrer" target="_blank">libxslt_1.1.29.bb</a> b/meta/recipes-support/<wbr>libxslt/<a href="http://libxslt_1.1.29.bb" rel="noreferrer" target="_blank">libxslt_1.1.29.bb</a><br>
index be747e608d9d..d362118aa307 100644<br>
--- a/meta/recipes-support/<wbr>libxslt/<a href="http://libxslt_1.1.29.bb" rel="noreferrer" target="_blank">libxslt_1.1.29.bb</a><br>
&#43;&#43;&#43; b/meta/recipes-support/<wbr>libxslt/<a href="http://libxslt_1.1.29.bb" rel="noreferrer" target="_blank">libxslt_1.1.29.bb</a><br>
@@ -22,7 &#43;22,7 @@ S = &quot;${WORKDIR}/libxslt-${PV}&quot;<br>
<br>
&nbsp;BINCONFIG = &quot;${bindir}/xslt-config&quot;<br>
<br>
-inherit autotools pkgconfig binconfig-disabled lib_package<br>
&#43;inherit autotools pkgconfig binconfig-disabled lib_package distutils-common-base<br>
<br>
&nbsp;# We don't DEPEND on binutils for ansidecl.h so ensure we don't use the header<br>
&nbsp;do_configure_prepend () {<br>
@@ -33,7 &#43;33,12 @@ do_configure_prepend () {<br>
&nbsp; &nbsp; &nbsp; &nbsp; touch ${S}/doc/xsltproc.1<br>
&nbsp;}<br>
<br>
-EXTRA_OECONF = &quot;--without-python --without-debug --without-mem-debug --without-crypto&quot;<br>
&#43;PACKAGECONFIG ??= &quot;python libxslt-debug libxslt-mem-debug libxslt-crypto&quot;<br>
<br>
</blockquote>
<div><br>
</div>
<div>You change all the defaults, is this on purpose? It should be noted in the commit message in any case.</div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote>
<div>Can you elabore on your concern? I am not exactly following it.</div>
<div><br>
</div>
<div>the configs won't be enabled unless the corresponding features are explicitly enabled in the image. I am using libxslt- prefix to make sure someone does not inadvertently enables the features by using the generic flags (python, debug, ... ).&nbsp;</div>
<div><br>
</div>
<div>I do see a bug here, In the first line, python should be replaced with libxslt-python. I will fix it in the next version of this patch.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Vedang Patel</div>
<div>Software Engineer</div>
<div>Intel Corporation</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div></div>
<div>&nbsp;</div>
<blockquote type="cite">&#43;PACKAGECONFIG[libxslt-python] = &quot;--with-python=${PYTHON_BASE_<wbr>VERSION}, --without-python&quot;<br>
&#43;PACKAGECONFIG[libxslt-debug] = &quot;--with-debug, --without-debug&quot;<br>
&#43;PACKAGECONFIG[libxslt-mem-<wbr>debug] = &quot;--with-mem-debug, --without-mem-debug&quot;<br>
&#43;PACKAGECONFIG[libxslt-crypto] = &quot;--with-crypto, --without-crypto&quot;<br>
&#43;<br>
&nbsp;# older versions of this recipe had ${PN}-utils<br>
&nbsp;RPROVIDES_${PN}-bin &#43;= &quot;${PN}-utils&quot;<br>
&nbsp;RCONFLICTS_${PN}-bin &#43;= &quot;${PN}-utils&quot;<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.3<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span><br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</body>
</html>