<div dir="ltr">Hi, Bruce:<div><br></div><div>Got your meaning, will send a V2 soon.</div><div><br></div><div>//Ming Liu</div></div><div class="gmail_extra"><br><div class="gmail_quote">2017-03-30 14:38 GMT+02:00 Bruce Ashfield <span dir="ltr"><<a href="mailto:bruce.ashfield@gmail.com" target="_blank">bruce.ashfield@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Thu, Mar 30, 2017 at 3:58 AM, <span dir="ltr"><<a href="mailto:liu.ming50@gmail.com" target="_blank">liu.ming50@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Ming Liu <<a href="mailto:peter.x.liu@external.atlascopco.com" target="_blank">peter.x.liu@external.atlascop<wbr>co.com</a>><br>
<br>
- Move the addtask statment that kernel_link_images needs run after<br>
do_compile from linux-yocto.inc to kernel.bbclass. Or else the recipes<br>
that inheriting kernel.bbclass might run into implicit dependency<br>
issues.<br>
- Fix a typo, "addtask do_strip" should be "addtask strip".<br>
- Remove some redundant addtask statments, when "addtask A after B" is<br>
set, then "addtask B before A" is not needed.<br></blockquote><div><br></div></span><div>These should be multiple commits. Whenever you find yourself listing changes in <br></div><div>a single commit header, it should really be multiple commits. Even if the changes<br></div><div>are small.<br></div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Signed-off-by: Ming Liu <<a href="mailto:peter.x.liu@external.atlascopco.com" target="_blank">peter.x.liu@external.atlascop<wbr>co.com</a>><br>
---<br>
meta/classes/kernel.bbclass | 5 +++--<br>
meta/recipes-kernel/linux/lin<wbr>ux-yocto.inc | 1 -<br>
2 files changed, 3 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass<br>
index 244087a..d175f1d 100644<br>
--- a/meta/classes/kernel.bbclass<br>
+++ b/meta/classes/kernel.bbclass<br>
@@ -538,6 +538,7 @@ do_kernel_link_images() {<br>
ln -sf ../../../vmlinuz.bin<br>
fi<br>
}<br>
+addtask kernel_link_images after do_compile<br>
<br>
do_strip() {<br>
if [ -n "${KERNEL_IMAGE_STRIP_EXTRA_SE<wbr>CTIONS}" ]; then<br>
@@ -566,7 +567,7 @@ do_strip() {<br>
}<br>
do_strip[dirs] = "${B}"<br>
<br>
-addtask do_strip before do_sizecheck after do_kernel_link_images<br>
+addtask strip before do_sizecheck after do_kernel_link_images<br>
<br>
# Support checking the kernel size since some kernels need to reside in partitions<br>
# with a fixed length or there is a limit in transferring the kernel to memory<br>
@@ -586,7 +587,7 @@ do_sizecheck() {<br>
}<br>
do_sizecheck[dirs] = "${B}"<br>
<br>
-addtask sizecheck before do_install after do_strip<br>
+addtask sizecheck before do_install<br></blockquote><div><br></div></div></div><div>Although possibly redundant, I don't see the problem with leaving this in place.<br></div><div>When we have the before and after here, it is self documenting when this should<br></div><div>run.<br><br></div><div>With this removed, the reader must track down all the task dependencies themselves<br></div><div>if they are to come to the same conclusion. Also, if that other task dependency changes,<br></div><div>this will change.<br><br></div><div>So I prefer that this stay completely defined and self documenting.<br><br></div><div>Bruce<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
KERNEL_IMAGE_BASE_NAME ?= "${PKGE}-${PKGV}-${PKGR}-${MAC<wbr>HINE}-${DATETIME}"<br>
# Don't include the DATETIME variable in the sstate package signatures<br>
diff --git a/meta/recipes-kernel/linux/li<wbr>nux-yocto.inc b/meta/recipes-kernel/linux/li<wbr>nux-yocto.inc<br>
index 556546f..637506a 100644<br>
--- a/meta/recipes-kernel/linux/li<wbr>nux-yocto.inc<br>
+++ b/meta/recipes-kernel/linux/li<wbr>nux-yocto.inc<br>
@@ -65,6 +65,5 @@ do_install_append(){<br>
<br>
# extra tasks<br>
addtask kernel_version_sanity_check after do_kernel_metadata do_kernel_checkout before do_compile<br>
-addtask kernel_link_images after do_compile before do_strip<br>
addtask validate_branches before do_patch after do_kernel_checkout<br>
addtask kernel_configcheck after do_configure before do_compile<br>
</span><span class="m_-6195538520088688080HOEnZb"><font color="#888888">--<br>
2.7.4<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openem<wbr>bedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br><div class="m_-6195538520088688080gmail_signature" data-smartmail="gmail_signature">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</div>
</font></span></div></div>
</blockquote></div><br></div>