<div dir="ltr">On 30 March 2017 at 00:12, Francisco Pedraza <span dir="ltr"><<a href="mailto:francisco.j.pedraza.gonzalez@intel.com" target="_blank">francisco.j.pedraza.gonzalez@intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">@@ -9,7 +9,9 @@ class GalculatorTest(OESDKTestCase):<br>
@classmethod<br>
def setUpClass(self):<br>
if not (self.tc.hasTargetPackage("<wbr>gtk+3") or\<br>
- self.tc.hasTargetPackage("<wbr>libgtk-3.0")):<br>
+ self.tc.hasTargetPackage("<wbr>libgtk-3.0") or<br>
+ self.tc.hasTargetPackage("gtk"<wbr>) or<br>
+ self.tc.hasTargetPackage("<wbr>matchbox-config-gtk")):<br>
raise unittest.SkipTest("<wbr>GalculatorTest class: SDK don't support gtk+3")<br></blockquote><div><br></div><div>Why is this checking for what appears to be gtk+v2 ("gtk") or matchbox-config-gtk (an application that shouldn't be in a SDK)?</div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">@@ -17,7 +17,9 @@ class BuildIptablesTest(<wbr>OESDKTestCase):<br>
<br>
machine = self.td.get("MACHINE")<br>
<br>
- if not self.tc.hasHostPackage("<wbr>packagegroup-cross-canadian-%<wbr>s" % machine):<br>
+ if not (self.tc.hasTargetPackage("<wbr>packagegroup-cross-canadian-%<wbr>s" % machine) or<br>
+ self.tc.hasTargetPackage("gcc-<wbr>runtime") or<br>
+ self.tc.hasTargetPackage("<wbr>libgcc")):<br>
raise unittest.SkipTest("SDK doesn't contain a cross-canadian toolchain")<br></blockquote><div><br></div><div>Seems a very long-winded way of checking that a compiler is present...</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">@@ -8,7 +8,10 @@ from oeqa.sdk.case import OESDKTestCase<br>
class PerlTest(OESDKTestCase):<br>
@classmethod<br>
def setUpClass(self):<br>
- if not self.tc.hasHostPackage("<wbr>nativesdk-perl"):<br>
+ if not (self.tc.hasHostPackage("<wbr>nativesdk-perl") or<br>
+ self.tc.hasHostPackage("perl-<wbr>native") or<br>
+ self.tc.hasHostPackage("<wbr>libperl5") or<br>
+ self.tc.hasHostPackage("perl")<wbr>):<br>
raise unittest.SkipTest("No perl package in the SDK")<br></blockquote><div><br></div><div>As this is a test for the nativesdk part of the SDK, why does it care about target (perl) or native (perl-native) packages?</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
for f in ['<a href="http://test.pl" rel="noreferrer" target="_blank">test.pl</a>']:<br>
diff --git a/meta/lib/oeqa/sdk/cases/<wbr>python.py b/meta/lib/oeqa/sdk/cases/<wbr>python.py<br>
index 94a296f..29705bf 100644<br>
--- a/meta/lib/oeqa/sdk/cases/<wbr>python.py<br>
+++ b/meta/lib/oeqa/sdk/cases/<wbr>python.py<br>
@@ -8,7 +8,10 @@ from oeqa.sdk.case import OESDKTestCase<br>
class PythonTest(OESDKTestCase):<br>
@classmethod<br>
def setUpClass(self):<br>
- if not self.tc.hasHostPackage("<wbr>nativesdk-python"):<br>
+ if not (self.tc.hasHostPackage("<wbr>nativesdk-python") or<br>
+ self.tc.hasHostPackage("<wbr>python-smartpm-native") or<br>
+ self.tc.hasHostPackage("<wbr>nativesdk-python3")):</blockquote><div><br></div><div><br></div><div>Aside from the fact that oe-core master has recently moved from smart to DNF, and Python2 to Python3, why does a test that just runs a basic Python command care about smartpm?</div><div><br></div><div>Also the test also now checks for nativesdk-python3 but executes python, which is python v2.</div><div><br></div><div>Ross</div></div></div></div>