<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 10, 2017 at 9:09 AM, Patrick Ohly <span dir="ltr"><<a href="mailto:patrick.ohly@intel.com" target="_blank">patrick.ohly@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, 2017-04-10 at 08:59 -0400, Bruce Ashfield wrote:<br>
><br>
><br>
> On Mon, Apr 10, 2017 at 8:49 AM, Patrick Ohly <<a href="mailto:patrick.ohly@intel.com">patrick.ohly@intel.com</a>><br>
> wrote:<br>
</span>[...]<br>
<span class="">> diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass<br>
> index 85f71a2e9a6..ac41c80d377 100644<br>
> --- a/meta/classes/go.bbclass<br>
> +++ b/meta/classes/go.bbclass<br>
> @@ -26,7 +26,7 @@ export CGO_CPPFLAGS = "${TARGET_CPPFLAGS}"<br>
> export CGO_CXXFLAGS = "${TARGET_CC_ARCH}${TOOLCHAIN_<wbr>OPTIONS}<br>
> ${TARGET_CXXFLAGS}"<br>
> export CGO_LDFLAGS = "${TARGET_CC_ARCH}${TOOLCHAIN_<wbr>OPTIONS}<br>
> ${TARGET_LDFLAGS}"<br>
><br>
> -DEPENDS += "go-cross-${TARGET_ARCH}"<br>
> +DEPENDS += "go-cross-${TUNE_PKGARCH}"<br>
> DEPENDS_class-native += "go-native"<br>
><br>
> FILES_${PN}-staticdev += "${GOSRC_FINAL}/${GO_IMPORT}"<br>
</span>[...]<br>
<span class=""><br>
> This requires any layers with existing DEPENDS on go-cross-${TARGET}<br>
> to be updated,<br>
<br>
</span>"inherit go" hides that detail, so only recipes which depend on<br>
go-cross-${TARGET_ARCH} directly instead of using go.bbclass need to be<br>
updated (and perhaps should be changed to use go.bbclass instead?).<br></blockquote><br></div><div class="gmail_quote">True!<br><br></div><div class="gmail_quote">I don't universally use the go bbclass in oe-core, since my recipes all predate<br></div><div class="gmail_quote">it by a significant amount.<br><br></div><div class="gmail_quote">Either way, I still have a problem when changes like this merge into oe-core and<br></div><div class="gmail_quote">I never know exactly when .. until I get the email of people telling me that things<br></div><div class="gmail_quote">are broken in meta-virt :D<br><br></div><div class="gmail_quote">Bruce<br></div><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
But I'm not a go expert, so let's hear from those first ;-}<br>
<div class="HOEnZb"><div class="h5"><br>
--<br>
Best Regards, Patrick Ohly<br>
<br>
The content of this message is my personal opinion only and although<br>
I am an employee of Intel, the statements I make here in no way<br>
represent Intel's position on the issue, nor am I authorized to speak<br>
on behalf of Intel on this matter.<br>
<br>
<br>
<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</div>
</div></div>