<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On 21 April 2017 at 22:09, Khem Raj <span dir="ltr">&lt;<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div id="gmail-:235" class="gmail-a3s gmail-aXjCH gmail-m15b925a4c4ccc42a">backport patches from upsteam and adapt them to 2.0 codebase<br></div></blockquote></div><br>This fails for me (and the autobuilders) in grub-core/video/i386/pc/vbe.c which was fixed upstream in 2015 and the file hasn&#39;t been touched since.</div><div class="gmail_extra"><br></div><div class="gmail_extra">This makes me wonder why are we building code that was released before then, and is VBE still a thing?  Last time I remember seeing those letters was around 2000 on my new Pentium...</div><div class="gmail_extra"><br></div><div class="gmail_extra">Fix those and now it fails for me in:</div><div class="gmail_extra"><br></div><div class="gmail_extra"><div class="gmail_extra"> ../../grub-2.00/grub-core/loader/i386/pc/linux.c: In function &#39;grub_cmd_linux&#39;:</div><div class="gmail_extra">| ../../grub-2.00/grub-core/loader/i386/pc/linux.c:254:9: error: this statement may fall through [-Werror=implicit-fallthrough=]</div><div class="gmail_extra">|    shift += 10;</div><div class="gmail_extra">|    ~~~~~~^~~~~</div><div class="gmail_extra">| ../../grub-2.00/grub-core/loader/i386/pc/linux.c:255:8: note: here</div><div class="gmail_extra">|         case &#39;m&#39;:</div><div class="gmail_extra">|         ^~~~</div><div class="gmail_extra">| ../../grub-2.00/grub-core/loader/i386/pc/linux.c:256:9: error: this statement may fall through [-Werror=implicit-fallthrough=]</div><div class="gmail_extra">|    shift += 10;</div><div class="gmail_extra">|    ~~~~~~^~~~~</div><div class="gmail_extra">| ../../grub-2.00/grub-core/loader/i386/pc/linux.c:257:8: note: here</div><div class="gmail_extra">|         case &#39;k&#39;:</div><div class="gmail_extra">|         ^~~~</div><div class="gmail_extra"><br></div><div class="gmail_extra">Clearly there&#39;s some build difference between our configurations. Are you building grub-git instead of grub_2.00?  Should we delete grub_2.00 if its that old?  I&#39;d say that it looks good for a new upstream 2.02 release as there is a 2.02-rc2 tagged just six weeks ago, but 2.02-beta1 was tagged three years ago...</div><div class="gmail_extra"><br></div><div class="gmail_extra">Ross</div></div></div>