<div dir="ltr"><div>On Tue, Apr 25, 2017 at 11:13 AM, Martin Jansa &lt;<a href="mailto:martin.jansa@gmail.com">martin.jansa@gmail.com</a>&gt; wrote:<br>&gt;<br>&gt; On Tue, Apr 25, 2017 at 10:48:37AM -0400, Marc Ferland wrote:<br>&gt; &gt; Signed-off-by: Marc Ferland &lt;<a href="mailto:ferlandm@amotus.ca">ferlandm@amotus.ca</a>&gt;<br>&gt; &gt; ---<br>&gt; &gt;  meta/recipes-connectivity/bluez5/bluez5.inc | 4 ++--<br>&gt; &gt;  1 file changed, 2 insertions(+), 2 deletions(-)<br>&gt; &gt;<br>&gt; &gt; diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc<br>&gt; &gt; index 687656e..71a5016 100644<br>&gt; &gt; --- a/meta/recipes-connectivity/bluez5/bluez5.inc<br>&gt; &gt; +++ b/meta/recipes-connectivity/bluez5/bluez5.inc<br>&gt; &gt; @@ -12,11 +12,12 @@ RPROVIDES_${PN} += &quot;bluez-hcidump&quot;<br>&gt; &gt;<br>&gt; &gt;  RCONFLICTS_${PN} = &quot;bluez4&quot;<br>&gt; &gt;<br>&gt; &gt; -PACKAGECONFIG ??= &quot;obex-profiles readline&quot;<br>&gt; &gt; +PACKAGECONFIG ??= &quot;obex-profiles readline ${@bb.utils.filter(&#39;DISTRO_FEATURES&#39;, &#39;systemd&#39;, d)}&quot;<br>&gt; &gt;  PACKAGECONFIG[obex-profiles] = &quot;--enable-obex,--disable-obex,libical&quot;<br>&gt; &gt;  PACKAGECONFIG[readline] = &quot;--enable-client,--disable-client,readline,&quot;<br>&gt; &gt;  PACKAGECONFIG[testing] = &quot;--enable-testing,--disable-testing&quot;<br>&gt; &gt;  PACKAGECONFIG[midi] = &quot;--enable-midi,--disable-midi,alsa-lib&quot;<br>&gt; &gt; +PACKAGECONFIG[systemd] = &quot;--enable-systemd,--disable-systemd&quot;<br>&gt; &gt;<br>&gt; &gt;  SRC_URI = &quot;\<br>&gt; &gt;      ${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \<br>&gt; &gt; @@ -36,7 +37,6 @@ EXTRA_OECONF = &quot;\<br>&gt; &gt;    --disable-cups \<br>&gt; &gt;    --enable-test \<br>&gt; &gt;    --enable-datafiles \<br>&gt; &gt; -  ${@bb.utils.contains(&#39;DISTRO_FEATURES&#39;, &#39;systemd&#39;, &#39;--enable-systemd&#39;, &#39;--disable-systemd&#39;, d)} \<br>&gt;<br>&gt; Why not use just the options from PACKAGECONFIG?<br>&gt;<br>&gt; &gt;    --enable-library \<br>&gt; &gt;  &quot;<br><br>enable-library builds and installs the libbluetooth library along with<br>the header files. I guess it&#39;s something pretty much everyone<br>wants/expects, a sane default, probably also why it was &quot;hard-coded&quot;<br>in EXTRA_OECONF.<br><br>There are many other build options in bluez5 which aren&#39;t exposed as<br>PACKAGECONFIG options. The majority of them being for more finer<br>grained stuff (the current options are mostly for obvious external<br>dependencies).<br><br>I&#39;ll take a look at it and come up with a separate patch if that&#39;s okay.<br><br></div>Marc<br></div>