<div dir="ltr">Agreed. I didn't see his patch, when I did the fix (and didn't check again when posting the fix). Amusing we did it at the same time. I'm fine with either patch as the loop shouldn't be triggered in general, nor do I think it would really help ...<div><br></div><div>-brian </div><div>an intel employee </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 1, 2017 at 4:15 PM, Martin Kelly <span dir="ltr"><<a href="mailto:mkelly@xevo.com" target="_blank">mkelly@xevo.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looks like this is addressing the same problem as Jan's patch from earlier today. I think the differences are:<br>
<br>
- kill vs start-stop-daemon<br>
<br>
- Jan removed the retry loop while this patch does not<div class="HOEnZb"><div class="h5"><br>
<br>
On 05/01/2017 02:59 PM, brian avery wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The current initscript was lacking a -USR2 signal in the stop section.<br>
This resulted in /etc/init.d/tcf-agent stop; taking roughly 10 seconds<br>
then failing to kill the tcf-agent process. This patch brings us in line<br>
with how upstream stops the agent.<br>
<br>
Fixes [YOCTO #10858]<br>
<br>
Signed-off-by: brian avery <<a href="mailto:brian.avery@intel.com" target="_blank">brian.avery@intel.com</a>><br>
---<br>
meta/recipes-devtools/tcf-age<wbr>nt/tcf-agent/tcf-agent.init | 3 +--<br>
1 file changed, 1 insertion(+), 2 deletions(-)<br>
<br>
diff --git a/meta/recipes-devtools/tcf-ag<wbr>ent/tcf-agent/tcf-agent.init b/meta/recipes-devtools/tcf-ag<wbr>ent/tcf-agent/tcf-agent.init<br>
index 6303280..13497cc 100755<br>
--- a/meta/recipes-devtools/tcf-ag<wbr>ent/tcf-agent/tcf-agent.init<br>
+++ b/meta/recipes-devtools/tcf-ag<wbr>ent/tcf-agent/tcf-agent.init<br>
@@ -35,7 +35,7 @@ case "$1" in<br>
echo -n "Stopping $DAEMON_NAME: "<br>
count=0<br>
while [ -n "`/bin/pidof $DAEMON_PATH`" -a $count -lt 10 ] ; do<br>
- killproc $DAEMON_PATH >& /dev/null<br>
+ kill -USR2 `pidofproc $DAEMON_PATH` >& /dev/null<br>
sleep 1<br>
RETVAL=$?<br>
if [ $RETVAL != 0 -o -n "`/bin/pidof $DAEMON_PATH`" ] ; then<br>
@@ -72,4 +72,3 @@ case "$1" in<br>
esac<br>
<br>
exit $RETVAL<br>
-<br>
<br>
</blockquote>
-- <br></div></div><div class="HOEnZb"><div class="h5">
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openem<wbr>bedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</div></div></blockquote></div><br></div>