<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 06/21/2017 08:28 AM, Christopher
Larson wrote:<br>
</div>
<blockquote
cite="mid:CABcZANmLQno0gXMoaBPz22WpsoPCvkCySe1JY+m7L4n5TTqsLw@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Jun 20, 2017 at 5:14 PM,
California Sullivan <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:california.l.sullivan@intel.com"
target="_blank">california.l.sullivan@intel.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div id=":12j" class="a3s aXjCH m15cc800708907dec">Using
+= makes it difficult to remove. Soft-set with ?=
instead.<br>
<br>
Signed-off-by: California Sullivan <<a
moz-do-not-send="true"
href="mailto:california.l.sullivan@intel.com">california.l.sullivan@intel.<wbr>com</a>><br>
---<br>
meta/conf/machine/include/x86-<wbr>base.inc | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/meta/conf/machine/include/<wbr>x86-base.inc
b/meta/conf/machine/include/<wbr>x86-base.inc<br>
index 7365953..bfacdf5 100644<br>
--- a/meta/conf/machine/include/<wbr>x86-base.inc<br>
+++ b/meta/conf/machine/include/<wbr>x86-base.inc<br>
@@ -10,7 +10,7 @@ MACHINE_FEATURES += "screen keyboard
pci usbhost ext2 ext3 x86 \<br>
<br>
MACHINE_EXTRA_RRECOMMENDS += "kernel-modules"<br>
<br>
-IMAGE_FSTYPES += "live"<br>
+IMAGE_FSTYPES ?= "live"</div>
</blockquote>
</div>
<br>
I’m assuming you verified that none of the existing machines
including this were depending on the += behavior to add to the
current value? And this would almost certainly result in a
different default for any machines that don’t adjust
IMAGE_FSTYPES at all, since it’d be adding to the bitbake.conf
or distro default.<br>
</div>
</div>
</blockquote>
<br>
I tested genericx86, genericx86-64, intel-corei7-64 and
intel-core2-32, and their IMAGE_FSTYPES values were the same with
and without this patch.<br>
<br>
x86-base.inc is the first thing parsed that sets IMAGE_FSTYPES for
all these machines, and since += is applied immediately its
effectively setting a default value. A ?= from bitbake.conf for
distro conf won't actually get applied with or without this patch.<br>
<br>
I'm not aware of other machines that inherit x86-base.inc, but I'd
think it would be the same for them.<br>
<br>
Thanks,<br>
Cal<br>
<br>
<blockquote
cite="mid:CABcZANmLQno0gXMoaBPz22WpsoPCvkCySe1JY+m7L4n5TTqsLw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">-- <br>
<div class="gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">Christopher Larson<br>
kergoth at gmail dot com<br>
Founder - BitBake, OpenEmbedded, OpenZaurus<br>
Senior Software Engineer, Mentor Graphics</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>