<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 22, 2017 at 9:48 PM, Robert Yang <span dir="ltr"><<a href="mailto:liezhi.yang@windriver.com" target="_blank">liezhi.yang@windriver.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
On 06/22/2017 11:07 PM, Bruce Ashfield wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
<br>
On Thu, Jun 22, 2017 at 4:30 AM, Robert Yang <<a href="mailto:liezhi.yang@windriver.com" target="_blank">liezhi.yang@windriver.com</a><br></span><span class="">
<mailto:<a href="mailto:liezhi.yang@windriver.com" target="_blank">liezhi.yang@windriver.<wbr>com</a>>> wrote:<br>
<br>
The following commit has removed rpc ports from runqemu-export-rootfs, so<br>
runqemu should also remove them, otherwise "runqemu nfs" doesn't work. And use<br>
abspath for nfsroot, otherwise it doesn't work when it is a relative path.<br>
<br>
<br>
That change in question was discussed on list and was supposed to be optional.<br>
<br>
Can you confirm that a non-root user can still do a NFS root with both of these<br>
changes applied ?<br>
</span></blockquote>
<br>
The runqemu-export-rootfs uses UNFS, no root privilege is required, I can confirm that both "runqemu slirp nfs" and "runqemu nfs" work well, so I assume<br>
the answer is yes.<br></blockquote><div><br></div><div>Yes, that's good enough to confirm the old functionality. As long as non-privileged ports can be used, we should be fine.</div><div><br></div><div>Bruce</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
// Robert<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Bruce<br>
<br>
<br>
commit 6bb9860ef7ba9c84fe9bd3a81aa655<wbr>5f67ebd38e<br>
Author: Cody P Schafer <<a href="mailto:dev@codyps.com" target="_blank">dev@codyps.com</a> <mailto:<a href="mailto:dev@codyps.com" target="_blank">dev@codyps.com</a>>><span class=""><br>
Date: Tue Jun 6 18:30:49 2017 -0400<br>
<br>
runqemu-export-rootfs: don't change RPC ports<br>
<br>
[YOCTO #11687]<br>
<br>
Signed-off-by: Robert Yang <<a href="mailto:liezhi.yang@windriver.com" target="_blank">liezhi.yang@windriver.com</a><br></span>
<mailto:<a href="mailto:liezhi.yang@windriver.com" target="_blank">liezhi.yang@windriver.<wbr>com</a>>><div><div class="h5"><br>
---<br>
scripts/runqemu | 8 ++------<br>
1 file changed, 2 insertions(+), 6 deletions(-)<br>
<br>
diff --git a/scripts/runqemu b/scripts/runqemu<br>
index 26328e5b512..41b870c9f7c 100755<br>
--- a/scripts/runqemu<br>
+++ b/scripts/runqemu<br>
@@ -784,16 +784,12 @@ class BaseConfig(object):<br>
all_instances.sort(key=int)<br>
self.nfs_instance = int(all_instances.pop()) + 1<br>
<br>
- mountd_rpcport = 21111 + self.nfs_instance<br>
- nfsd_rpcport = 11111 + self.nfs_instance<br>
nfsd_port = 3049 + 2 * self.nfs_instance<br>
mountd_port = 3048 + 2 * self.nfs_instance<br>
<br>
# Export vars for runqemu-export-rootfs<br>
export_dict = {<br>
'NFS_INSTANCE': self.nfs_instance,<br>
- 'MOUNTD_RPCPORT': mountd_rpcport,<br>
- 'NFSD_RPCPORT': nfsd_rpcport,<br>
'NFSD_PORT': nfsd_port,<br>
'MOUNTD_PORT': mountd_port,<br>
}<br>
@@ -801,7 +797,7 @@ class BaseConfig(object):<br>
# Use '%s' since they are integers<br>
os.putenv(k, '%s' % v)<br>
<br>
-<br>
self.unfs_opts="nfsvers=3,port<wbr>=%s,mountprog=%s,nfsprog=%s,<wbr>udp,mountport=%s"<br>
% (nfsd_port, mountd_rpcport, nfsd_rpcport, mountd_port)<br>
+ self.unfs_opts="nfsvers=3,port<wbr>=%s,udp,mountport=%s" % (nfsd_port,<br>
mountd_port)<br>
<br></div></div>
# Extract .tar.bz2 or .<a href="http://tar.bz" rel="noreferrer" target="_blank">tar.bz</a> <<a href="http://tar.bz" rel="noreferrer" target="_blank">http://tar.bz</a>> if no nfs dir<span class=""><br>
if not (self.rootfs and os.path.isdir(self.rootfs)):<br>
@@ -1006,7 +1002,7 @@ class BaseConfig(object):<br>
<br>
if self.fstype == 'nfs':<br>
self.rootfs_options = ''<br>
- k_root = '/dev/nfs nfsroot=%s:%s,%s' % (self.nfs_server,<br>
self.rootfs, self.unfs_opts)<br>
+ k_root = '/dev/nfs nfsroot=%s:%s,%s' % (self.nfs_server,<br>
os.path.abspath(self.rootfs), self.unfs_opts)<br>
self.kernel_cmdline = 'root=%s rw highres=off' % k_root<br>
<br>
if self.fstype == 'none':<br>
--<br>
2.11.0<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openem<wbr>bedded.org</a><br></span>
<mailto:<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@list<wbr>s.openembedded.org</a>><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><span class=""><br>
<<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org<wbr>/mailman/listinfo/openembedded<wbr>-core</a>><br>
<br>
<br>
<br>
<br>
--<br>
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its<br>
end"<br>
</span></blockquote>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</div>
</div></div>