<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On 21 June 2017 at 20:06, <span dir="ltr"><<a href="mailto:yin.thong.choong@intel.com" target="_blank">yin.thong.choong@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div id="gmail-:17y" class="gmail-a3s gmail-aXjCH gmail-m15ccd97a3c51264e">+ if [ -z "$mkubifs_args"] || [ -z "$ubinize_args" ]; then<br>
+ bberror "MKUBIFS_ARGS and UBINIZE_ARGS argument have to set for UBI and UBIFS image creation."<br>
+ bberror "Detail please visit this link <a href="http://www.linux-mtd.infradead.org/faq/ubifs.html" rel="noreferrer" target="_blank">http://www.linux-mtd.<wbr>infradead.org/faq/ubifs.html</a>"<br>
+ return<br>
+ fi<br></div></blockquote></div><br>bberror isn't fatal but this is a fatal problem so the task needs to fail. You could emit the first line with bberror and the second with bbfatal, but its would be clearer if it was one line, such as:</div><div class="gmail_extra"><br></div><div class="gmail_extra">bbfatal "MKUBIFS_ARGS and UBINIZE_ARGS have to be set, see <a href="http://www.linux-mtd.infradead.org/faq/ubifs.html">http://www.linux-mtd.infradead.org/faq/ubifs.html</a> for details"</div><div class="gmail_extra"><br></div><div class="gmail_extra">As bbfatal does an exit, there's no need for the return either.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Ross</div></div>