<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 27, 2017 at 8:33 AM, Patrick Ohly <span dir="ltr"><<a href="mailto:patrick.ohly@intel.com" target="_blank">patrick.ohly@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":1hh" class="a3s aXjCH m15cea306d592b2e3">add_layer_dependencies() might get called more than once, or one of<br>
the layer dependencies might already be present. The function should<br>
not add layers again because doing so can cause warnings like:<br>
<br>
WARNING: Duplicate inclusion for .../meta-openembedded/meta-oe/<wbr><span class="il">conf</span>/distro/include/meta_oe_<wbr>security_flags.inc in .../meta-openembedded/meta-oe/<wbr><span class="il">conf</span>/layer.<span class="il">conf</span><br>
<br>
Signed-off-by: Patrick Ohly <<a href="mailto:patrick.ohly@intel.com">patrick.ohly@intel.com</a>><br>
---</div></blockquote></div><br>I’m curious about why this isn’t either just calling out to `bitbake-layers add-layer` or using one of the existing functions we have for modifying bblayers, rather than doing its own +=.<br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Christopher Larson<br>kergoth at gmail dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Senior Software Engineer, Mentor Graphics</div></div></div></div>
</div></div>