<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 27 June 2017 at 00:51, Maxime Roussin-Belanger <span dir="ltr"><<a href="mailto:maxime.roussinbelanger@gmail.com" target="_blank">maxime.roussinbelanger@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On Mon, Jun 26, 2017 at 04:41:34PM -0300, Otavio Salvador wrote:<br>
> On Mon, Jun 26, 2017 at 3:33 PM, Maxime Roussin-Bélanger<br>
> <<a href="mailto:maxime.roussinbelanger@gmail.com">maxime.roussinbelanger@gmail.<wbr>com</a>> wrote:<br>
> > CMake does not define the `find_host_program` command we've<br>
> > been using in the cross-compiling code path. It was<br>
> > provided by a widely used Android toolchain file. For<br>
> > compatibility, continue to use `find_host_program` if<br>
> > available, but otherwise use just `find_program`.<br>
> ><br>
> > Signed-off-by: Maxime Roussin-Bélanger <<a href="mailto:maxime.roussinbelanger@gmail.com">maxime.roussinbelanger@gmail.<wbr>com</a>><br>
><br>
> It sounds fine to me; the backward compatibility is maintained and it<br>
> fixes a real use-case so I see no reason to not apply EXCEPT:<br>
><br>
> - lack of Upstream-Status field<br>
> - lack of upstream bug about the issue, ideally the proposed patch<br>
> should be send to upstream so we can drop it in next releases<br>
><br>
<br>
</span>I just got r/w access to the poky-contrib repository. Do I have to create<br>
a pull-request/send-pull-request to get an upstream-status field?<br>
<br>
Can we ignore this email and just use the pull-request script instead?<br>
<br>
If so, do I have to resend the same patch (V2 ?) to the same recipients?<br></blockquote><div><br></div><div>You should send a V2 with Upstream-Status (see below). You can use poky-contrib and the pull-request scripts but you can also just send the patch, it's up to you. </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
If not, how do I get an upstream-status? I just pushed my branch to contrib<br>
repository (mroussin/fix_cmake_find_cuda_<wbr>not_android), does that mean pending?<br></blockquote><div><br></div><div>Upstream-Status refers to what's happening in _upstream project_, not in yocto: you should decide what the appropriate value is -- but everyone would like if it was "submitted" (in other words you have sent a patch to the cmake project using whatever method they prefer). At the very least you should file a bug upstream. Please add a link to the upstream pull request or bug report into the yocto patch: that way it's easy to check later on if the patch is still needed.</div><div><br></div><div>There's no tooling to add the tag if that was what you were wondering, just write it by hand.</div><div><br></div><div>See also: <a href="https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines">https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines</a><br></div><div><br></div><div><br></div><div>Jussi</div><div> </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="gmail-HOEnZb"><div class="gmail-h5"><br>
<br>
> --<br>
> Otavio Salvador O.S. Systems<br>
> <a href="http://www.ossystems.com.br" rel="noreferrer" target="_blank">http://www.ossystems.com.br</a> <a href="http://code.ossystems.com.br" rel="noreferrer" target="_blank">http://code.ossystems.com.br</a><br>
> Mobile: <a href="tel:%2B55%20%2853%29%209981-7854" value="+555399817854">+55 (53) 9981-7854</a> Mobile: <a href="tel:%2B1%20%28347%29%20903-9750" value="+13479039750">+1 (347) 903-9750</a><br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</div></div></blockquote></div><br></div></div>