<div dir="ltr"><span style="font-size:14px">Hi, Christopher:</span><div style="font-size:14px"><br></div><div style="font-size:14px">I am on board, using '+=' in local.conf.sample.extended is a good idea, I will send a V2 soon.</div><div style="font-size:14px"><br></div><div style="font-size:14px">the best,</div><div style="font-size:14px">thank you </div></div><div class="gmail_extra"><br><div class="gmail_quote">2017-07-06 17:20 GMT+02:00 Christopher Larson <span dir="ltr"><<a href="mailto:kergoth@gmail.com" target="_blank">kergoth@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Thu, Jul 6, 2017 at 7:40 AM, <span dir="ltr"><<a href="mailto:liu.ming50@gmail.com" target="_blank">liu.ming50@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Ming Liu <<a href="mailto:peter.x.liu@external.atlascopco.com" target="_blank">peter.x.liu@external.atlascop<wbr>co.com</a>><br>
<br>
The code logic in image-mklibs.bbclass and image-prelink.bbclass is all<br>
about optimizing the rootfs image, so it makes more sense to put them<br>
into IMAGE_CLASSES rather than USER_CLASSES.<br>
<br>
What's more, this fixes a potential issue by moving out image-mklibs<br>
from INHERIT, considering that, a following dependency is missing in<br>
image-mklibs.bblcass:<br>
...<br>
do_rootfs[depends] += "virtual/${MLPREFIX}${TARGET_P<wbr>REFIX}binutils:do_populate_sys<wbr>root"<br></blockquote><div><br></div></span><div>This removes the example usage of IMAGE_CLASSES to alter the default image types inclusion in local.conf.sample.extended, but doesn’t replace it with anything, and the commit message doesn’t mention it. Either find a way to fix that example (i.e. use += or something) or at least mention that you’re removing it, particularly since adding image types is currently the most common reason to alter that variable.</div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_-2703570553273090860gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Christopher Larson<br>kergoth at gmail dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Senior Software Engineer, Mentor Graphics</div></div></div></div>
</font></span></div></div>
</blockquote></div><br></div>