<div dir="ltr">Hi, Nathan:<div><br></div><div>Yes, you are absolutely right, my previous understanding of KEEPUIMAGE was wrong, thanks for pointing it out, please ignore my patch then.</div><div><br></div><div>//Ming Liu</div></div><div class="gmail_extra"><br><div class="gmail_quote">2017-07-23 13:24 GMT+02:00 Nathan Rossi <span dir="ltr"><<a href="mailto:nathan@nathanrossi.com" target="_blank">nathan@nathanrossi.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 23 July 2017 at 20:11, <<a href="mailto:liu.ming50@gmail.com">liu.ming50@gmail.com</a>> wrote:<br>
> From: Ming Liu <<a href="mailto:peter.x.liu@external.atlascopco.com">peter.x.liu@external.<wbr>atlascopco.com</a>><br>
><br>
> do_uboot_mkimage would not run if KEEPUIMAGE not equal to 'yes', so it<br>
> does not have to DEPENDS on u-boot-mkimage-native in that case.<br>
<br>
</span>This change breaks KEEPUIMAGE == yes. Where the kernel built uImage<br>
make target needs u-boot-mkimage-native. This is a common use case.<br>
<br>
| UIMAGE arch/arm/boot/uImage<br>
| "mkimage" command not found - U-Boot images will not be built<br>
| arch/arm/boot/Makefile:79: recipe for target 'arch/arm/boot/uImage' failed<br>
| make[3]: *** [arch/arm/boot/uImage] Error 1<br>
| arch/arm/Makefile:329: recipe for target 'uImage' failed<br>
| make[2]: *** [uImage] Error 2<br>
<br>
Regards,<br>
Nathan<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> Signed-off-by: Ming Liu <<a href="mailto:peter.x.liu@external.atlascopco.com">peter.x.liu@external.<wbr>atlascopco.com</a>><br>
> ---<br>
> meta/classes/kernel-uimage.<wbr>bbclass | 8 ++++----<br>
> 1 file changed, 4 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/meta/classes/kernel-uimage.<wbr>bbclass b/meta/classes/kernel-uimage.<wbr>bbclass<br>
> index 7c026ab..94344d9 100644<br>
> --- a/meta/classes/kernel-uimage.<wbr>bbclass<br>
> +++ b/meta/classes/kernel-uimage.<wbr>bbclass<br>
> @@ -2,16 +2,16 @@ inherit kernel-uboot<br>
><br>
> python __anonymous () {<br>
> if "uImage" in (d.getVar('KERNEL_IMAGETYPES') or "").split():<br>
> - depends = d.getVar("DEPENDS")<br>
> - depends = "%s u-boot-mkimage-native" % depends<br>
> - d.setVar("DEPENDS", depends)<br>
> -<br>
> # Override KERNEL_IMAGETYPE_FOR_MAKE variable, which is internal<br>
> # to kernel.bbclass . We override the variable here, since we need<br>
> # to build uImage using the kernel build system if and only if<br>
> # KEEPUIMAGE == yes. Otherwise, we pack compressed vmlinux into<br>
> # the uImage .<br>
> if d.getVar("KEEPUIMAGE") != 'yes':<br>
> + depends = d.getVar("DEPENDS")<br>
> + depends = "%s u-boot-mkimage-native" % depends<br>
> + d.setVar("DEPENDS", depends)<br>
> +<br>
> typeformake = d.getVar("KERNEL_IMAGETYPE_<wbr>FOR_MAKE") or ""<br>
> if "uImage" in typeformake.split():<br>
> d.setVar('KERNEL_IMAGETYPE_<wbr>FOR_MAKE', typeformake.replace('uImage', 'vmlinux'))<br>
> --<br>
> 2.7.4<br>
><br>
</div></div><span class="HOEnZb"><font color="#888888">> --<br>
> ______________________________<wbr>_________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></blockquote></div><br></div>