<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.hoenzb
{mso-style-name:hoenzb;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Sure, no problem, rebase is in progress now.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Rebecca<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Burton, Ross [mailto:ross.burton@intel.com]
<br>
<b>Sent:</b> Friday, July 21, 2017 9:50 PM<br>
<b>To:</b> Chang, Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com><br>
<b>Cc:</b> OpenEmbedded Core Mailing List <openembedded-core@lists.openembedded.org><br>
<b>Subject:</b> Re: [OE-core] [PATCHv2 1/4] recipetool: create: disable PREMIRRORS and MIRRORS by default<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Sorry, we're conflicting again. Too many people working on the same bit of code! Can you rebase this onto origin/master-next?<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Ross<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 20 July 2017 at 11:31, Chang Rebecca Swee Fun <<a href="mailto:rebecca.swee.fun.chang@intel.com" target="_blank">rebecca.swee.fun.chang@intel.com</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">When creating new recipes, we are almost certainly fetching a new<br>
source rather that something that has already been fetched. I have<br>
disable PREMIRRORS and MIRRORS settings from datastore while leaving<br>
an option for users to enable them manually if needed.<br>
<br>
Signed-off-by: Chang Rebecca Swee Fun <<a href="mailto:rebecca.swee.fun.chang@intel.com">rebecca.swee.fun.chang@intel.com</a>><br>
---<br>
scripts/lib/recipetool/create.py | 9 +++++++++<br>
1 file changed, 9 insertions(+)<br>
<br>
diff --git a/scripts/lib/recipetool/create.py b/scripts/lib/recipetool/create.py<br>
index 8e63580..1015d02 100644<br>
--- a/scripts/lib/recipetool/create.py<br>
+++ b/scripts/lib/recipetool/create.py<br>
@@ -422,6 +422,7 @@ def create_recipe(args):<br>
source = args.source<br>
srcsubdir = ''<br>
srcrev = '${AUTOREV}'<br>
+ mirrors = args.mirrors<br>
<br>
if os.path.isfile(source):<br>
source = 'file://%s' % os.path.abspath(source)<br>
@@ -442,6 +443,13 @@ def create_recipe(args):<br>
tempsrc = tempfile.mkdtemp(prefix='recipetool-')<br>
srctree = tempsrc<br>
d = bb.data.createCopy(tinfoil.config_data)<br>
+ if not mirrors:<br>
+ # We do not need PREMIRRORS since we are almost certainly<br>
+ # fetching new source rather than something that has already<br>
+ # been fetched. Hence, we disable them by default.<br>
+ # However, we provide an option for users to enable it.<br>
+ d.setVar('PREMIRRORS', '')<br>
+ d.setVar('MIRRORS', '')<br>
if fetchuri.startswith('npm://'):<br>
# Check if npm is available<br>
npm_bindir = check_npm(tinfoil, args.devtool)<br>
@@ -1180,6 +1188,7 @@ def register_commands(subparsers):<br>
parser_create.add_argument('--keep-temp', action="store_true", help='Keep temporary directory (for debugging)')<br>
parser_create.add_argument('--fetch-dev', action="store_true", help='For npm, also fetch devDependencies')<br>
parser_create.add_argument('--devtool', action="store_true", help=argparse.SUPPRESS)<br>
+ parser_create.add_argument('--mirrors', action="store_true", help='Enable PREMIRRORS and MIRRORS for source tree fetching (disable by default).')<br>
# FIXME I really hate having to set parserecipes for this, but given we may need<br>
# to call into npm (and we don't know in advance if we will or not) and in order<br>
# to do so we need to know npm's recipe sysroot path, there's not much alternative<br>
<span class="hoenzb"><span style="color:#888888">--</span></span><span style="color:#888888"><br>
<span class="hoenzb">2.7.4</span><br>
<br>
<span class="hoenzb">--</span><br>
<span class="hoenzb">_______________________________________________</span><br>
<span class="hoenzb">Openembedded-core mailing list</span><br>
<span class="hoenzb"><a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.openembedded.org</a></span><br>
<span class="hoenzb"><a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a></span></span><o:p></o:p></p>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</body>
</html>