<div dir="ltr">On 27 July 2017 at 09:40, Chang Rebecca Swee Fun <span dir="ltr"><<a href="mailto:rebecca.swee.fun.chang@intel.com" target="_blank">rebecca.swee.fun.chang@intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">When recipetool create is run on a git URL and a revision specified<br>
that is not on master, and "branch=" isn't already in the URL, then<br>
we should get the correct branch and append the branch to the URL.<br>
<br>
If the revision was found on multiple branches, we will display error<br>
to inform user to provide a correct branch and exit.<br></blockquote><div><br></div><div>I think this is causing the selftests to fail:</div><br>2017-08-02 04:16:40,204 - oe-selftest - INFO - FAIL [12.984s]: test_recipetool_create_git (recipetool.RecipetoolTests)<br>2017-08-02 04:16:40,204 - oe-selftest - INFO - ----------------------------------------------------------------------<br>2017-08-02 04:16:40,205 - oe-selftest - INFO - Traceback (most recent call last):<br> File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/core/decorator/__init__.py", line 32, in wrapped_f<br> return func(*args, **kwargs)<br> File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/cases/recipetool.py", line 403, in test_recipetool_create_git<br> self._test_recipe_contents(recipefile, checkvars, inherits)<br> File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/cases/devtool.py", line 52, in _test_recipe_contents<br> self.assertEqual(value, needvalue, 'values for %s do not match' % var)<br>AssertionError: 'git://<a href="http://git.yoctoproject.org/libmatchbox;branch=master">git.yoctoproject.org/libmatchbox;branch=master</a>' != 'git://<a href="http://git.yoctoproject.org/libmatchbox">git.yoctoproject.org/libmatchbox</a>'<br>- git://<a href="http://git.yoctoproject.org/libmatchbox;branch=master">git.yoctoproject.org/libmatchbox;branch=master</a><br>? --------------<br>+ git://<a href="http://git.yoctoproject.org/libmatchbox">git.yoctoproject.org/libmatchbox</a> <br><br> : values for SRC_URI do not match </div><div class="gmail_quote"><br></div><div class="gmail_quote">Looks like recipetool is adding branch=master even though that is the default value so I'd suggest should be filtered out.</div><div class="gmail_quote"><br></div><div class="gmail_quote">Ross</div></div></div>