<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Aug 5, 2017 18:37, "Christopher Larson" <<a href="mailto:kergoth@gmail.com">kergoth@gmail.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="quoted-text">On Sat, Aug 5, 2017 at 3:07 PM, Joshua Watt <span dir="ltr"><<a href="mailto:jpewhacker@gmail.com" target="_blank">jpewhacker@gmail.com</a>></span> wrote:<br></div><div class="gmail_extra"><div class="gmail_quote"><div class="quoted-text"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If EXTERNALSRC points to a git submodule, the .git entry will not be a<br>
directory, but rather a file that points to the actual .git location (in<br>
the parent repository). If this still can't be resolved to a directory,<br>
ignore it and fall back to the non-git method for hashing.<br>
<br>
Signed-off-by: Joshua Watt <<a href="mailto:JPEWhacker@gmail.com" target="_blank">JPEWhacker@gmail.com</a>><br></blockquote><div><br></div></div><div>We shouldn’t be assuming knowledge of how .git works, IMO we should call out to git rev-parse to query the info we need.</div></div></div></div></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Ya that makes sense. I'll fix it.</div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><font color="#888888">-- <br><div class="m_2106994194228303955gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Christopher Larson<br>kergoth at gmail dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Senior Software Engineer, Mentor Graphics</div></div></div></div>
</font></div></div>
</blockquote></div><br></div></div></div>