<div dir="ltr">Breaks the no-x11 builder: <a href="https://autobuilder.yoctoproject.org/main/builders/nightly-no-x11/builds/543/steps/BuildImages/logs/stdio">https://autobuilder.yoctoproject.org/main/builders/nightly-no-x11/builds/543/steps/BuildImages/logs/stdio</a><div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 9 August 2017 at 19:11, Khem Raj <span dir="ltr"><<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 8/9/17 8:41 AM, Andre McCurdy wrote:<br>
> On Wed, Aug 9, 2017 at 7:19 AM, Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>> wrote:<br>
>> Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>><br>
><br>
> Any explanation? Was this previously non-deterministic? If so, how far<br>
> back does the problem go?<br>
<br>
</span>it isnt non-deterministic atleast not after RSS. However, we need this<br>
enabled when we have openGL/X11 enabled.<br>
<span class=""><br>
><br>
>> ---<br>
>> meta/recipes-graphics/cairo/<wbr>cairo.inc | 4 +++-<br>
>> 1 file changed, 3 insertions(+), 1 deletion(-)<br>
>><br>
>> diff --git a/meta/recipes-graphics/cairo/<wbr>cairo.inc b/meta/recipes-graphics/cairo/<wbr>cairo.inc<br>
>> index 8e1e2e1b88..fd376951bd 100644<br>
>> --- a/meta/recipes-graphics/cairo/<wbr>cairo.inc<br>
>> +++ b/meta/recipes-graphics/cairo/<wbr>cairo.inc<br>
>> @@ -22,7 +22,8 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxext"<br>
>> DEPENDS = "libpng fontconfig pixman glib-2.0 zlib"<br>
>><br>
>> PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_<wbr>FEATURES', 'x11', 'x11 xcb', '', d)} \<br>
>> - ${@bb.utils.filter('DISTRO_<wbr>FEATURES', 'directfb', d)}"<br>
>> + ${@bb.utils.filter('DISTRO_<wbr>FEATURES', 'directfb', d)} \<br>
>> + ${@bb.utils.filter('DISTRO_<wbr>FEATURES', 'opengl', d)}"<br>
>><br>
>> PACKAGECONFIG[x11] = "--with-x=yes -enable-xlib,--with-x=no --disable-xlib,${X11DEPENDS}"<br>
>> PACKAGECONFIG[xcb] = "--enable-xcb,--disable-xcb,<wbr>libxcb"<br>
>> @@ -30,6 +31,7 @@ PACKAGECONFIG[directfb] = "--enable-directfb=yes,,<wbr>directfb"<br>
>> PACKAGECONFIG[valgrind] = "--enable-valgrind=yes,--<wbr>disable-valgrind,valgrind"<br>
>> PACKAGECONFIG[egl] = "--enable-egl=yes,--disable-<wbr>egl,virtual/egl"<br>
>> PACKAGECONFIG[glesv2] = "--enable-glesv2,--disable-<wbr>glesv2,virtual/libgles2"<br>
>> +PACKAGECONFIG[opengl] = "--enable-gl,--disable-gl,<wbr>virtual/libgl"<br>
><br>
> Since the opengl distro feature can imply either OpenGL or OpenGL ES<br>
> support, it doesn't seem right to use it to select one over the other<br>
> (ie for recipes which support both, shouldn't the choice between<br>
> OpenGL or OpenGL ES be independent of the opengl distro feature) ?<br>
<br>
</span>at some point we differentiated between opengl and gles at distro level<br>
atleast for RDK, but I agree that marking opengl as a distro feature<br>
encompassing all OpenGL implementations is better. Although, in this<br>
particular case all openGL implementations can be enabled simultaneously<br>
so may be we can enable egl and gles too with same knob. Alternatively<br>
We can leave the packageconfig knob disabled which will make it same<br>
defaults effectively ( which is disabled)<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
>><br>
>> #check for TARGET_FPU=soft and inform configure of the result so it can disable some floating points<br>
>> require cairo-fpu.inc<br>
>> --<br>
>> 2.14.0<br>
>><br>
>> --<br>
>> ______________________________<wbr>_________________<br>
>> Openembedded-core mailing list<br>
>> <a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
>> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
<br>
<br>
</div></div><br>--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
<br></blockquote></div><br></div>