<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.m-6619940750513795977im
{mso-style-name:m_-6619940750513795977im;}
span.m-6619940750513795977hoenzb
{mso-style-name:m_-6619940750513795977hoenzb;}
span.hoenzb
{mso-style-name:hoenzb;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#943634;
font-weight:normal;
font-style:normal;
text-decoration:none none;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="SV" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634;mso-fareast-language:EN-US">Just in case you missed it (as you didn’t comment on my comment about it), there was a typo in the log message as well.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634;mso-fareast-language:EN-US">//Peter<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Bruce Ashfield [mailto:bruce.ashfield@gmail.com]
<br>
<b>Sent:</b> den 21 augusti 2017 17:14<br>
<b>To:</b> Peter Kjellerstedt <peter.kjellerstedt@axis.com><br>
<b>Cc:</b> richard.purdie@linuxfoundation.org; openembedded-core@lists.openembedded.org<br>
<b>Subject:</b> Re: [OE-core] [PATCH 8/9] kernel-yocto: ensure that only valid BSPs are built<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Mon, Aug 21, 2017 at 11:03 AM, Bruce Ashfield <<a href="mailto:bruce.ashfield@gmail.com" target="_blank">bruce.ashfield@gmail.com</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<div>
<p class="MsoNormal">On Mon, Aug 21, 2017 at 11:00 AM, Peter Kjellerstedt <<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">> -----Original Message-----<br>
> From: <a href="mailto:openembedded-core-bounces@lists.openembedded.org" target="_blank">
openembedded-core-bounces@lists.openembedded.org</a><br>
> [mailto:<a href="mailto:openembedded-core-bounces@lists.openembedded.org" target="_blank">openembedded-core-bounces@lists.openembedded.org</a>] On Behalf Of<br>
> Bruce Ashfield<br>
> Sent: den 21 augusti 2017 04:58<br>
> To: <a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a><br>
> Cc: <a href="mailto:openembedded-core@lists.openembedded.org" target="_blank">openembedded-core@lists.openembedded.org</a><br>
> Subject: [OE-core] [PATCH 8/9] kernel-yocto: ensure that only valid<br>
> BSPs are built<br>
><br>
> There was a bug in the search routines responsible for locating<br>
> BSP definitions which returned a valid match if only the ktype<br>
> matched.<br>
><br>
> This meant that someone looking for "qemux86foo" (which is an<br>
> invalid definition) would potentially end up building "qemuarm"<br>
> and be none the wiser (until it didn't boot).<br>
><br>
> With this fix to the tools search routine, and improved return<br>
> code testing, we will now stop the build and report and error to<br>
> the user.<br>
><br>
> [YOCTO: #11878]<br>
><br>
> Signed-off-by: Bruce Ashfield <<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>><br>
> ---<br>
> meta/classes/kernel-yocto.bbclass | 3 +++<br>
> meta/recipes-kernel/kern-tools/<a href="http://kern-tools-native_git.bb" target="_blank">kern-tools-native_git.bb</a> | 2 +-<br>
> 2 files changed, 4 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/meta/classes/<a href="http://kernel-yocto.bb">kernel-yocto.bb</a>class b/meta/classes/<a href="http://kernel-yocto.bb">kernel-yocto.bb</a>class<br>
> index 1ca0756c4959..3c6df92131bc 100644<br>
> --- a/meta/classes/<a href="http://kernel-yocto.bb">kernel-yocto.bb</a>class<br>
> +++ b/meta/classes/<a href="http://kernel-yocto.bb">kernel-yocto.bb</a>class<br>
> @@ -143,6 +143,9 @@ do_kernel_metadata() {<br>
><br>
> # expand kernel features into their full path equivalents<br>
> bsp_definition=$(spp ${includes} --find -DKMACHINE=${KMACHINE} -DKTYPE=${LINUX_KERNEL_TYPE})<br>
> + if [ $? -ne 0 ] || [ -z "${bsp_definition}" ]; then<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal">Use $bsp_definition instead of ${bsp_definition} since it is a<br>
shell variable and not a bitbake variable.<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal">I always use ${...}, so I'm going to stay consistent with what is already in<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">the file. <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal"><br>
Actually, after looking at the code in that bbclass, I see this<br>
used for a number of shell variables all over the place. This is<br>
actually bad, and you should rewrite the code to not use ${variable}<br>
for shell variables. The reason this is bad is because these<br>
variables unnecessarily end up in the sstate hash for these functions,<br>
and if someone actually happens to define a bitbake variable with the<br>
same name as one of those shell variables, the result will not be what<br>
is expected...<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Not something high on my priority list. It's been that way since the beginning.<o:p></o:p></p>
</div>
</div>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">.. but I will loop back and take care of the issues before M4 closes. Just a bit busy<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">pushing out the new kernels and a slew of bug fixes.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">This patch can be ignored (if needed) until I get back around to that.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Cheers,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Bruce<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Cheers,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Bruce<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal"><br>
> + bbfatal_log "Could not locate BSP definiton for ${KMACHINE}/${LINUX_KERNEL_TYPE}."<br>
<br>
Change "definiton" to "definition".<br>
<br>
<span class="m-6619940750513795977im">> + fi</span><br>
<span class="m-6619940750513795977im">> meta_dir=$(kgit --meta)</span><br>
<span class="m-6619940750513795977im">></span><br>
<span class="m-6619940750513795977im">> # run1: pull all the configuration fragments, no matter where they come from</span><br>
<span class="m-6619940750513795977im">> diff --git a/meta/recipes-kernel/kern-tools/<a href="http://kern-tools-native_git.bb" target="_blank">kern-tools-native_git.bb</a> b/meta/recipes-kernel/kern-tools/<a href="http://kern-tools-native_git.bb" target="_blank">kern-tools-native_git.bb</a></span><br>
<span class="m-6619940750513795977im">> index 2217a31076a2..4a78b897d34f 100644</span><br>
<span class="m-6619940750513795977im">> --- a/meta/recipes-kernel/kern-tools/<a href="http://kern-tools-native_git.bb" target="_blank">kern-tools-native_git.bb</a></span><br>
<span class="m-6619940750513795977im">> +++ b/meta/recipes-kernel/kern-tools/<a href="http://kern-tools-native_git.bb" target="_blank">kern-tools-native_git.bb</a></span><br>
<span class="m-6619940750513795977im">> @@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "<a href="file://git/tools/kgit;beginline=5;endline=9;md5=a6c2fa8aef1b%0b%3e%0b%3e %20DEPENDS%20=%20">file://git/tools/kgit;beginline=5;endline=9;md5=a6c2fa8aef1b<br>
><br>
> DEPENDS = </a>"git-native"</span><br>
<span class="m-6619940750513795977im">></span><br>
<span class="m-6619940750513795977im">> -SRCREV = "9cd2b626d652bec10c6bc75275b35bfee74d447c"</span><br>
<span class="m-6619940750513795977im">> +SRCREV = "0571411cc033c11df7827508dd786876ce2f8c83"</span><br>
<span class="m-6619940750513795977im">> PR = "r12"</span><br>
<span class="m-6619940750513795977im">> PV = "0.2+git${SRCPV}"</span><br>
<span class="m-6619940750513795977im">></span><br>
<span class="m-6619940750513795977im">> --</span><br>
<span class="m-6619940750513795977im">> 2.5.0</span><br>
<br>
<span class="m-6619940750513795977hoenzb"><span style="color:#888888">//Peter</span></span><o:p></o:p></p>
<div>
<div>
<p class="MsoNormal"><br>
--<br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><o:p></o:p></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><span style="color:#888888"><br>
<br clear="all">
<span class="hoenzb"><o:p></o:p></span></span></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal"><span class="hoenzb"><span style="color:#888888">-- </span><o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="color:#888888">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</span><o:p></o:p></p>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><br>
<br clear="all">
<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">-- <o:p></o:p></p>
<div>
<p class="MsoNormal">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"<o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
</body>
</html>