<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 21, 2017 at 11:16 AM, Peter Kjellerstedt <span dir="ltr"><<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="SV" link="blue" vlink="purple">
<div class="m_7766708495539309522WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634">Just in case you missed it (as you didn’t comment on my comment about it), there was a typo in the log message as well.</span></p></div></div></blockquote><div><br></div><div>Yup. Noticed that, it isn't the only typo ;)</div><div><br></div><div>This is a resend of a patch I sent a few weeks ago, so I'm not too worried if it sits or not.</div><div><br></div><div>Cheers,</div><div><br></div><div>Bruce</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="SV" link="blue" vlink="purple"><div class="m_7766708495539309522WordSection1"><p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634">//Peter<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Bruce Ashfield [mailto:<a href="mailto:bruce.ashfield@gmail.com" target="_blank">bruce.ashfield@gmail.<wbr>com</a>]
<br>
<b>Sent:</b> den 21 augusti 2017 17:14<br>
<b>To:</b> Peter Kjellerstedt <<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>><br>
<b>Cc:</b> <a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@<wbr>linuxfoundation.org</a>; <a href="mailto:openembedded-core@lists.openembedded.org" target="_blank">openembedded-core@lists.<wbr>openembedded.org</a><br>
<b>Subject:</b> Re: [OE-core] [PATCH 8/9] kernel-yocto: ensure that only valid BSPs are built<u></u><u></u></span></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Mon, Aug 21, 2017 at 11:03 AM, Bruce Ashfield <<a href="mailto:bruce.ashfield@gmail.com" target="_blank">bruce.ashfield@gmail.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<div>
<p class="MsoNormal">On Mon, Aug 21, 2017 at 11:00 AM, Peter Kjellerstedt <<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">> -----Original Message-----<br>
> From: <a href="mailto:openembedded-core-bounces@lists.openembedded.org" target="_blank">
openembedded-core-bounces@<wbr>lists.openembedded.org</a><br>
> [mailto:<a href="mailto:openembedded-core-bounces@lists.openembedded.org" target="_blank">openembedded-core-<wbr>bounces@lists.openembedded.org</a><wbr>] On Behalf Of<br>
> Bruce Ashfield<br>
> Sent: den 21 augusti 2017 04:58<br>
> To: <a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@<wbr>linuxfoundation.org</a><br>
> Cc: <a href="mailto:openembedded-core@lists.openembedded.org" target="_blank">openembedded-core@lists.<wbr>openembedded.org</a><br>
> Subject: [OE-core] [PATCH 8/9] kernel-yocto: ensure that only valid<br>
> BSPs are built<br>
><br>
> There was a bug in the search routines responsible for locating<br>
> BSP definitions which returned a valid match if only the ktype<br>
> matched.<br>
><br>
> This meant that someone looking for "qemux86foo" (which is an<br>
> invalid definition) would potentially end up building "qemuarm"<br>
> and be none the wiser (until it didn't boot).<br>
><br>
> With this fix to the tools search routine, and improved return<br>
> code testing, we will now stop the build and report and error to<br>
> the user.<br>
><br>
> [YOCTO: #11878]<br>
><br>
> Signed-off-by: Bruce Ashfield <<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>><br>
> ---<br>
> meta/classes/kernel-yocto.<wbr>bbclass | 3 +++<br>
> meta/recipes-kernel/kern-<wbr>tools/<a href="http://kern-tools-native_git.bb" target="_blank">kern-tools-native_git.bb</a> | 2 +-<br>
> 2 files changed, 4 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/meta/classes/<a href="http://kernel-yocto.bb" target="_blank">kernel-yocto.bb</a><wbr>class b/meta/classes/<a href="http://kernel-yocto.bb" target="_blank">kernel-yocto.bb</a><wbr>class<br>
> index 1ca0756c4959..3c6df92131bc 100644<br>
> --- a/meta/classes/<a href="http://kernel-yocto.bb" target="_blank">kernel-yocto.bb</a><wbr>class<br>
> +++ b/meta/classes/<a href="http://kernel-yocto.bb" target="_blank">kernel-yocto.bb</a><wbr>class<br>
> @@ -143,6 +143,9 @@ do_kernel_metadata() {<br>
><br>
> # expand kernel features into their full path equivalents<br>
> bsp_definition=$(spp ${includes} --find -DKMACHINE=${KMACHINE} -DKTYPE=${LINUX_KERNEL_TYPE})<br>
> + if [ $? -ne 0 ] || [ -z "${bsp_definition}" ]; then<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal">Use $bsp_definition instead of ${bsp_definition} since it is a<br>
shell variable and not a bitbake variable.<u></u><u></u></p>
</blockquote>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal">I always use ${...}, so I'm going to stay consistent with what is already in<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">the file. <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal"><br>
Actually, after looking at the code in that bbclass, I see this<br>
used for a number of shell variables all over the place. This is<br>
actually bad, and you should rewrite the code to not use ${variable}<br>
for shell variables. The reason this is bad is because these<br>
variables unnecessarily end up in the sstate hash for these functions,<br>
and if someone actually happens to define a bitbake variable with the<br>
same name as one of those shell variables, the result will not be what<br>
is expected...<u></u><u></u></p>
</blockquote>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Not something high on my priority list. It's been that way since the beginning.<u></u><u></u></p>
</div>
</div>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">.. but I will loop back and take care of the issues before M4 closes. Just a bit busy<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">pushing out the new kernels and a slew of bug fixes.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">This patch can be ignored (if needed) until I get back around to that.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Cheers,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Bruce<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Cheers,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Bruce<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal"><br>
> + bbfatal_log "Could not locate BSP definiton for ${KMACHINE}/${LINUX_KERNEL_<wbr>TYPE}."<br>
<br>
Change "definiton" to "definition".<br>
<br>
<span class="m_7766708495539309522m-6619940750513795977im">> + fi</span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> meta_dir=$(kgit --meta)</span><br>
<span class="m_7766708495539309522m-6619940750513795977im">></span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> # run1: pull all the configuration fragments, no matter where they come from</span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> diff --git a/meta/recipes-kernel/kern-<wbr>tools/<a href="http://kern-tools-native_git.bb" target="_blank">kern-tools-native_git.bb</a> b/meta/recipes-kernel/kern-<wbr>tools/<a href="http://kern-tools-native_git.bb" target="_blank">kern-tools-native_git.bb</a></span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> index 2217a31076a2..4a78b897d34f 100644</span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> --- a/meta/recipes-kernel/kern-<wbr>tools/<a href="http://kern-tools-native_git.bb" target="_blank">kern-tools-native_git.bb</a></span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> +++ b/meta/recipes-kernel/kern-<wbr>tools/<a href="http://kern-tools-native_git.bb" target="_blank">kern-tools-native_git.bb</a></span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> @@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "<a>file://git/tools/kgit;<wbr>beginline=5;endline=9;md5=<wbr>a6c2fa8aef1b<br>
><br>
> DEPENDS = </a>"git-native"</span><br>
<span class="m_7766708495539309522m-6619940750513795977im">></span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> -SRCREV = "<wbr>9cd2b626d652bec10c6bc75275b35b<wbr>fee74d447c"</span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> +SRCREV = "<wbr>0571411cc033c11df7827508dd7868<wbr>76ce2f8c83"</span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> PR = "r12"</span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> PV = "0.2+git${SRCPV}"</span><br>
<span class="m_7766708495539309522m-6619940750513795977im">></span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> --</span><br>
<span class="m_7766708495539309522m-6619940750513795977im">> 2.5.0</span><br>
<br>
<span class="m_7766708495539309522m-6619940750513795977hoenzb"><span style="color:#888888">//Peter</span></span><u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"><br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><u></u><u></u></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><span style="color:#888888"><br>
<br clear="all">
<span class="m_7766708495539309522hoenzb"><u></u><u></u></span></span></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal"><span class="m_7766708495539309522hoenzb"><span style="color:#888888">-- </span><u></u><u></u></span></p>
<div>
<p class="MsoNormal"><span style="color:#888888">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</span><u></u><u></u></p>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><br>
<br clear="all">
<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal">-- <u></u><u></u></p>
<div>
<p class="MsoNormal">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"<u></u><u></u></p>
</div>
</div>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</div>
</div></div>