<div dir="ltr">Hi, Andre:<div><br></div><div>Arha, I did not know that when I was submitting the patch, may I know why it's rejected at that moment? Since even with the <span style="color:rgb(33,33,33);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont;font-size:13.3333px">alternative fixes, the developers still could introduce duplicated whitespaces in their BSP layers if they do not know the rules, since it's quite common in recipes to assign variables with duplicated whitespcaces.</span></div><div><span style="color:rgb(33,33,33);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont;font-size:13.3333px"><br></span></div><div><span style="color:rgb(33,33,33);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont;font-size:13.3333px">BTW: i just checked, it's been merged to master already.</span></div><div><span style="color:rgb(33,33,33);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont;font-size:13.3333px"><br></span></div><div><span style="color:rgb(33,33,33);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont;font-size:13.3333px">//Ming Liu</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">2017-08-23 4:19 GMT+02:00 Andre McCurdy <span dir="ltr"><<a href="mailto:armccurdy@gmail.com" target="_blank">armccurdy@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Mon, Aug 21, 2017 at 4:43 AM, <<a href="mailto:liu.ming50@gmail.com">liu.ming50@gmail.com</a>> wrote:<br>
> From: Ming Liu <<a href="mailto:peter.x.liu@external.atlascopco.com">peter.x.liu@external.<wbr>atlascopco.com</a>><br>
><br>
> To give a example:<br>
> Before the change, in our build console, TUNE_FEATURES looks like:<br>
> ...<br>
> TUNE_FEATURES = "arm armv7a vfp neon cortexa8"<br>
> ...<br>
><br>
> After the change:<br>
> ...<br>
> TUNE_FEATURES = "arm armv7a vfp neon cortexa8"<br>
> ...<br>
><br>
> Signed-off-by: Ming Liu <<a href="mailto:peter.x.liu@external.atlascopco.com">peter.x.liu@external.<wbr>atlascopco.com</a>><br>
> ---<br>
> meta/classes/base.bbclass | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass<br>
> index 8c86977..07734ac 100644<br>
> --- a/meta/classes/base.bbclass<br>
> +++ b/meta/classes/base.bbclass<br>
> @@ -206,7 +206,7 @@ def buildcfg_vars(d):<br>
> for var in statusvars:<br>
> value = d.getVar(var)<br>
> if value is not None:<br>
> - yield '%-17s = "%s"' % (var, value)<br>
> + yield '%-17s = "%s"' % (var, " ".join(value.split()))<br>
<br>
</div></div>This fix has been rejected once already:<br>
<br>
<a href="http://lists.openembedded.org/pipermail/openembedded-core/2016-November/129358.html" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>pipermail/openembedded-core/<wbr>2016-November/129358.html</a><br>
<br>
The preferred alternative was to remove all duplicated whitespace in<br>
the BUILDCFG_VARS variables:<br>
<br>
<a href="http://git.openembedded.org/openembedded-core/commit/?id=5610c6397ee098dd998b7417b343494de77179f9" rel="noreferrer" target="_blank">http://git.openembedded.org/<wbr>openembedded-core/commit/?id=<wbr>5610c6397ee098dd998b7417b34349<wbr>4de77179f9</a><br>
<a href="http://git.openembedded.org/openembedded-core/commit/?id=971e43270173afb08f21ffac16a4157f7e611b81" rel="noreferrer" target="_blank">http://git.openembedded.org/<wbr>openembedded-core/commit/?id=<wbr>971e43270173afb08f21ffac16a415<wbr>7f7e611b81</a><br>
<div class="HOEnZb"><div class="h5"><br>
> def buildcfg_neededvars(d):<br>
> needed_vars = oe.data.typed_value("BUILDCFG_<wbr>NEEDEDVARS", d)<br>
> --<br>
> 2.7.4<br>
><br>
</div></div><span class="HOEnZb"><font color="#888888">> --<br>
> ______________________________<wbr>_________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></blockquote></div><br></div>