<div dir="ltr">On 31 August 2017 at 00:54, Paul Eggleton <span dir="ltr"><<a href="mailto:paul.eggleton@linux.intel.com" target="_blank">paul.eggleton@linux.intel.com</a><wbr>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: paul <<a href="mailto:paul@peggleto-mobl.ger.corp.intel.com" target="_blank">paul@peggleto-mobl.ger.corp.i<wbr>ntel.com</a>><br>
<br>
If <a href="http://user.name" rel="noreferrer" target="_blank">user.name</a> or user.email haven't been set then git rebase can't really<br>
work properly. Check that the user has set these and error out if not.<br>
(Elsewhere we are relying on OE's git patch functionality which forces<br>
a dummy OE value - that's OK there as it's completely under OE's control<br>
and therefore it's OK for a dummy OE user to be the committer, but here<br>
the rebase may require intervention so it's reasonable to have the<br>
user's actual name and email on the operation.)<br></blockquote><div><br></div><div>The irony is strong in this one.</div><div><br></div><div>(I'll fixup when merging)</div><div><br></div><div>Ross </div></div></div></div>