<div dir="ltr"><div>Was this tested with the version in pyro? The patch fails to apply:</div><div><br></div><div><br></div><div><a href="http://errors.yoctoproject.org/Errors/Build/46432/">http://errors.yoctoproject.org/Errors/Build/46432/</a><br></div><div><br></div><div>NOTE: Applying patch 'autotools.patch' (oe-core/meta/recipes-core/expat/expat/autotools.patch)</div><div>NOTE: Applying patch 'no_getrandom.patch' (oe-core/meta/recipes-core/expat/expat/no_getrandom.patch)</div><div>ERROR: Command Error: 'quilt --quiltrc TOPDIR/BUILD/work/x86_64-linux/expat-native/2.2.0-r0/recipe-sysroot-native/etc/quiltrc push' exited with 0 Output:</div><div>Applying patch no_getrandom.patch</div><div>patching file <a href="http://configure.ac">configure.ac</a></div><div>Hunk #1 FAILED at 151.</div><div>1 out of 1 hunk FAILED -- rejects in file <a href="http://configure.ac">configure.ac</a></div><div>Patch no_getrandom.patch does not apply (enforce with -f)</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 11, 2017 at 11:16 PM, <span dir="ltr"><<a href="mailto:git@git.openembedded.org" target="_blank">git@git.openembedded.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is an automated email from the git hooks/post-receive script.<br>
<br>
rpurdie pushed a commit to branch pyro<br>
in repository openembedded-core.<br>
<br>
commit 450942db7f4638eba7ec262901fe1d<wbr>7e1b1f6070<br>
Author: Richard Purdie <<a href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@<wbr>linuxfoundation.org</a>><br>
AuthorDate: Mon Aug 14 11:06:33 2017 +0100<br>
<br>
expat: Don't use getrandom() in the -native case<br>
<br>
getrandom() is only available in glibc 2.25+ and uninative may relocate<br>
binaries onto systems that don't have this function. For now, force<br>
the code to the older codepath until we can come up with a better solution<br>
for this kind of issue.<br>
<br>
(From OE-Core rev: da9ac8092497c3f2c246d3534f47e4<wbr>2cb2d9e4e8)<br>
<br>
Signed-off-by: Richard Purdie <<a href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@<wbr>linuxfoundation.org</a>><br>
---<br>
meta/recipes-core/expat/expat.<wbr>inc | 3 +++<br>
meta/recipes-core/expat/expat/<wbr>no_getrandom.patch | 23 +++++++++++++++++++++++<br>
2 files changed, 26 insertions(+)<br>
<br>
diff --git a/meta/recipes-core/expat/<wbr>expat.inc b/meta/recipes-core/expat/<wbr>expat.inc<br>
index 9fa0ca2..8bfd0bf 100644<br>
--- a/meta/recipes-core/expat/<wbr>expat.inc<br>
+++ b/meta/recipes-core/expat/<wbr>expat.inc<br>
@@ -7,6 +7,9 @@ LICENSE = "MIT"<br>
SRC_URI = "${SOURCEFORGE_MIRROR}/expat/<wbr>expat-${PV}.tar.bz2 \<br>
file://autotools.patch \<br>
"<br>
+<br>
+SRC_URI_append_class-native = " file://no_getrandom.patch"<br>
+<br>
inherit autotools lib_package<br>
<br>
# This package uses an archive format known to have issue with some<br>
diff --git a/meta/recipes-core/expat/<wbr>expat/no_getrandom.patch b/meta/recipes-core/expat/<wbr>expat/no_getrandom.patch<br>
new file mode 100644<br>
index 0000000..d64f1bf<br>
--- /dev/null<br>
+++ b/meta/recipes-core/expat/<wbr>expat/no_getrandom.patch<br>
@@ -0,0 +1,23 @@<br>
+The native version of expat may be used on older systems which dont have glibc 2.25<br>
+and hence don't have getrandom() thanks to uninative. Disable the libc call and<br>
+use the syscall instead to avoid a compatibility issue until we have 2.25 everywhere<br>
+we support with uninative.<br>
+<br>
+RP<br>
+2017/8/14<br>
+<br>
+Upstream-Status: Inappropriate<br>
+<br>
+Index: expat-2.2.3/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
+=============================<wbr>==============================<wbr>========<br>
+--- expat-2.2.3.orig/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
++++ expat-2.2.3/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
+@@ -151,7 +151,7 @@ AC_LINK_IFELSE([AC_LANG_<wbr>SOURCE([<br>
+ #include <stdlib.h> /* for NULL */<br>
+ #include <sys/random.h><br>
+ int main() {<br>
+- return getrandom(NULL, 0U, 0U);<br>
++ return getrandomBREAKME(NULL, 0U, 0U);<br>
+ }<br>
+ ])], [<br>
+ AC_DEFINE([HAVE_GETRANDOM], [1],<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
To stop receiving notification emails like this one, please contact<br>
the administrator of this repository.<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-commits mailing list<br>
<a href="mailto:Openembedded-commits@lists.openembedded.org">Openembedded-commits@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-commits" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>commits</a><br>
</font></span></blockquote></div><br></div>