<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>On Wed, 2017-09-27 at 20:11 +0100, Burton, Ross wrote:</div><blockquote type="cite"><div dir="ltr">libsdl2 doesn't build for me:<div><br></div><div><div>| /bin/bash ../SDL2-2.0.5/build-scripts/mkinstalldirs build</div><div>| make: *** No rule to make target '/usr/share/wayland/wayland.xml', needed by 'gen/wayland-client-protocol.h'. Stop.</div></div><div><br></div><div>Do you have wayland-protocols on your build host?</div><div><br></div></div></blockquote><div><br></div><div>I found a machine without wayland installed and succeed to reproduce.</div><div>I found the issue and fix it.</div><div><br></div><div>libsdl2 build now and I am building with X enabled to check it is not broken too.</div><div><br></div><blockquote type="cite"><div dir="ltr"><div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 27 September 2017 at 14:14, Fabien Lahoudere <span dir="ltr"><<a href="mailto:fabien.lahoudere@collabora.co.uk" target="_blank">fabien.lahoudere@collabora.co.uk</a>></span> wrote:<br><blockquote type="cite">This patch also remove workaround to find wayland-protocols:<br>
<br>
WAYLAND_PROTOCOLS_SYSROOT_DIR=${RECIPE_SYSROOT}<br>
<br>
in:<br>
<br>
- gtk+3<br>
- libsdl2<br>
- xserver-xorg<br>
- gstreamer1.0-plugins-bad<br>
- weston-2.0.0<br>
<br>
Signed-off-by: Fabien Lahoudere <<a href="mailto:fabien.lahoudere@collabora.co.uk">fabien.lahoudere@collabora.<wbr>co.uk</a>><br>
---<br>
meta/recipes-gnome/gtk+/gtk+3.inc | 1 -<br>
meta/recipes-graphics/libsdl2/<a href="http://libsdl2_2.0.5.bb" rel="noreferrer" target="_blank"><wbr>libsdl2_2.0.5.bb</a> | 2 +-<br>
.../usesysrootprefixforpkgdatadirvariable.patch | 27 ++++++++++++++++++++++<br>
.../wayland/<a href="http://wayland-protocols_1.10.bb" rel="noreferrer" target="_blank">wayland-protocols_<wbr>1.10.bb</a> | 1 +<br>
meta/recipes-graphics/wayland/<a href="http://weston_2.0.0.bb" rel="noreferrer" target="_blank"><wbr>weston_2.0.0.bb</a> | 1 -<br>
.../recipes-graphics/xorg-xserver/xserver-xorg.inc | 1 -<br>
.../gstreamer/<a href="http://gstreamer1.0-plugins-bad_1.12.2.bb" rel="noreferrer" target="_blank">gstreamer1.0-<wbr>plugins-bad_1.12.2.bb</a> | 1 -<br>
7 files changed, 29 insertions(+), 5 deletions(-)<br>
create mode 100644 meta/recipes-graphics/wayland/wayland-protocols/usesysrootprefixforpkgdatadirvariable.patch<br>
<br>
diff --git a/meta/recipes-gnome/gtk+/gtk+3.inc b/meta/recipes-gnome/gtk+/gtk+3.inc<br>
index 0a357db049..420ead2ca2 100644<br>
--- a/meta/recipes-gnome/gtk+/gtk+3.inc<br>
+++ b/meta/recipes-gnome/gtk+/gtk+3.inc<br>
@@ -35,7 +35,6 @@ EXTRA_OECONF += " \<br>
--enable-modules \<br>
--disable-cups \<br>
--disable-colord \<br>
- WAYLAND_PROTOCOLS_SYSROOT_DIR=${RECIPE_SYSROOT} \<br>
${@bb.utils.contains("DISTRO_FEATURES", "x11", "", "--disable-gtk-doc", d)} \<br>
"<br>
<br>
diff --git a/meta/recipes-graphics/libsdl2/<a href="http://libsdl2_2.0.5.bb" rel="noreferrer" target="_blank">libsdl2_2.0.5.bb</a> b/meta/recipes-graphics/libsdl2/<a href="http://libsdl2_2.0.5.bb" rel="noreferrer" target="_blank">libsdl2_2.0.5.bb</a><br>
index 12d3aaf6f0..6bfa13200b 100644<br>
--- a/meta/recipes-graphics/libsdl2/<a href="http://libsdl2_2.0.5.bb" rel="noreferrer" target="_blank">libsdl2_2.0.5.bb</a><br>
+++ b/meta/recipes-graphics/libsdl2/<a href="http://libsdl2_2.0.5.bb" rel="noreferrer" target="_blank">libsdl2_2.0.5.bb</a><br>
@@ -35,7 +35,7 @@ EXTRA_OECONF = "--disable-oss --disable-esd --disable-arts \<br>
--enable-pthreads \<br>
--enable-sdl-dlopen \<br>
--disable-rpath \<br>
- WAYLAND_PROTOCOLS_SYSROOT_DIR=${RECIPE_SYSROOT}"<br>
+ "<br>
<br>
# opengl packageconfig factored out to make it easy for distros<br>
# and BSP layers to pick either (desktop) opengl, gles2, or no GL<br>
diff --git a/meta/recipes-graphics/wayland/wayland-protocols/usesysrootprefixforpkgdatadirvariable.patch b/meta/recipes-graphics/wayland/wayland-protocols/usesysrootprefixforpkgdatadirvariable.patch<br>
new file mode 100644<br>
index 0000000000..0922a4d2c2<br>
--- /dev/null<br>
+++ b/meta/recipes-graphics/wayland/wayland-protocols/usesysrootprefixforpkgdatadirvariable.patch<br>
@@ -0,0 +1,27 @@<br>
+From 875130ee3cbcf62266901ef4b91b9a0fb6adad43 Mon Sep 17 00:00:00 2001<br>
+From: Tomek Bury <<a href="mailto:tomek.bury@broadcom.com">tomek.bury@broadcom.com</a>><br>
+Date: Fri, 4 Aug 2017 16:16:38 +0100<br>
+Subject: Use sysroot prefix for pkgdatadir variable<br>
+<br>
+The pc_sysroot is automatically added to cflags and libs but not<br>
+to 'pkg-config --variable'<br>
+<br>
+Upstream-Status: Backport [<a href="https://cgit.freedesktop.org/wayland/wayland-protocols/commit/?id=875130ee3cbcf62266901ef4b91b9a0fb6adad43" rel="noreferrer" target="_blank">https://cgit.freedesktop.org/<wbr>wayland/wayland-protocols/<wbr>commit/?id=<wbr>875130ee3cbcf62266901ef4b91b9a<wbr>0fb6adad43</a>]<br>
+<br>
+Reviewed-by: Daniel Stone <<a href="mailto:daniels@collabora.com">daniels@collabora.com</a>><br>
+<br>
+diff --git a/<a href="http://wayland-protocols.pc.in" rel="noreferrer" target="_blank">wayland-protocols.pc.in</a> b/<a href="http://wayland-protocols.pc.in" rel="noreferrer" target="_blank">wayland-protocols.pc.in</a><br>
+index a26744c..379be06 100644<br>
+--- a/<a href="http://wayland-protocols.pc.in" rel="noreferrer" target="_blank">wayland-protocols.pc.in</a><br>
++++ b/<a href="http://wayland-protocols.pc.in" rel="noreferrer" target="_blank">wayland-protocols.pc.in</a><br>
+@@ -1,6 +1,6 @@<br>
+ prefix=@prefix@<br>
+ datarootdir=@datarootdir@<br>
+-pkgdatadir=@datadir@/@PACKAGE@<br>
++pkgdatadir=${pc_sysrootdir}@datadir@/@PACKAGE@<br>
+<br>
+ Name: Wayland Protocols<br>
+ Description: Wayland protocol files<br>
+--<br>
+cgit v0.10.2<br>
+<br>
diff --git a/meta/recipes-graphics/wayland/<a href="http://wayland-protocols_1.10.bb" rel="noreferrer" target="_blank">wayland-protocols_1.<wbr>10.bb</a> b/meta/recipes-graphics/wayland/<a href="http://wayland-protocols_1.10.bb" rel="noreferrer" target="_blank">wayland-protocols_1.<wbr>10.bb</a><br>
index 4f9e9f32bf..1ff12c607b 100644<br>
--- a/meta/recipes-graphics/wayland/<a href="http://wayland-protocols_1.10.bb" rel="noreferrer" target="_blank">wayland-protocols_1.<wbr>10.bb</a><br>
+++ b/meta/recipes-graphics/wayland/<a href="http://wayland-protocols_1.10.bb" rel="noreferrer" target="_blank">wayland-protocols_1.<wbr>10.bb</a><br>
@@ -10,6 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=c7b12b6702da38ca028ace54aae3d484 \<br>
file://stable/presentation-time/presentation-time.xml;endline=26;md5=4646cd7d9edc9fa55db941f2d3a7dc53"<br>
<br>
SRC_URI = "<a href="https://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz" rel="noreferrer" target="_blank">https://wayland.freedesktop.<wbr>org/releases/${BPN}-${PV}.tar.<wbr>xz</a> \<br>
+ file://usesysrootprefixforpkgdatadirvariable.patch \<br>
"<br>
SRC_URI[md5sum] = "84a7846c2b6a6a3e265fc9be36453e60"<br>
SRC_URI[sha256sum] = "5719c51d7354864983171c5083e93a72ac99229e2b460c4bb10513de08839c0a"<br>
diff --git a/meta/recipes-graphics/wayland/<a href="http://weston_2.0.0.bb" rel="noreferrer" target="_blank">weston_2.0.0.bb</a> b/meta/recipes-graphics/wayland/<a href="http://weston_2.0.0.bb" rel="noreferrer" target="_blank">weston_2.0.0.bb</a><br>
index 54b07bd6b9..8160f5556d 100644<br>
--- a/meta/recipes-graphics/wayland/<a href="http://weston_2.0.0.bb" rel="noreferrer" target="_blank">weston_2.0.0.bb</a><br>
+++ b/meta/recipes-graphics/wayland/<a href="http://weston_2.0.0.bb" rel="noreferrer" target="_blank">weston_2.0.0.bb</a><br>
@@ -25,7 +25,6 @@ DEPENDS += "wayland wayland-protocols libinput virtual/egl pango wayland-native"<br>
<br>
EXTRA_OECONF = "--enable-setuid-install \<br>
--disable-rdp-compositor \<br>
- WAYLAND_PROTOCOLS_SYSROOT_DIR=${RECIPE_SYSROOT} \<br>
"<br>
EXTRA_OECONF_append_qemux86 = "\<br>
WESTON_NATIVE_BACKEND=fbdev-backend.so \<br>
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc<br>
index 863d80ce43..e8025de55f 100644<br>
--- a/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc<br>
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc<br>
@@ -117,7 +117,6 @@ EXTRA_OECONF += "--with-fop=no \<br>
--sysconfdir=/etc/X11 \<br>
--localstatedir=/var \<br>
--with-xkb-output=/var/lib/xkb \<br>
- WAYLAND_PROTOCOLS_SYSROOT_DIR=${RECIPE_SYSROOT} \<br>
"<br>
<br>
OPENGL_PKGCONFIGS = "dri glx glamor dri3 xshmfence"<br>
diff --git a/meta/recipes-multimedia/gstreamer/<a href="http://gstreamer1.0-plugins-bad_1.12.2.bb" rel="noreferrer" target="_blank">gstreamer1.0-<wbr>plugins-bad_1.12.2.bb</a> b/meta/recipes-multimedia/gstreamer/<a href="http://gstreamer1.0-plugins-bad_1.12.2.bb" rel="noreferrer" target="_blank">gstreamer1.0-<wbr>plugins-bad_1.12.2.bb</a><br>
index 8321da0c27..a83a5bab21 100644<br>
--- a/meta/recipes-multimedia/gstreamer/<a href="http://gstreamer1.0-plugins-bad_1.12.2.bb" rel="noreferrer" target="_blank">gstreamer1.0-<wbr>plugins-bad_1.12.2.bb</a><br>
+++ b/meta/recipes-multimedia/gstreamer/<a href="http://gstreamer1.0-plugins-bad_1.12.2.bb" rel="noreferrer" target="_blank">gstreamer1.0-<wbr>plugins-bad_1.12.2.bb</a><br>
@@ -22,5 +22,4 @@ SRC_URI[sha256sum] = "9c2c7edde4f59d74eb414e0701c55131f562e5c605a3ce9b091754f106<br>
<br>
S = "${WORKDIR}/gst-plugins-bad-${PV}"<br>
<br>
-EXTRA_OECONF += "WAYLAND_PROTOCOLS_SYSROOT_DIR=${RECIPE_SYSROOT}"<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.11.0<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span><br></blockquote></div><br></div>
</blockquote></body></html>