<div dir="ltr">On 27 September 2017 at 21:43, <span dir="ltr"><<a href="mailto:libertad.cruz@intel.com" target="_blank">libertad.cruz@intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">From: libertad <<a href="mailto:libertad.cruz@intel.com">libertad.cruz@intel.com</a>><br>
<br>
Adds dpkg testcases for testing basic operation functionality for the dpkg packgage manager.Adds new assert function to verify expected results given by the dpkg package</div></div></blockquote><div><br></div><div>Basic functionality of a package manager is list packages, add packages, remove packages.</div><div><br></div><div>Whereas the bulk of this this test verifies that four combinations of --help or --version work, which isn't actually testing anything beyond "is dpkg installed".</div><div><br></div><div>Can we just remove all of them? I don't see the point in cluttering testopia and the source with test cases that don't actually test anything.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">
@OETestID(1812)<br>
def test_dpkg_status(self):<br>
- self.dpkg('dpkg -s dpkg')<br>
+ self.dpkg('dpkg -s dpkg',"Package: dpkg")<br></div></div></blockquote><div><br></div><div>I'd suggest also verifying the status. It should be 'Status: install ok installed'.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">
@OETestID(1814)<br>
def test_dpkg_list(self):<br>
- self.dpkg('dpkg -l')<br>
+ self.dpkg('dpkg -l',"Desired=Unknown/Install/<wbr>Remove/Purge/Hold")<br></div></div></blockquote><div><br></div><div>If dpkg -l crashes immediately after outputting the header (say, the database parser was broken) then this test would pass.</div><div><br></div><div>Either search it for some essential packages ("ii dpkg" would be a good start), or remove the test.</div><div><br></div><div>Ross </div></div></div></div>