<div dir="ltr">On 3 October 2017 at 19:17, Peter Kjellerstedt <span dir="ltr"><<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">> + # Take shared lock since we're only reading, not writing<br>
> lf = bb.utils.lockfile(bb.data.<wbr>expand("${PACKAGELOCK}", d))<br>
<br>
Here, however, it is not changed, even though a comment is added to<br>
say that it is. Was this intentional, or just an oversight?<br>
<br>> + # Take shared lock since we're only reading, not writing<br>
> lf = bb.utils.lockfile(bb.data.<wbr>expand("${PACKAGELOCK}", d))<br>
<br>
Here again a comment is added, but the code is not changed to match.</blockquote><div><br></div><div>I'm no expert on this piece of code but that definitely looks like an oversight.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Also, what is the ${PACKAGELOCK} lock file actually protecting? With<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
the exception of the two questionable cases above, I cannot see that<br>
the lock is taken privately anywhere else. And since it looks as the<br>
code in package_do_shlibs() and package_do_pkgconfig() is not what<br>
needs protection (based on the added comments above), what is?<br></blockquote><div><br></div><div>Good point. The sstate locks are also shared.</div><div><br></div><div>Richard was involved in all of these changes so lets wait for him to return from his holiday...</div><div><br></div><div>Ross</div><div> </div></div></div></div>