<div dir="ltr">Ping, hi, maintainers, this issue is blocking our release, please kindly help me review it and let me know if you think it's not correct.<div><br></div><div>//Ming Liu</div></div><div class="gmail_extra"><br><div class="gmail_quote">2017-09-26 14:31 GMT+02:00 <span dir="ltr"><<a href="mailto:liu.ming50@gmail.com" target="_blank">liu.ming50@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Ming Liu <<a href="mailto:liu.ming50@gmail.com">liu.ming50@gmail.com</a>><br>
<br>
The licenses of EXTRA_IMAGEDEPENDS recipes are being referenced in<br>
image postcommand write_deploy_manifest, but a dependency is missing<br>
between do_image and do_populate_lic of EXTRA_IMAGEDEPENDS recipes,<br>
this leads some license files not present when write_deploy_manifest<br>
runs, hence will cause build errors.<br>
<br>
Fixed by letting do_image depend on do_populate_lic of<br>
EXTRA_IMAGEDEPENDS recipes.<br>
<br>
Signed-off-by: Ming Liu <<a href="mailto:liu.ming50@gmail.com">liu.ming50@gmail.com</a>><br>
---<br>
meta/classes/image.bbclass | 14 +++++++++-----<br>
1 file changed, 9 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass<br>
index 0d14250..6bc4f04 100644<br>
--- a/meta/classes/image.bbclass<br>
+++ b/meta/classes/image.bbclass<br>
@@ -145,14 +145,18 @@ IMAGE_TYPE_wic = "image_types_wic"<br>
inherit ${IMAGE_TYPE_wic}<br>
<br>
python () {<br>
+ def extraimage_getdepends(task):<br>
+ deps = ""<br>
+ for dep in (d.getVar('EXTRA_IMAGEDEPENDS'<wbr>) or "").split():<br>
+ deps += " %s:%s" % (dep, task)<br>
+ return deps<br>
+<br>
+ d.appendVarFlag('do_image', 'depends', extraimage_getdepends('do_<wbr>populate_lic'))<br>
+ d.appendVarFlag('do_image_<wbr>complete', 'depends', extraimage_getdepends('do_<wbr>populate_sysroot'))<br>
+<br>
deps = " " + imagetypes_getdepends(d)<br>
d.appendVarFlag('do_rootfs', 'depends', deps)<br>
<br>
- deps = ""<br>
- for dep in (d.getVar('EXTRA_IMAGEDEPENDS'<wbr>) or "").split():<br>
- deps += " %s:do_populate_sysroot" % dep<br>
- d.appendVarFlag('do_image_<wbr>complete', 'depends', deps)<br>
-<br>
#process IMAGE_FEATURES, we must do this before runtime_mapping_rename<br>
#Check for replaces image features<br>
features = set(oe.data.typed_value('<wbr>IMAGE_FEATURES', d))<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
</font></span></blockquote></div><br></div>