<div dir="ltr"><div><div><div>Hi,<br><br></div>It is an issue with the fitImage generation when UBOOT_SIGN_ENABLE is enabled, <span id="gmail-result_box" class="gmail-short_text" tabindex="-1" lang="en"><span>unrelated to extlinux.<br></span></span></div><div><span id="gmail-result_box" class="gmail-short_text" tabindex="-1" lang="en"><span><br></span></span></div><div><span id="gmail-result_box" class="gmail-short_text" tabindex="-1" lang="en"><span>I just update the commit message and push a v3 of this patch.<br></span></span></div><div><span id="gmail-result_box" class="gmail-short_text" tabindex="-1" lang="en"><span><br></span></span></div><span id="gmail-result_box" class="gmail-short_text" tabindex="-1" lang="en"><span>Best regards,<br></span></span></div><span id="gmail-result_box" class="gmail-short_text" tabindex="-1" lang="en"><span>Thomas P.</span></span><br><br><br><br><div class="gmail_extra"><div class="gmail_quote">On Tue, Oct 24, 2017 at 10:08 AM, André Draszik <span dir="ltr"><<a href="mailto:git@andred.net" target="_blank">git@andred.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<span class=""><br>
On Mon, 2017-10-23 at 18:23 +0200, Thomas Perrot wrote:<br>
> Signed-off-by: Thomas Perrot <<a href="mailto:thomas.perrot@tupi.fr">thomas.perrot@tupi.fr</a>><br>
<br>
</span>Your commit message doesn't explain what problem you're trying to solve.<br>
<br>
I can only guess that it's the same as this:<br>
<a href="http://lists.openembedded.org/pipermail/openembedded-core/2017-September/142619.html" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>pipermail/openembedded-core/<wbr>2017-September/142619.html</a><br>
<a href="http://lists.openembedded.org/pipermail/openembedded-core/2017-September/142621.html" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>pipermail/openembedded-core/<wbr>2017-September/142621.html</a><br>
<br>
? If so, just submit requests for backporting, or explain why this doesn't<br>
work in pyro.<br>
<span class=""><br>
<br>
> ---<br>
> meta/classes/kernel-fitimage.<wbr>bbclass | 2 +-<br>
> meta/classes/uboot-sign.<wbr>bbclass | 21 +++++++++------------<br>
> 2 files changed, 10 insertions(+), 13 deletions(-)<br>
><br>
> diff --git a/meta/classes/kernel-<wbr>fitimage.bbclass b/meta/classes/kernel-<br>
> fitimage.bbclass<br>
> index abbc309b09..5ad439e82d 100644<br>
> --- a/meta/classes/kernel-<wbr>fitimage.bbclass<br>
> +++ b/meta/classes/kernel-<wbr>fitimage.bbclass<br>
> @@ -31,7 +31,7 @@ python __anonymous () {<br>
> # the fitImage:<br>
> if d.getVar('UBOOT_SIGN_ENABLE') == "1":<br>
> uboot_pn = d.getVar('PREFERRED_PROVIDER_<wbr>u-boot') or 'u-boot'<br>
> - d.appendVarFlag('do_assemble_<wbr>fitimage', 'depends', '<br>
> %s:do_deploy' % uboot_pn)<br>
> + d.appendVarFlag('do_assemble_<wbr>fitimage', 'depends', '<br>
> %s:do_deploy_dtb' % uboot_pn)<br>
<br>
</span>You should also update the description of the executed tasks at the top of<br>
uboot-sign.bbclass if you're changing this.<br>
<br>
Cheers,<br>
Andre'<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
> }<br>
><br>
> # Options for the device tree compiler passed to mkimage '-D' feature:<br>
> diff --git a/meta/classes/uboot-sign.<wbr>bbclass b/meta/classes/uboot-<br>
> sign.bbclass<br>
> index 8ee904e7df..2f616bf2a9 100644<br>
> --- a/meta/classes/uboot-sign.<wbr>bbclass<br>
> +++ b/meta/classes/uboot-sign.<wbr>bbclass<br>
> @@ -47,16 +47,14 @@ do_deploy_dtb () {<br>
> cd ${DEPLOYDIR}<br>
><br>
> if [ -f ${B}/${UBOOT_DTB_BINARY} ]; then<br>
> - install ${B}/${UBOOT_DTB_BINARY}<br>
> ${DEPLOYDIR}/${UBOOT_DTB_<wbr>IMAGE}<br>
> - rm -f ${UBOOT_DTB_BINARY} ${UBOOT_DTB_SYMLINK}<br>
> - ln -sf ${UBOOT_DTB_IMAGE} ${UBOOT_DTB_SYMLINK}<br>
> - ln -sf ${UBOOT_DTB_IMAGE} ${UBOOT_DTB_BINARY}<br>
> + install ${B}/${UBOOT_DTB_BINARY}<br>
> ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>DTB_IMAGE}<br>
> + ln -sf ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>DTB_IMAGE}<br>
> ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>DTB_SYMLINK}<br>
> + ln -sf ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>DTB_IMAGE}<br>
> ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>DTB_BINARY}<br>
> fi<br>
> if [ -f ${B}/${UBOOT_NODTB_BINARY} ]; then<br>
> - install ${B}/${UBOOT_NODTB_BINARY}<br>
> ${DEPLOYDIR}/${UBOOT_NODTB_<wbr>IMAGE}<br>
> - rm -f ${UBOOT_NODTB_BINARY} ${UBOOT_NODTB_SYMLINK}<br>
> - ln -sf ${UBOOT_NODTB_IMAGE} ${UBOOT_NODTB_SYMLINK}<br>
> - ln -sf ${UBOOT_NODTB_IMAGE} ${UBOOT_NODTB_BINARY}<br>
> + install ${B}/${UBOOT_NODTB_BINARY}<br>
> ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>NODTB_IMAGE}<br>
> + ln -sf ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>NODTB_IMAGE}<br>
> ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>NODTB_SYMLINK}<br>
> + ln -sf ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>NODTB_IMAGE}<br>
> ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>NODTB_BINARY}<br>
> fi<br>
> }<br>
><br>
> @@ -70,11 +68,10 @@ do_concat_dtb () {<br>
> oe_runmake<br>
> EXT_DTB=${DEPLOYDIR}/${UBOOT_<wbr>DTB_IMAGE}<br>
> install ${B}/${UBOOT_BINARY}<br>
> ${DEPLOYDIR}/${UBOOT_IMAGE}<br>
> install ${B}/${UBOOT_BINARY}<br>
> ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>IMAGE}<br>
> - elif [ -e "${DEPLOYDIR}/${UBOOT_NODTB_<wbr>IMAGE}" -a -e<br>
> "${DEPLOYDIR}/${UBOOT_DTB_<wbr>IMAGE}" ]; then<br>
> - cd ${DEPLOYDIR}<br>
> - cat ${UBOOT_NODTB_IMAGE} ${UBOOT_DTB_IMAGE} | tee<br>
> ${B}/${UBOOT_BINARY} > ${UBOOT_IMAGE}<br>
> + elif [ -e "${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>NODTB_IMAGE}" -a<br>
> -e "${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>DTB_IMAGE}" ]; then<br>
> + cat ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>NODTB_IMAGE}<br>
> ${DEPLOY_DIR_IMAGE}/${UBOOT_<wbr>DTB_IMAGE} | tee ${B}/${UBOOT_BINARY} ><br>
> ${UBOOT_IMAGE}<br>
> else<br>
> - bbwarn "Failure while adding public key to u-boot<br>
> binary. Verified boot won't be available."<br>
> + bbfatal "Failure while adding public key to u-<br>
> boot binary. Verified boot won't be available."<br>
> fi<br>
> fi<br>
> }<br>
> --<br>
> 2.13.6<br>
><br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></blockquote></div><br></div></div>