<div dir="ltr">No Upstream-Status in the patch, can you add that please.<div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 6 November 2017 at 10:47, Belal, Awais <span dir="ltr"><<a href="mailto:Awais_Belal@mentor.com" target="_blank">Awais_Belal@mentor.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ping!<br>
<br>
BR,<br>
Awais<br>
<br>
______________________________<wbr>__________<br>
From: Belal, Awais<br>
Sent: Wednesday, October 25, 2017 9:03 PM<br>
To: <a href="mailto:openembedded-core@lists.openembedded.org">openembedded-core@lists.<wbr>openembedded.org</a><br>
Cc: Belal, Awais<br>
Subject: [PATCH] dhcp: fix build issue with libxml2 support<br>
<div class="HOEnZb"><div class="h5"><br>
A missing case breaks the build when libxml2 is<br>
required and found appropriately. The third argument<br>
to the function AC_SEARCH_LIB is action-if-found which<br>
was mistakenly been used for the case where the library<br>
is not found and hence breaks the configure phase<br>
where it shoud actually pass.<br>
We now pass on silently when action-if-found is<br>
executed.<br>
<br>
Signed-off-by: Awais Belal <<a href="mailto:awais_belal@mentor.com">awais_belal@mentor.com</a>><br>
---<br>
...correct-the-intention-for-<wbr>xml2-lib-search.patch | 35 ++++++++++++++++++++++<br>
meta/recipes-connectivity/<wbr>dhcp/<a href="http://dhcp_4.3.6.bb" rel="noreferrer" target="_blank">dhcp_4.3.6.bb</a> | 1 +<br>
2 files changed, 36 insertions(+)<br>
create mode 100644 meta/recipes-connectivity/<wbr>dhcp/dhcp/0012-dhcp-correct-<wbr>the-intention-for-xml2-lib-<wbr>search.patch<br>
<br>
diff --git a/meta/recipes-connectivity/<wbr>dhcp/dhcp/0012-dhcp-correct-<wbr>the-intention-for-xml2-lib-<wbr>search.patch b/meta/recipes-connectivity/<wbr>dhcp/dhcp/0012-dhcp-correct-<wbr>the-intention-for-xml2-lib-<wbr>search.patch<br>
new file mode 100644<br>
index 0000000000..6ded764d0e<br>
--- /dev/null<br>
+++ b/meta/recipes-connectivity/<wbr>dhcp/dhcp/0012-dhcp-correct-<wbr>the-intention-for-xml2-lib-<wbr>search.patch<br>
@@ -0,0 +1,35 @@<br>
+From 501543b3ef715488a142e3d301ff27<wbr>33aa33eec7 Mon Sep 17 00:00:00 2001<br>
+From: Awais Belal <<a href="mailto:awais_belal@mentor.com">awais_belal@mentor.com</a>><br>
+Date: Wed, 25 Oct 2017 21:00:05 +0500<br>
+Subject: [PATCH] dhcp: correct the intention for xml2 lib search<br>
+<br>
+A missing case breaks the build when libxml2 is<br>
+required and found appropriately. The third argument<br>
+to the function AC_SEARCH_LIB is action-if-found which<br>
+was mistakenly been used for the case where the library<br>
+is not found and hence breaks the configure phase<br>
+where it shoud actually pass.<br>
+We now pass on silently when action-if-found is<br>
+executed.<br>
+<br>
+Signed-off-by: Awais Belal <<a href="mailto:awais_belal@mentor.com">awais_belal@mentor.com</a>><br>
+---<br>
+ <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 2 +-<br>
+ 1 file changed, 1 insertion(+), 1 deletion(-)<br>
+<br>
+diff --git a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
+index bfe988a..f0459e6 100644<br>
+--- a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
++++ b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
+@@ -608,7 +608,7 @@ AC_ARG_WITH(libxml2,<br>
+ with_libxml2="$withval", with_libxml2="no")<br>
+<br>
+ if test x$with_libxml2 != xno; then<br>
+- AC_SEARCH_LIBS(<wbr>xmlTextWriterStartElement, [xml2],<br>
++ AC_SEARCH_LIBS(<wbr>xmlTextWriterStartElement, [xml2],,<br>
+ [if test x$with_libxml2 != xauto; then<br>
+ AC_MSG_FAILURE([*** Cannot find xmlTextWriterStartElement with -lxml2 and libxml2 was requested])<br>
+ fi])<br>
+--<br>
+2.11.1<br>
+<br>
diff --git a/meta/recipes-connectivity/<wbr>dhcp/<a href="http://dhcp_4.3.6.bb" rel="noreferrer" target="_blank">dhcp_4.3.6.bb</a> b/meta/recipes-connectivity/<wbr>dhcp/<a href="http://dhcp_4.3.6.bb" rel="noreferrer" target="_blank">dhcp_4.3.6.bb</a><br>
index 4634a01b04..6615ae2555 100644<br>
--- a/meta/recipes-connectivity/<wbr>dhcp/<a href="http://dhcp_4.3.6.bb" rel="noreferrer" target="_blank">dhcp_4.3.6.bb</a><br>
+++ b/meta/recipes-connectivity/<wbr>dhcp/<a href="http://dhcp_4.3.6.bb" rel="noreferrer" target="_blank">dhcp_4.3.6.bb</a><br>
@@ -11,6 +11,7 @@ SRC_URI += "file://0001-define-macro-_<wbr>PATH_DHCPD_CONF-and-_PATH_<wbr>DHCLIENT_CON.pat<br>
file://0009-remove-dhclient-<wbr>script-bash-dependency.patch \<br>
file://0010-build-shared-libs.<wbr>patch \<br>
file://0011-Moved-the-call-to-<wbr>isc_app_ctxstart-to-not-get-<wbr>signal.patch \<br>
+ file://0012-dhcp-correct-the-<wbr>intention-for-xml2-lib-search.<wbr>patch \<br>
"<br>
<br>
SRC_URI[md5sum] = "<wbr>afa6e9b3eb7539ea048421a82c668a<wbr>dc"<br>
--<br>
2.11.1<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</div></div></blockquote></div><br></div>