<div dir="ltr">On 14 November 2017 at 12:06, Patrick Ohly <span dir="ltr">&lt;<a href="mailto:patrick.ohly@intel.com" target="_blank">patrick.ohly@intel.com</a>&gt;</span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, 2017-11-06 at 17:55 +0000, Ross Burton wrote:<br>
&gt;                     testcommand = &#39;ls /etc/&#39; + fileboot_name<br>
<br>
</span>Can&#39;t this be removed?<br>
<span class=""><br>
&gt;                      with runqemu(&#39;core-image-minimal&#39;) as qemu:<br>
&gt; -                        ssh = SSHControl(ip=qemu.ip, logfile=qemu.sshlog)<br>
&gt; -                        status, output = ssh.run(testcommand)<br>
&gt; +                        status, output = qemu.run_serial(&quot;-f /etc/&quot; + fileboot_name)<br>
<br>
</span>Did you mean &quot;test -f&quot;?</blockquote><div><br></div><div>Yes! Argh.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
&gt;                          self.assertEqual(status, 0, &#39;File %s was not created at first boot (%s)&#39; % (fileboot_name, output))<br>
<br>
</span>run_serial has the quirk that status == 1 on *success*. Yes, weird.<br></blockquote><div><br></div><div>Oh &lt;redacted&gt;.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The test probably passed because it was testing for failure, and the<br>
missing &quot;test&quot; ensured that the command failed.<br></blockquote><div><br></div><div>Thanks.  Sorry.</div><div><br></div><div>Ross </div></div></div></div>