<div dir="ltr">On 23 November 2017 at 01:34, Joshua Lock <span dir="ltr"><<a href="mailto:joshua.g.lock@linux.intel.com" target="_blank">joshua.g.lock@linux.intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><span class="gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"> @OETestID(1540)<br>
</blockquote>
<br></span>
We're effectively stating that test ID 1540 and test ID 1545 are both covered by the same test method, right?<br>
<br>
Perhaps we don't need to maintain both test cases in Testopia, as we'll only ever see both tests pass or fail?</blockquote><div><br></div><div>Yes, reviewing and sanitising testopia was my next job.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div><div class="gmail-h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">- features = 'MACHINE = "qemux86"\n'<br>
- features += 'CORE_IMAGE_EXTRA_INSTALL += "%s %s "\n'% (rootfs_pkg, boot_pkg)<br>
+ features = 'CORE_IMAGE_EXTRA_INSTALL = "postinst-delayed-b"\n'<br>
features += 'IMAGE_FEATURES += "package-management empty-root-password"\n'<br>
</blockquote>
<br></div></div>
The indentation doesn't look right here?</blockquote><div><br></div><div>That would be Atom "helpfully" doing smart intentation. I'll fix it up in something else, thanks.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">+ status, output = qemu.run_serial("test -f %s && echo found" % os.path.join(targettestdir, filename))<br>
+ self.assertEqual(output, "found", "%s was not present on boot" % filename)<br>
<br>
</blockquote>
<br></span>
Why not just test the status (return code of test -f) instead of echoing a known value? i.e.<br>
<br>
self.assertEqual(status, 0, "%s was not present on boot" % filename)</blockquote><div><br></div><div>Because run_serial() is a bit lame and I don't trust it to correctly report the exit status. Rewriting it is on my hitlist, yes.</div><div><br></div><div>Ross</div></div></div></div>