<div dir="ltr">Does it really need coreutils stat, or is busybox's stat sufficient?<div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 15 December 2017 at 01:18, Yi Zhao <span dir="ltr"><<a href="mailto:yi.zhao@windriver.com" target="_blank">yi.zhao@windriver.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Currently only hdparm specifies stat as runtime dependency in oe-core.<br>
But the stat hasn't any update since 2002. Replace it with coreutils as<br>
runtime dependency since coreutils also provides stat program. Then we<br>
can drop the stat recipe totally.<br>
<br>
Also add a patch to fix stat path in wiper.sh.<br>
<br>
Signed-off-by: Yi Zhao <<a href="mailto:yi.zhao@windriver.com">yi.zhao@windriver.com</a>><br>
---<br>
.../hdparm/hdparm/wiper.sh-<wbr>fix-stat-path.patch | 38 ++++++++++++++++++++++<br>
meta/recipes-extended/hdparm/<a href="http://hdparm_9.52.bb" rel="noreferrer" target="_blank">h<wbr>dparm_9.52.bb</a> | 6 ++--<br>
2 files changed, 42 insertions(+), 2 deletions(-)<br>
create mode 100644 meta/recipes-extended/hdparm/<wbr>hdparm/wiper.sh-fix-stat-path.<wbr>patch<br>
<br>
diff --git a/meta/recipes-extended/<wbr>hdparm/hdparm/wiper.sh-fix-<wbr>stat-path.patch b/meta/recipes-extended/<wbr>hdparm/hdparm/wiper.sh-fix-<wbr>stat-path.patch<br>
new file mode 100644<br>
index 0000000..4af1b61<br>
--- /dev/null<br>
+++ b/meta/recipes-extended/<wbr>hdparm/hdparm/wiper.sh-fix-<wbr>stat-path.patch<br>
@@ -0,0 +1,38 @@<br>
+From e233006ee212109d2a1401dac37a9a<wbr>851cc493d8 Mon Sep 17 00:00:00 2001<br>
+From: Yi Zhao <<a href="mailto:yi.zhao@windriver.com">yi.zhao@windriver.com</a>><br>
+Date: Thu, 14 Dec 2017 15:23:47 +0800<br>
+Subject: [PATCH] wiper.sh: fix stat path<br>
+<br>
+Fix the stat path for OE.<br>
+<br>
+Upstream-Status: Inappropriate [OE specific]<br>
+<br>
+Signed-off-by: Yi Zhao <<a href="mailto:yi.zhao@windriver.com">yi.zhao@windriver.com</a>><br>
+---<br>
+ wiper/wiper.sh | 3 +--<br>
+ 1 file changed, 1 insertion(+), 2 deletions(-)<br>
+<br>
+diff --git a/wiper/wiper.sh b/wiper/wiper.sh<br>
+index 79eddc8..9ef2840 100755<br>
+--- a/wiper/wiper.sh<br>
++++ b/wiper/wiper.sh<br>
+@@ -97,7 +97,6 @@ function find_prog(){<br>
+ hash -r ## Refresh bash's cached PATH entries<br>
+ HDPARM=`find_prog /sbin/hdparm` || exit 1<br>
+ FIND=`find_prog /usr/bin/find` || exit 1<br>
+-STAT=`find_prog /usr/bin/stat` || exit 1<br>
+ GAWK=`find_prog /usr/bin/gawk` || exit 1<br>
+ BLKID=`find_prog /sbin/blkid` || exit 1<br>
+ GREP=`find_prog /bin/grep` || exit 1<br>
+@@ -105,7 +104,7 @@ ID=`find_prog /usr/bin/id` || exit 1<br>
+ LS=`find_prog /bin/ls` || exit 1<br>
+ DF=`find_prog /bin/df` || exit 1<br>
+ RM=`find_prog /bin/rm` || exit 1<br>
+-STAT=`find_prog /usr/bin/stat` || exit 1<br>
++STAT=`find_prog /bin/stat` || exit 1<br>
+<br>
+ [ $verbose -gt 1 ] && HDPARM="$HDPARM --verbose"<br>
+<br>
+--<br>
+2.7.4<br>
+<br>
diff --git a/meta/recipes-extended/<wbr>hdparm/<a href="http://hdparm_9.52.bb" rel="noreferrer" target="_blank">hdparm_9.52.bb</a> b/meta/recipes-extended/<wbr>hdparm/<a href="http://hdparm_9.52.bb" rel="noreferrer" target="_blank">hdparm_9.52.bb</a><br>
index 49fdc94..13cfb3f 100644<br>
--- a/meta/recipes-extended/<wbr>hdparm/<a href="http://hdparm_9.52.bb" rel="noreferrer" target="_blank">hdparm_9.52.bb</a><br>
+++ b/meta/recipes-extended/<wbr>hdparm/<a href="http://hdparm_9.52.bb" rel="noreferrer" target="_blank">hdparm_9.52.bb</a><br>
@@ -19,9 +19,11 @@ PACKAGES =+ "wiper"<br>
<br>
FILES_wiper = "${bindir}/wiper.sh"<br>
<br>
-RDEPENDS_wiper = "bash gawk stat"<br>
+RDEPENDS_wiper = "bash gawk coreutils"<br>
<br>
-SRC_URI = "${SOURCEFORGE_MIRROR}/hdparm/<wbr>${BP}.tar.gz"<br>
+SRC_URI = "${SOURCEFORGE_MIRROR}/hdparm/<wbr>${BP}.tar.gz \<br>
+ file://wiper.sh-fix-stat-path.<wbr>patch \<br>
+ "<br>
<br>
SRC_URI[md5sum] = "<wbr>410539d0bf3cc247181594581edbfb<wbr>53"<br>
SRC_URI[sha256sum] = "<wbr>c3429cd423e271fa565bf584598fd7<wbr>51dd2e773bb7199a592b06b5a61cec<wbr>4fb6"<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></blockquote></div><br></div>