<div dir="ltr">On 19 December 2017 at 21:20, Tom Rini <span dir="ltr"><<a href="mailto:trini@konsulko.com" target="_blank">trini@konsulko.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Tue, Dec 19, 2017 at 01:19:09PM -0800, Andre McCurdy wrote:<br>
> On Tue, Dec 19, 2017 at 12:54 PM, Tom Rini <<a href="mailto:trini@konsulko.com">trini@konsulko.com</a>> wrote:<br>
> > On Tue, Dec 19, 2017 at 12:11:48PM -0800, Saul Wold wrote:<br>
> >> We have seen more failures, but have not been able to directly reproduce<br>
> >> it maybe svaing the rootfs and it contains some content that is tripping<br>
> >> up the e2fsprogs mkfs.ext4 populate_rootfs() function<br>
> >><br>
> >> Signed-off-by: Saul Wold <<a href="mailto:sgw@linux.intel.com">sgw@linux.intel.com</a>><br>
> >> ---<br>
> >> meta/classes/image_types.<wbr>bbclass | 7 ++++++-<br>
> >> 1 file changed, 6 insertions(+), 1 deletion(-)<br>
> >><br>
> >> diff --git a/meta/classes/image_types.<wbr>bbclass b/meta/classes/image_types.<wbr>bbclass<br>
> >> index 9188bed4197..6b4f39ed274 100644<br>
> >> --- a/meta/classes/image_types.<wbr>bbclass<br>
> >> +++ b/meta/classes/image_types.<wbr>bbclass<br>
> >> @@ -86,9 +86,14 @@ oe_mkext234fs () {<br>
> >> bbdebug 1 Executing "dd if=/dev/zero of=${IMGDEPLOYDIR}/${IMAGE_<wbr>NAME}${IMAGE_NAME_SUFFIX}.$<wbr>fstype seek=$ROOTFS_SIZE count=$COUNT bs=1024"<br>
> >> dd if=/dev/zero of=${IMGDEPLOYDIR}/${IMAGE_<wbr>NAME}${IMAGE_NAME_SUFFIX}.$<wbr>fstype seek=$ROOTFS_SIZE count=$COUNT bs=1024<br>
> >> bbdebug 1 "Actual Rootfs size: `du -s ${IMAGE_ROOTFS}`"<br>
> >> - bbdebug 1 "Actual Partion size: `ls -s ${IMGDEPLOYDIR}/${IMAGE_NAME}$<wbr>{IMAGE_NAME_SUFFIX}.$fstype`"<br>
> >> + bbdebug 1 "Actual Partion size: `ls -l ${IMGDEPLOYDIR}/${IMAGE_NAME}$<wbr>{IMAGE_NAME_SUFFIX}.$fstype`"<br>
> >> bbdebug 1 Executing "mkfs.$fstype -F $extra_imagecmd ${IMGDEPLOYDIR}/${IMAGE_NAME}$<wbr>{IMAGE_NAME_SUFFIX}.$fstype -d ${IMAGE_ROOTFS}"<br>
> >> mkfs.$fstype -F $extra_imagecmd ${IMGDEPLOYDIR}/${IMAGE_NAME}$<wbr>{IMAGE_NAME_SUFFIX}.$fstype -d ${IMAGE_ROOTFS}<br>
> >> + if [ $? -ne 0 ]; then<br>
> >> + tmp_saved_rootfs=`mktemp -d -p /tmp saved_rootfs.XXXXX`<br>
> >> + cp -r ${IMAGE_ROOTFS} $tmp_saved_rootfs<br>
> >> + fi<br>
> ><br>
> > Wouldn't it be better to just fail on error here, rather than dump stuff<br>
> > to /tmp ?<br>
><br>
> It already does fail with an error. Saving the state is temporary<br>
> additional debug to help understand why.<br>
><br>
> <a href="https://bugzilla.yoctoproject.org/show_bug.cgi?id=12304" rel="noreferrer" target="_blank">https://bugzilla.yoctoproject.<wbr>org/show_bug.cgi?id=12304</a><br>
<br>
</div></div>So the problem is with the autobuilder where everything else gets blown<br>
away. That's fine, this is an autobuilder specific work-around, not a<br>
general purpose patch and shouldn't be in mainline, would be my point.<br></blockquote><div><br></div><div>I suspect this will just hang in master-next and never merge into master.</div><div><br></div><div>Ross </div></div></div></div>