<html><head></head><body><div>On Wed, 2018-01-31 at 18:07 +0100, Martin Jansa wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr">What about the recipes which don't have ${S}/waf at all (and might inherit waf from possibly wrong reasons), like all those waf-samba recipes mentioned before?</div></blockquote><div><br></div><div>Ya, sorry I should have clarified: This should fix it for recipes that only include waf.bbclass (e.g. jack and my local waf recipes that were also getting the same error). I still think that perhaps waf-samba.bbclass probably shouldn't be inheriting from waf.bbclass if the intent is that those projects doesn't actually have ${S}/waf.... but to be fair I haven't looked closely at the recipes that inherit waf-samba.bbclass.</div><div><br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 31, 2018 at 6:04 PM, Joshua Watt <span dir="ltr"><<a href="mailto:jpewhacker@gmail.com" target="_blank">jpewhacker@gmail.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><div>Sorry, I wasn't sure if I should make my patch in-reply-to this thread....</div><div><br></div><div>I think I fixed this correctly in <a href="http://lists.openembedded.org/pipermail/openembedded-core/2018-January/147041.html" target="_blank">http://lists.openembedded.org/<wbr>pipermail/openembedded-core/<wbr>2018-January/147041.html</a></div><div><br></div><div>Thanks,</div><div>Joshua Watt</div><div><div class="h5"><div><br></div><div>On Wed, 2018-01-31 at 00:39 +0100, Martin Jansa wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr">+Stefan<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 31, 2018 at 12:38 AM, Martin Jansa <span dir="ltr"><<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr">Thanks Andreas,<div><br></div><div>jack is the only one which inherits waf directly not through waf-samba.</div><div><br></div><div>More surprisingly it also has ${S}/waf it seems:</div><div><a href="https://github.com/jackaudio/jack2/blob/c1647819eed6d11f94b21981d9c869629299f357/waf" target="_blank">https://github.com/jackaudio/j<wbr>ack2/blob/c1647819eed6d11f94b2<wbr>1981d9c869629299f357/waf</a><br></div><div><br></div><div>So the WARNING: shown for jack probably had different reason than the rest of them and that is:</div><div><br></div><div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">jack/1.9.12-r0 $ </span>jack/1.9.12-r0/git/waf --version</div><div>Error: run waf-light from a folder containing waflib<br></div></div><div><br></div><div>it doesn't like running waf from outside ${S} and waf_preconfigure is executed from ${TOPDIR} before do_configure switches to ${S}</div><div><br></div><div>I don't know how common this situation is, if all waf scripts are like that, this one (after "cd ../jack/1.9.12-r0/git") says:</div><div>waf 1.8.17 (cd7579a727d1b390bf9cbf111c1b2<wbr>0e811370bc0)<br></div><div><br></div><div>so I'll leave that to original author to figure it out, I don't use waf anywhere, so I cannot properly test the use case he was trying to fix.</div><div><br></div><div>Regards,</div><div><br></div><div><br></div></div><div class="m_-6881681134499472655HOEnZb"><div class="m_-6881681134499472655h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 30, 2018 at 11:41 PM, Andreas Müller <span dir="ltr"><<a href="mailto:schnitzeltony@gmail.com" target="_blank">schnitzeltony@gmail.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><span><br><br>On Tuesday, January 30, 2018, Martin Jansa <<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a>> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr">+Andreas who added waf inherit in jack in:<div><div>commit 0f8f1973e229a0799098bc2334416f<wbr>ec8c608b50</div><div>Author: Andreas Müller <<a href="mailto:schnitzeltony@googlemail.com" target="_blank">schnitzeltony@googlemail.com</a>></div><div>Date: Sat Oct 8 12:03:32 2016 +0200</div><div><br></div><div> jack: swap to jack2</div></div></div></blockquote></span><div>As far as I can see is jack2 configured with waf. Don't remember why I chose waf-samba. Because I am on business trip I cannot take care before next week.</div><span class="m_-6881681134499472655m_4846283783382334223HOEnZb"><font color="#888888"><div><br></div><div>Andreas</div></font></span><div class="m_-6881681134499472655m_4846283783382334223HOEnZb"><div class="m_-6881681134499472655m_4846283783382334223h5"><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>+Bian who added waf samba in:</div><div><div>commit 962e346df99696a10657a2ea7b2166<wbr>dfaf290289</div><div>Author: Bian Naimeng <<a href="mailto:biannm@cn.fujitsu.com" target="_blank">biannm@cn.fujitsu.com</a>></div><div>Date: Tue Jun 16 14:18:25 2015 +0900</div><div><br></div><div> waf-samba: add new class</div><div> </div><div> waf-samba is a build system used by samba related software</div></div><div><br></div><div>+Joe and Joe and who maintains samba and related recipes + meta-networking</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 30, 2018 at 1:03 PM, Burton, Ross <span dir="ltr"><<a href="mailto:ross.burton@intel.com" target="_blank">ross.burton@intel.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr">Why would they do that? Shouldn't it be a fatal bug if waf isn't found?</div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On 30 January 2018 at 08:30, Martin Jansa <span dir="ltr"><<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a>></span> wrote:<br></div></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><div>* there are some recipes like jack and other which inherit waf-samba<br>
which inherits waf, but they don't use waf for configure, strange isn't<br>
it?<br>
<br>
* fixes:<br>
WARNING: libldb-1.1.29-r0 do_configure: Unable to execute waf --version, exit code 127. Assuming waf version without bindir/libdir support.<br>
WARNING: samba-4.6.7-r0 do_configure: Unable to execute waf --version, exit code 127. Assuming waf version without bindir/libdir support.<br>
WARNING: libtalloc-2.1.9-r0 do_configure: Unable to execute waf --version, exit code 127. Assuming waf version without bindir/libdir<br>
support.<br>
WARNING: jack-1.9.10+gitAUTOINC+2d1d323<wbr>505-r0 do_configure: Unable to execute waf --version, exit code 1. Assuming waf version without bindir/libdir support.<br>
WARNING: libtevent-0.9.31-r0 do_configure: Unable to execute waf --version, exit code 127. Assuming waf version without bindir/libdir support.<br>
WARNING: libtdb-1.3.14-r0 do_configure: Unable to execute waf --version, exit code 127. Assuming waf version without bindir/libdir support.<br>
<br>
Signed-off-by: Martin Jansa <<a href="mailto:Martin.Jansa@gmail.com" target="_blank">Martin.Jansa@gmail.com</a>><br>
---<br>
meta/classes/waf.bbclass | 3 +++<br>
1 file changed, 3 insertions(+)<br>
<br>
diff --git a/meta/classes/waf.bbclass b/meta/classes/waf.bbclass<br>
index c3e744e5de..eec4d9496d 100644<br>
--- a/meta/classes/waf.bbclass<br>
+++ b/meta/classes/waf.bbclass<br>
@@ -29,6 +29,9 @@ python waf_preconfigure() {<br>
from distutils.version import StrictVersion<br>
srcsubdir = d.getVar('S')<br>
wafbin = os.path.join(srcsubdir, 'waf')<br>
+ if not os.path.isfile(wafbin):<br>
+ bb.note("%s doesn't exist, cannot check whether it supports --bindir/--libdir" % wafbin)<br>
+ return<br>
status, result = oe.utils.getstatusoutput(wafbi<wbr>n + " --version")<br>
if status != 0:<br>
bb.warn("Unable to execute waf --version, exit code %d. Assuming waf version without bindir/libdir support." % status)<br>
</div></div><span><font color="#888888"><span><font color="#888888">--<br>
2.15.1<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openem<wbr>bedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></font></span></blockquote></div><br></div>
</blockquote></div><br></div>
<br></blockquote>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</blockquote></div></div></div></blockquote></div><br></div>
</blockquote></body></html>