<div dir="ltr">I'm sorry, I haven't seen this one, because I have packagegroup-core-lsb blacklisted for long time.<div><br></div><div>What is preferred fix?</div><div>1) add the same restriction to packagegroup-core-lsb and core-image-lsb and someone will fix poky-lsb build (it doesn't seem like separate distro), to include pam in DISTRO_FEATURES.</div><div>2) include libpam and pam-plugin-wheel in packagegroup-core-lbs (and RDEPENDS_packagegroup-core-lsb-runtime-add) only when pam is in DISTRO_FEATURES?</div><div><br></div><div>The warning says that libpam is broken without pam in DISTRO_FEATURES, I'm not sure how much LSB tests exercise it, but if the warning is correct, then it was broken in poky-lsb builds runtime already.</div><div><br></div><div>Regards,</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 5, 2018 at 12:54 PM, Burton, Ross <span dir="ltr"><<a href="mailto:ross.burton@intel.com" target="_blank">ross.burton@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This breaks world builds on the autobuilder with poky-lsb:<div><br></div><div><a href="https://autobuilder.yocto.io/builders/nightly-world/builds/736/steps/BuildImages/logs/stdio" target="_blank">https://autobuilder.yocto.io/<wbr>builders/nightly-world/builds/<wbr>736/steps/BuildImages/logs/<wbr>stdio</a><br></div><div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On 1 February 2018 at 14:34, Martin Jansa <span dir="ltr"><<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">* replace do_pam_sanity function with distro_features_check inherit<br>
* fixes:<br>
WARNING: libpam-1.3.0-r5 do_pam_sanity: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly<br>
in world builds and prevents user to build libpam at all without pam<br>
in DISTRO_FEATURES, I don't see any users of this which wouldn't respect<br>
pam in DISTRO_FEATURES<br>
* only libuser is depending on libpam without respecting DISTRO_FEATURES<br>
* there are few recipes in meta-oe layers depending on libpam without<br>
respecting DISTRO_FEATURES, I've sent patch for them:<br>
samba, openwsman, pam-ssh-agent-auth, sblim-sfcb, passwdqc, python-pam, smbnetfs<br>
and omxplayer in meta-raspberrypi, I've sent PR for that one:<br>
<a href="https://github.com/agherzan/meta-raspberrypi/pull/192" rel="noreferrer" target="_blank">https://github.com/agherzan/me<wbr>ta-raspberrypi/pull/192</a><br>
<br>
Signed-off-by: Martin Jansa <<a href="mailto:Martin.Jansa@gmail.com" target="_blank">Martin.Jansa@gmail.com</a>><br>
---<br>
meta/recipes-extended/<wbr>libuser/<a href="http://libuser_0.62.bb" rel="noreferrer" target="_blank">libuser_0.62.bb</a> | 3 +++<br>
meta/recipes-extended/pam/<a href="http://libpam_1.3.0.bb" rel="noreferrer" target="_blank">lib<wbr>pam_1.3.0.bb</a> | 7 ++-----<br>
2 files changed, 5 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/meta/recipes-extended/libuse<wbr>r/<a href="http://libuser_0.62.bb" rel="noreferrer" target="_blank">libuser_0.62.bb</a> b/meta/recipes-extended/libuse<wbr>r/<a href="http://libuser_0.62.bb" rel="noreferrer" target="_blank">libuser_0.62.bb</a><br>
index 1765346646..7ec54eb16e 100644<br>
--- a/meta/recipes-extended/libuse<wbr>r/<a href="http://libuser_0.62.bb" rel="noreferrer" target="_blank">libuser_0.62.bb</a><br>
+++ b/meta/recipes-extended/libuse<wbr>r/<a href="http://libuser_0.62.bb" rel="noreferrer" target="_blank">libuser_0.62.bb</a><br>
@@ -22,6 +22,9 @@ SRC_URI[sha256sum] = "a58ff4fabb01a25043b142185a33e<wbr>eea961109dd60d4b40b6a9df4fa3c<br>
<br>
DEPENDS = "popt libpam glib-2.0 python3"<br>
<br>
+inherit distro_features_check<br>
+REQUIRED_DISTRO_FEATURES = "pam"<br>
+<br>
inherit autotools gettext python3native python3-dir pkgconfig gtk-doc<br>
<br>
EXTRA_OEMAKE = "PYTHON_CPPFLAGS=-I${STAGING_I<wbr>NCDIR}/${PYTHON_DIR}${PYTHON_A<wbr>BI}"<br>
diff --git a/meta/recipes-extended/pam/<a href="http://libpam_1.3.0.bb" rel="noreferrer" target="_blank">li<wbr>bpam_1.3.0.bb</a> b/meta/recipes-extended/pam/<a href="http://libpam_1.3.0.bb" rel="noreferrer" target="_blank">li<wbr>bpam_1.3.0.bb</a><br>
index 8f7753d001..92ab72a42f 100644<br>
--- a/meta/recipes-extended/pam/<a href="http://libpam_1.3.0.bb" rel="noreferrer" target="_blank">li<wbr>bpam_1.3.0.bb</a><br>
+++ b/meta/recipes-extended/pam/<a href="http://libpam_1.3.0.bb" rel="noreferrer" target="_blank">li<wbr>bpam_1.3.0.bb</a><br>
@@ -151,11 +151,8 @@ do_install() {<br>
fi<br>
}<br>
<br>
-python do_pam_sanity () {<br>
- if not bb.utils.contains('DISTRO_FEAT<wbr>URES', 'pam', True, False, d):<br>
- bb.warn("Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly")<br>
-}<br>
-addtask pam_sanity before do_configure<br>
+inherit distro_features_check<br>
+REQUIRED_DISTRO_FEATURES = "pam"<br>
<br>
BBCLASSEXTEND = "nativesdk native"<br>
</div></div><span class="HOEnZb"><font color="#888888"><span class="m_-1740614866312516153HOEnZb"><font color="#888888"><br>
--<br>
2.15.1<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openem<wbr>bedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></font></span></blockquote></div><br></div>
</blockquote></div><br></div>