<div dir="ltr">A neater fix might be to drop the documentation change from the patch we're applying, as it's unlikely that people will be reading the autoconf documentation.<div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 7 February 2018 at 01:42, Juro Bystricky <span dir="ltr"><<a href="mailto:juro.bystricky@intel.com" target="_blank">juro.bystricky@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">autoconf-doc package contains <a href="http://autoconf.info" rel="noreferrer" target="_blank">autoconf.info</a>.<br>
This file contains date when this file was created, i.e:<br>
<br>
"This manual (31 January 2018) .."<br>
<br>
Therefore, two builds done on two different days will show different dates for<br>
otherwise identical files, hence breaking reproducibility.<br>
The date is obtained from mtime of "autoconf.texi", unfortunately we patch this<br>
file and change the mtime as a consequence.<br>
The date serves as a document version identifier, so preserving the original mtime of<br>
"autoconf.texi" would be misleading, as we actually did modify the document on purpose.<br>
The fix is to set the mtime of "autoconf.texi" based on SOURCE_DATE_EPOCH.<br>
<br>
[YOCTO #12524]<br>
<br>
Signed-off-by: Juro Bystricky <<a href="mailto:juro.bystricky@intel.com">juro.bystricky@intel.com</a>><br>
---<br>
meta/recipes-devtools/<wbr>autoconf/autoconf.inc | 9 +++++++++<br>
1 file changed, 9 insertions(+)<br>
<br>
diff --git a/meta/recipes-devtools/<wbr>autoconf/autoconf.inc b/meta/recipes-devtools/<wbr>autoconf/autoconf.inc<br>
index df81bc6..f5156f7 100644<br>
--- a/meta/recipes-devtools/<wbr>autoconf/autoconf.inc<br>
+++ b/meta/recipes-devtools/<wbr>autoconf/autoconf.inc<br>
@@ -48,6 +48,15 @@ do_configure() {<br>
oe_runconf<br>
}<br>
<br>
+do_compile_prepend_class-<wbr>target() {<br>
+ # mtime of autoconf.texi will end up as embedded date in <a href="http://autoconf.info" rel="noreferrer" target="_blank">autoconf.info</a>.<br>
+ # We patch autoconf.texi, so that modifies mtime each time.<br>
+ # To ensure reproducibility, set the mtime to SOURCE_DATE_EPOCH<br>
+ if [ -n "${SOURCE_DATE_EPOCH}" ]; then<br>
+ touch -d @${SOURCE_DATE_EPOCH} ${S}/doc/autoconf.texi<br>
+ fi<br>
+}<br>
+<br>
do_install_append() {<br>
rm -rf ${D}${datadir}/emacs<br>
}<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></blockquote></div><br></div>