<div dir="ltr">Hi, Richard:<div><br></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">I think the license deploy manifests should be at </span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:14px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">do_image_complete, since it not only deal with package licenses, but also licenses of deployed tools, like u-boot, and so on. So do you think if we set: </span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:14px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div><span style="text-align:start;text-indent:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><span style="font-size:14px">do_image_complete[recrdeptask] += "do_populate_lic"</span><br></span></div><div><span style="text-align:start;text-indent:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><span style="font-size:14px"><br></span></span></div><div><span style="text-align:start;text-indent:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><span style="font-size:14px">would help fix the problem?</span></span></div><div><br></div><div><span style="font-size:14px">//Ming Liu</span></div><div><span style="text-align:start;text-indent:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><span style="font-size:14px"><br></span></span></div></div><div class="gmail_extra"><br><div class="gmail_quote">2018-02-15 16:07 GMT+01:00 Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, 2018-02-15 at 15:11 +0100, Ming Liu wrote:<br>
> I observed this issue on rocko branch, but I think upstream also<br>
> needs it. Since even recrdepends handling had been changed in<br>
> bitbake, the problem here is the "recrdepends" is missing between<br>
> do_bootimg and do_populate_lic, actually there was a bug record for<br>
> it, see: <a href="https://bugzilla.yoctoproject.org/show_bug.cgi?id=9446" rel="noreferrer" target="_blank">https://bugzilla.<wbr>yoctoproject.org/show_bug.cgi?<wbr>id=9446</a>, but<br>
> the fix only considered the missing recrdepends of do_image, but<br>
> looking into get_deployed_<wbr>dependencies->get_boot_<wbr>dependencies, the<br>
> do_bootimg also needs a similar fix.<br>
<br>
</span>I've looked at this and this patch is not appropriate to be merged, its<br>
a hack, piled on top of other hacks which still don't actually solve<br>
the real problem.<br>
<br>
do_bootimg is added before do_image_complete, after do_image, along<br>
with a number of other image processing tasks. Either:<br>
<br>
a) license.bbclass requires the do_image dependencies for license<br>
processing.<br>
<br>
b) license.bbclass requires the do_image_complete dependencies and<br>
includes the tools used to produce the image.<br>
<br>
There is no "in between" state. Creating some kind of mismash of<br>
including some image tasks in the dependency list is simply not<br>
appropriate, its defined as one or the other.<br>
<br>
There is already "get_boot_dependencies" in license.bbclass which sets<br>
of alarm bells. Your problem is clearly that you're not getting the<br>
dependencies recursively.<br>
<br>
Also, the license deploy manifest creation step is based on do_image<br>
time, *not* do_image_complete. Its thereby defined as the manifest of<br>
the things *in* the image, not the tools used to build the image.<br>
Perhaps it should be at do_image_complete? If it were we might be able<br>
to drop some of these other hacks too...<br>
<br>
Cheers,<br>
<br>
Richard<br>
<br>
<br>
<br>
<br>
</blockquote></div><br></div>