<div><br><div class="gmail_quote"><div dir="auto">On Tue, Feb 20, 2018 at 7:41 AM Martin Jansa <<a href="mailto:martin.jansa@gmail.com">martin.jansa@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>I'm OK with adding bison-native for all versions.</div></blockquote><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto">As long we know that there are no side effects of this dep in kernel builds </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><br></div><div>When we added bc-native 2+ years ago:</div><div><div>commit c067e52cffe002de3b39aa1bced308dd532859c1</div><div>Author: Alejandro Hernandez <<a href="mailto:alejandro.hernandez@linux.intel.com" target="_blank">alejandro.hernandez@linux.intel.com</a>></div><div>Date: Thu Oct 2 15:33:23 2014 -0500</div><div><br></div><div> kernel: Added bc-native as DEPENDS</div><div> </div><div> The makefile checks for bc during for compilation</div></div><div><br></div><div>it was also needed only for the latest kernel and we didn't make it conditional on the kernel version. Now with RSS it's even less dangerous as the bison-native will appear only in kernel's RSS and as Denys said it's quite common dependency so many components pull it into RSS anyway.</div></div><div class="gmail_extra"><br><div class="gmail_quote"></div></div><div class="gmail_extra"><div class="gmail_quote">On Tue, Feb 20, 2018 at 3:53 PM, Otavio Salvador <span><<a href="mailto:otavio.salvador@ossystems.com.br" target="_blank">otavio.salvador@ossystems.com.br</a>></span> wrote:<br></div></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_5651199098793911087HOEnZb"><div class="m_5651199098793911087h5">On Tue, Feb 20, 2018 at 7:10 AM, Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>> wrote:<br>
> On 2/19/18 5:20 PM, Denys Dmytriyenko wrote:<br>
>><br>
>> On Mon, Feb 19, 2018 at 09:36:22PM -0300, Otavio Salvador wrote:<br>
>>><br>
>>> On Mon, Feb 19, 2018 at 8:54 PM, Denys Dmytriyenko <<a href="mailto:denis@denix.org" target="_blank">denis@denix.org</a>><br>
>>> wrote:<br>
>>>><br>
>>>> From: Denys Dmytriyenko <<a href="mailto:denys@ti.com" target="_blank">denys@ti.com</a>><br>
>>>><br>
>>>> Explicitly depend on bison-native for deterministic builds, as it is<br>
>>>> required<br>
>>>> for the build:<br>
>>>><br>
>>>> | HOSTCC scripts/basic/fixdep<br>
>>>> | GEN ./Makefile<br>
>>>> | HOSTCC scripts/kconfig/conf.o<br>
>>>> | YACC scripts/kconfig/zconf.tab.c<br>
>>>> | /bin/sh: bison: command not found<br>
>>>> | scripts/Makefile.lib:217: recipe for target<br>
>>>> 'scripts/kconfig/zconf.tab.c' failed<br>
>>>><br>
>>>> In most cases, this dependency comes indirectly via toolchain<br>
>>>> dependencies,<br>
>>>> specifically binutils-cross, which pulls bison-native. Different setups,<br>
>>>> such as with external toolchain, would expose this problem, since<br>
>>>> correct<br>
>>>> dependency is not marked explicitly.<br>
>>>><br>
>>>> Signed-off-by: Denys Dmytriyenko <<a href="mailto:denys@ti.com" target="_blank">denys@ti.com</a>><br>
>>>> ---<br>
>>>> I'm seeing this now on 4.16-rc2 with external toolchain.<br>
>>><br>
>>><br>
>>> I am not against the addition but in fact, it is because 4.16 stopped<br>
>>> of using pre-generated files and now requires bison to be available.<br>
>><br>
>><br>
>> Ok, good, I was wondering why I didn't see it before 4.16...<br>
>><br>
>><br>
>>> I am unsure it ought to be on kernel.bbclass at this moment.<br>
>><br>
>><br>
>> Why not? Because it's 4.16+ specific?<br>
>><br>
>> By default bison-native dependency gets added implicitly when built with<br>
>> the<br>
>> toolchain from oe-core, so this doesn't add any extra dependencies, only<br>
>> makes<br>
>> it explicit.<br>
>><br>
> it will be overcompensating for < 4.16 kernel recipes where this dependency<br>
> is not needed. it might be a legit dependency for another component, that<br>
> doesn't stage this package in kernel recipe-specific sysroot but this change<br>
> will do that. So its not completely innocent change.<br>
<br>
</div></div>I'd be in favor of matching the version and adding it if it is a 4.16<br>
or newer kernel. Adding for prior versions seems wrong for me.<br>
<span class="m_5651199098793911087im m_5651199098793911087HOEnZb"><br>
--<br>
Otavio Salvador O.S. Systems<br>
<a href="http://www.ossystems.com.br" rel="noreferrer" target="_blank">http://www.ossystems.com.br</a> <a href="http://code.ossystems.com.br" rel="noreferrer" target="_blank">http://code.ossystems.com.br</a><br>
Mobile: <a href="tel:%2B55%20%2853%29%209981-7854" value="+555399817854" target="_blank">+55 (53) 9981-7854</a> Mobile: <a href="tel:%2B1%20%28347%29%20903-9750" value="+13479039750" target="_blank">+1 (347) 903-9750</a><br>
</span></blockquote></div></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_5651199098793911087HOEnZb"><div class="m_5651199098793911087h5">--<br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</div></div></blockquote></div></div></blockquote></div></div>