<div dir="ltr">I was about to write a long email explaining all this but my dinner is almost ready.<div><br></div><div>Short version: patch fuzz is dangerous, we've had patches apply using fuzz which actually break the code, or doing something else stupid like repeat a statement.</div><div><br></div><div>We'd like to eventually have do_patch rejecting any fuzz on these grounds, so I wrote a nasty script to rebase all the patches and am reviewing them bit by bit. Note that two of these patches are deleting patches that we've been applying although upstream have already applied the same fix...</div><div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 5 March 2018 at 17:24, akuster808 <span dir="ltr"><<a href="mailto:akuster808@gmail.com" target="_blank">akuster808@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
On 03/05/2018 09:20 AM, Ross Burton wrote:<br>
> Signed-off-by: Ross Burton <<a href="mailto:ross.burton@intel.com">ross.burton@intel.com</a>><br>
<br>
Why do this patches need to be refreshed?<br>
<br>
- armin<br>
<div class="HOEnZb"><div class="h5">> ---<br>
> meta/recipes-core/dbus/dbus-<wbr>glib/no-examples.patch | 10 ++++++----<br>
> 1 file changed, 6 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/meta/recipes-core/dbus/dbus-<wbr>glib/no-examples.patch b/meta/recipes-core/dbus/dbus-<wbr>glib/no-examples.patch<br>
> index fbb49678282..32e76117188 100644<br>
> --- a/meta/recipes-core/dbus/dbus-<wbr>glib/no-examples.patch<br>
> +++ b/meta/recipes-core/dbus/dbus-<wbr>glib/no-examples.patch<br>
> @@ -5,11 +5,13 @@ Upstream-Status: Inappropriate [disable feature]<br>
> Signed-off-by: Kevin Tian <<a href="mailto:kevin.tian@intel.com">kevin.tian@intel.com</a>><br>
> Signed-off-by: Scott Garman <<a href="mailto:scott.a.garman@intel.com">scott.a.garman@intel.com</a>><br>
><br>
> ---- dbus-glib-0.70/dbus/Makefile.<wbr>am.orig 2006-07-23 16:04:43.000000000 +0200<br>
> -+++ dbus-glib-0.70/dbus/Makefile.<wbr>am 2006-07-23 16:04:52.000000000 +0200<br>
> +Index: dbus-glib-0.108/dbus/Makefile.<wbr>am<br>
> +=============================<wbr>==============================<wbr>========<br>
> +--- dbus-glib-0.108.orig/dbus/<wbr>Makefile.am<br>
> ++++ dbus-glib-0.108/dbus/Makefile.<wbr>am<br>
> @@ -1,4 +1,4 @@<br>
> -SUBDIRS = . examples<br>
> +SUBDIRS = .<br>
><br>
> - INCLUDES=-I$(top_srcdir) $(DBUS_CFLAGS) $(DBUS_GLIB_CFLAGS) $(DBUS_GLIB_TOOL_CFLAGS) -DDBUS_COMPILATION=1 -DDBUS_LOCALEDIR=\"$(prefix)/@<wbr>DATADIRNAME@/locale\"<br>
> -<br>
> + AM_CPPFLAGS = \<br>
> + -I$(top_srcdir) \<br>
<br>
</div></div></blockquote></div><br></div>