<div dir="ltr">Hi,<div><br></div><div>This email just to point that a revised patch has been submitted.</div><div><br></div><div>Please find attached at <a href="https://patchwork.openembedded.org/patch/148586/">https://patchwork.openembedded.org/patch/148586/</a></div><div><br></div><div>Thanks,</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div dir="ltr"><div><div dir="ltr">Francesco Giancane</div></div><div><dd style="margin:0px;padding:0px;border:0px;font-style:inherit;font-family:inherit;vertical-align:top;line-height:inherit;display:inline-block"><span style="margin:0px;padding:0px;border:0px;font-style:inherit;font-family:inherit;vertical-align:baseline;line-height:inherit;direction:ltr"><br></span></dd></div></div></div></div></div>
<br><div class="gmail_quote">2018-03-01 17:20 GMT+01:00 Francesco Giancane <span dir="ltr"><<a href="mailto:francescogiancane8@gmail.com" target="_blank">francescogiancane8@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">v4 is being sent with updated commit description and Upstream-Status included.<div>Thanks!</div><div class="gmail_extra"><span class="HOEnZb"><font color="#888888"><br clear="all"><div><div class="m_-1158130350777873683gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Francesco Giancane</div></div></div></div></div></div></div></font></span><div><div class="h5">
<br><div class="gmail_quote">2018-02-28 23:57 GMT+01:00 Peter Kjellerstedt <span dir="ltr"><<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">> -----Original Message-----<br>
> From: <a href="mailto:openembedded-core-bounces@lists.openembedded.org" target="_blank">openembedded-core-bounces@list<wbr>s.openembedded.org</a><br>
> [mailto:<a href="mailto:openembedded-core-bounces@lists.openembedded.org" target="_blank">openembedded-core-boun<wbr>ces@lists.openembedded.org</a>] On Behalf Of<br>
> Francesco Giancane<br>
> Sent: den 28 februari 2018 23:09<br>
> To: <a href="mailto:openembedded-core@lists.openembedded.org" target="_blank">openembedded-core@lists.openem<wbr>bedded.org</a><br>
> Subject: [OE-core] [meta-oe][PATCH v3] libepoxy: New recipe updated to latest release<br>
<br>
This isn't in meta-oe, it's in meta. ;)<br>
<br>
I suggest changing the subject to:<br>
<br>
libepoxy: Update to 1.5.0<br>
<br>
since it's not a new recipe, and "latest release" carries a lot<br>
less information than the actual version.<br>
<span><br>
> libepoxy 1.4.3 did not compile successfully because of<br>
> implicit symbol definitions and link-time errors.<br>
> A new recipe with latest libepoxy release (1.5.0) which<br>
> successfully compiles is provided.<br>
<br>
</span>I'd remove the second sentence. All that information is<br>
conveyed by the updated subject anyway.<br>
<div><div class="m_-1158130350777873683h5"><br>
> Patch to disable 'dlvsym' has also been forward-ported<br>
> to be applicable to version 1.5.0.<br>
> The patch 'Add-fallback-definition-for-E<wbr>GL-CAST.patch' is<br>
> mainline now; thus it can be safely removed.<br>
> Also, the patch<br>
> 0001-Define-MESA_EGL_NO_X11_HE<wbr>ADERS-before-including-eglp.pa<wbr>tch<br>
> is no longer required since mainline fixed this too.<br>
><br>
> Signed-off-by: Francesco Giancane <<a href="mailto:francescogiancane8@gmail.com" target="_blank">francescogiancane8@gmail.com</a>><br>
> ---<br>
> ..._EGL_NO_X11_HEADERS-before-<wbr>including-eglp.patch | 30 --------------------<br>
> ...sible-to-disable-the-use-of<wbr>-dlvsym-needed.patch | 26 +++++++++--------<br>
> .../Add-fallback-definition-fo<wbr>r-EGL-CAST.patch | 33 ----------------------<br>
> .../{<a href="http://libepoxy_1.4.3.bb" rel="noreferrer" target="_blank">libepoxy_1.4.3.bb</a> => <a href="http://libepoxy_1.5.0.bb" rel="noreferrer" target="_blank">libepoxy_1.5.0.bb</a>} | 10 +++----<br>
> 4 files changed, 18 insertions(+), 81 deletions(-)<br>
> delete mode 100644 meta/recipes-graphics/libepoxy<wbr>/libepoxy/0001-Define-MESA_<wbr>EGL_NO_X11_HEADERS-before-<wbr>including-eglp.patch<br>
> delete mode 100644 meta/recipes-graphics/libepoxy<wbr>/libepoxy/Add-fallback-<wbr>definition-for-EGL-CAST.patch<br>
> rename meta/recipes-graphics/libepoxy<wbr>/{<a href="http://libepoxy_1.4.3.bb" rel="noreferrer" target="_blank">libepoxy_1.4.3.bb</a> => <a href="http://libepoxy_1.5.0.bb" rel="noreferrer" target="_blank">libepoxy_1.5.0.bb</a>} (61%)<br>
><br>
> diff --git a/meta/recipes-graphics/libepo<wbr>xy/libepoxy/0001-Define-MESA_<wbr>EGL_NO_X11_HEADERS-before-<wbr>including-eglp.patch b/meta/recipes-graphics/libepo<wbr>xy/libepoxy/0001-Define-MESA_<wbr>EGL_NO_X11_HEADERS-before-<wbr>including-eglp.patch<br>
> deleted file mode 100644<br>
> index ebe5754a7a..0000000000<br>
> --- a/meta/recipes-graphics/libepo<wbr>xy/libepoxy/0001-Define-MESA_<wbr>EGL_NO_X11_HEADERS-before-<wbr>including-eglp.patch<br>
> +++ /dev/null<br>
> @@ -1,30 +0,0 @@<br>
> -From 62e178ddae24c7633d2a03b129dc52<wbr>261e0a15bf Mon Sep 17 00:00:00 2001<br>
> -From: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br>
> -Date: Wed, 7 Feb 2018 00:48:<a href="tel:03%20-0800" value="+39030800" target="_blank">03 -0800</a><br>
> -Subject: [PATCH] Define MESA_EGL_NO_X11_HEADERS before including eglplatform.h<br>
> - when X11 is disabled<br>
> -<br>
> -This helps in compiling when GL implementations e.g. mesa use<br>
> -this define to exclude X11 headers<br>
> -<br>
> -Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br>
> ----<br>
> -Upstream-Status: Submitted<br>
> [<a href="https://github.com/anholt/libepoxy/pull/153" rel="noreferrer" target="_blank">https://github.com/anholt/lib<wbr>epoxy/pull/153</a>]<br>
> -<br>
> - src/dispatch_common.h | 3 +++<br>
> - 1 file changed, 3 insertions(+)<br>
> -<br>
> -Index: libepoxy-1.4.3/src/dispatch_co<wbr>mmon.h<br>
> -=============================<wbr>==============================<wbr>========<br>
> ---- libepoxy-1.4.3.orig/src/dispat<wbr>ch_common.h<br>
> -+++ libepoxy-1.4.3/src/dispatch_co<wbr>mmon.h<br>
> -@@ -46,6 +46,9 @@<br>
> - #include "epoxy/glx.h"<br>
> - #endif<br>
> - #if PLATFORM_HAS_EGL<br>
> -+#if !PLATFORM_HAS_GLX<br>
> -+#define MESA_EGL_NO_X11_HEADERS 1<br>
> -+#endif<br>
> - #include "epoxy/egl.h"<br>
> - #endif<br>
> - #if PLATFORM_HAS_WGL<br>
> diff --git a/meta/recipes-graphics/libepo<wbr>xy/libepoxy/0001-Make-it-<wbr>possible-to-disable-the-use-<wbr>of-dlvsym-needed.patch b/meta/recipes-graphics/libepo<wbr>xy/libepoxy/0001-Make-it-<wbr>possible-to-disable-the-use-<wbr>of-dlvsym-needed.patch<br>
> index c2a2fa3453..5bddc12033 100644<br>
> --- a/meta/recipes-graphics/libepo<wbr>xy/libepoxy/0001-Make-it-<wbr>possible-to-disable-the-use-<wbr>of-dlvsym-needed.patch<br>
> +++ b/meta/recipes-graphics/libepo<wbr>xy/libepoxy/0001-Make-it-<wbr>possible-to-disable-the-use-<wbr>of-dlvsym-needed.patch<br>
> @@ -1,36 +1,38 @@<br>
> -From 7bcefd311cd696955376fe2c5298ec<wbr>85e8f954ce Mon Sep 17 00:00:00 2001<br>
> -From: Alexander Kanavin <<a href="mailto:alex.kanavin@gmail.com" target="_blank">alex.kanavin@gmail.com</a>><br>
> -Date: Wed, 15 Nov 2017 12:48:27 +0200<br>
> +From 9c964427656ef71210e2c5b48b2798<wbr>57806574e9 Mon Sep 17 00:00:00 2001<br>
> +From: Francesco Giancane <<a href="mailto:francescogiancane8@gmail.com" target="_blank">francescogiancane8@gmail.com</a>><br>
> +Date: Wed, 28 Feb 2018 21:32:24 +0100<br>
> Subject: [PATCH] Make it possible to disable the use of dlvsym() (needed for<br>
> musl)<br>
><br>
> -Upstream-Status: Pending<br>
<br>
</div></div>Don't remove the Upstream-Status.<br>
<div class="m_-1158130350777873683HOEnZb"><div class="m_-1158130350777873683h5"><br>
> -Signed-off-by: Alexander Kanavin <<a href="mailto:alex.kanavin@gmail.com" target="_blank">alex.kanavin@gmail.com</a>><br>
> +Add a patch to work around absence of dlvsym() on musl<br>
> +(wasn't previously a problem as autotools weren't building tests by default)<br>
><br>
> +Signed-off-by: Alexander Kanavin <<a href="mailto:alexander.kanavin@linux.intel.com" target="_blank">alexander.kanavin@linux.intel<wbr>.com</a>><br>
> +Signed-off-by: Francesco Giancane <<a href="mailto:francescogiancane8@gmail.com" target="_blank">francescogiancane8@gmail.com</a>><br>
> ---<br>
> meson_options.txt | 3 +++<br>
> test/meson.build | 6 +++---<br>
> 2 files changed, 6 insertions(+), 3 deletions(-)<br>
><br>
> diff --git a/meson_options.txt b/meson_options.txt<br>
> -index 244476a..071f0b6 100644<br>
> +index b5d7c98..aa849c2 100644<br>
> --- a/meson_options.txt<br>
> +++ b/meson_options.txt<br>
> @@ -1,6 +1,9 @@<br>
> - option('enable-docs',<br>
> + option('docs',<br>
> type: 'boolean', value: false,<br>
> description: 'Enable generating the Epoxy API reference (depends on Doxygen)')<br>
> +option('has-dlvsym',<br>
> + type: 'boolean', value: true,<br>
> + description: 'Whether dlvsym() is available (it is not when using musl C library)')<br>
> - option('enable-glx',<br>
> + option('glx',<br>
> type: 'combo',<br>
> choices: [ 'auto', 'yes', 'no' ],<br>
> diff --git a/test/meson.build b/test/meson.build<br>
> -index 2340fc6..bc4330b 100644<br>
> +index c5788b4..4c46ae6 100644<br>
> --- a/test/meson.build<br>
> +++ b/test/meson.build<br>
> -@@ -86,8 +86,8 @@ if build_glx<br>
> +@@ -92,8 +92,8 @@ if build_glx<br>
> [ 'glx_has_extension_nocontext', [ 'glx_has_extension_nocontext.c<wbr>' ], [], [], true ],<br>
> [ 'glx_static', [ 'glx_static.c' ], [ '-DNEEDS_TO_BE_STATIC'], [ '-static' ], libtype == 'static' ],<br>
> [ 'glx_shared_znow', [ 'glx_static.c', ], [], [ '-Wl,-z,now' ], has_znow ],<br>
> @@ -41,7 +43,7 @@ index 2340fc6..bc4330b 100644<br>
> ]<br>
><br>
> foreach test: glx_tests<br>
> -@@ -108,7 +108,7 @@ if build_glx<br>
> +@@ -114,7 +114,7 @@ if build_glx<br>
> endif<br>
> endforeach<br>
><br>
> @@ -51,5 +53,5 @@ index 2340fc6..bc4330b 100644<br>
> if build_egl<br>
> glx_egl_sources = [<br>
> --<br>
> -2.15.0<br>
> +2.14.3<br>
><br>
> diff --git a/meta/recipes-graphics/libepo<wbr>xy/libepoxy/Add-fallback-<wbr>definition-for-EGL-CAST.patch b/meta/recipes-graphics/libepo<wbr>xy/libepoxy/Add-fallback-<wbr>definition-for-EGL-CAST.patch<br>
> deleted file mode 100644<br>
> index b9297257dc..0000000000<br>
> --- a/meta/recipes-graphics/libepo<wbr>xy/libepoxy/Add-fallback-<wbr>definition-for-EGL-CAST.patch<br>
> +++ /dev/null<br>
> @@ -1,33 +0,0 @@<br>
> -Add fallback definition for EGL_CAST<br>
> -<br>
> -The EGL API update from d11104f introduced a dependency on the<br>
> -EGL_CAST() macro, provided by an updated eglplatform.h. Given that we<br>
> -don't provide eglplatform.h, add a fallback definition for if we're<br>
> -building against Mesa 17.0.x or similar.<br>
> -<br>
> -<a href="https://bugs.gentoo.org/show_bug.cgi?id=623926" rel="noreferrer" target="_blank">https://bugs.gentoo.org/show_<wbr>bug.cgi?id=623926</a><br>
> -<br>
> -Upstream-Status: Backport [<a href="https://github.com/anholt/libepoxy/commit/ebe3a53db1c0bb34e1ca963b95d1f222115f93f8" rel="noreferrer" target="_blank">https://github.com/anholt/lib<wbr>epoxy/commit/ebe3a53db1c0bb34e<wbr>1ca963b95d1f222115f93f8</a>]<br>
> -<br>
> -Signed-off-by: Tom Hochstein <<a href="mailto:tom.hochstein@nxp.com" target="_blank">tom.hochstein@nxp.com</a>><br>
> -<br>
> -Index: libepoxy-1.4.3/src/gen_dispatc<wbr>h.py<br>
> -=============================<wbr>==============================<wbr>========<br>
> ---- libepoxy-1.4.3.orig/src/gen_di<wbr>spatch.py 2017-06-06<br>
> 04:24:13.000000000 -0500<br>
> -+++ libepoxy-1.4.3/src/gen_dispatc<wbr>h.py 2017-11-06<br>
> 12:45:43.594966473 -0600<br>
> -@@ -491,6 +491,15 @@<br>
> - self.outln('#include "epoxy/gl.h"')<br>
> - if self.target == "egl":<br>
> - self.outln('#include "EGL/eglplatform.h"')<br>
> -+ # Account for older eglplatform.h, which doesn't define<br>
> -+ # the EGL_CAST macro.<br>
> -+ self.outln('#ifndef EGL_CAST')<br>
> -+ self.outln('#if defined(__cplusplus)')<br>
> -+ self.outln('#define EGL_CAST(type, value) (static_cast<type>(value))')<br>
> -+ self.outln('#else')<br>
> -+ self.outln('#define EGL_CAST(type, value) ((type) (value))')<br>
> -+ self.outln('#endif')<br>
> -+ self.outln('#endif')<br>
> - else:<br>
> - # Add some ridiculous inttypes.h redefinitions that are<br>
> - # from khrplatform.h and not included in the XML. We<br>
> diff --git a/meta/recipes-graphics/libepo<wbr>xy/<a href="http://libepoxy_1.4.3.bb" rel="noreferrer" target="_blank">libepoxy_1.4.3.bb</a> b/meta/recipes-graphics/libepo<wbr>xy/<a href="http://libepoxy_1.5.0.bb" rel="noreferrer" target="_blank">libepoxy_1.5.0.bb</a><br>
> similarity index 61%<br>
> rename from meta/recipes-graphics/libepoxy<wbr>/<a href="http://libepoxy_1.4.3.bb" rel="noreferrer" target="_blank">libepoxy_1.4.3.bb</a><br>
> rename to meta/recipes-graphics/libepoxy<wbr>/<a href="http://libepoxy_1.5.0.bb" rel="noreferrer" target="_blank">libepoxy_1.5.0.bb</a><br>
> index 8a5cb8f49f..dfdd19248d 100644<br>
> --- a/meta/recipes-graphics/libepo<wbr>xy/<a href="http://libepoxy_1.4.3.bb" rel="noreferrer" target="_blank">libepoxy_1.4.3.bb</a><br>
> +++ b/meta/recipes-graphics/libepo<wbr>xy/<a href="http://libepoxy_1.5.0.bb" rel="noreferrer" target="_blank">libepoxy_1.5.0.bb</a><br>
> @@ -6,12 +6,10 @@ LICENSE = "MIT"<br>
> LIC_FILES_CHKSUM = "file://COPYING;md5=58ef4c80d4<wbr>01e07bd9ee8b6b58cf464b"<br>
><br>
> SRC_URI = "<a href="https://github.com/anholt/$%7BBPN%7D/releases/download/$%7BPV%7D/$%7BBP%7D.tar.xz" rel="noreferrer" target="_blank">https://github.com/anholt/${B<wbr>PN}/releases/download/${PV}/${<wbr>BP}.tar.xz</a> \<br>
> - file://Add-fallback-definitio<wbr>n-for-EGL-CAST.patch \<br>
> file://0001-Make-it-possible-<wbr>to-disable-the-use-of-dlvsym-n<wbr>eeded.patch \<br>
> - file://0001-Define-MESA_EGL_N<wbr>O_X11_HEADERS-before-including<wbr>-eglp.patch \<br>
> "<br>
> -SRC_URI[md5sum] = "af4c3ce0fb1143bdc4e43f85695a9<wbr>bed"<br>
> -SRC_URI[sha256sum] = "0b808a06c9685a62fca34b680abb8<wbr>bc7fb2fda074478e329b063c1f872b<wbr>826f6"<br>
> +SRC_URI[md5sum] = "63fe3847789258254dcd7e3fdb9e7<wbr>f5e"<br>
> +SRC_URI[sha256sum] = "4c94995398a6ebf691600dda2e968<wbr>5a0cac261414175c2adf4645cdfab4<wbr>2a5d5"<br>
> UPSTREAM_CHECK_URI = "<a href="https://github.com/anholt/libepoxy/releases" rel="noreferrer" target="_blank">https://github.com/anholt/lib<wbr>epoxy/releases</a>"<br>
><br>
> inherit meson pkgconfig distro_features_check<br>
> @@ -20,8 +18,8 @@ REQUIRED_DISTRO_FEATURES = "opengl"<br>
><br>
> DEPENDS = "util-macros"<br>
><br>
> -PACKAGECONFIG[egl] = "-Denable-egl=yes, -Denable-egl=no, virtual/egl"<br>
> -PACKAGECONFIG[x11] = "-Denable-glx=yes, -Denable-glx=no, virtual/libx11"<br>
> +PACKAGECONFIG[egl] = "-Degl=yes, -Degl=no, virtual/egl"<br>
> +PACKAGECONFIG[x11] = "-Dglx=yes, -Dglx=no, virtual/libx11 virtual/libgl"<br>
> PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FE<wbr>ATURES', 'x11', d)} egl"<br>
><br>
> EXTRA_OEMESON_append_libc-musl = " -Dhas-dlvsym=false "<br>
> --<br>
> 2.14.3<br>
<br>
</div></div><span class="m_-1158130350777873683HOEnZb"><font color="#888888">//Peter<br>
<br>
</font></span></blockquote></div><br></div></div></div></div>
</blockquote></div><br></div></div>