<div><br><div class="gmail_quote"><div dir="auto">On Fri, Mar 9, 2018 at 6:55 PM Andre McCurdy <<a href="mailto:armccurdy@gmail.com">armccurdy@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, Mar 9, 2018 at 6:25 PM, Bystricky, Juro<br>
<<a href="mailto:juro.bystricky@intel.com" target="_blank">juro.bystricky@intel.com</a>> wrote:<br>
> This was morty upgrade, which did not have those patches to begin with, I did not remove them. The patches were not in rocko either, in the end I got them from master (gcc6.4 was eventually removed completely),<br>
> Backporting of ARM specific patches was not the objective. ( I was not aware that 6.4 had an ARM specific regression which broke the pi3 builds).<br>
> Long story short, all patches should be there now, please review them, see the commit message for more details.<br>
> I'll make sure all other gcc6 upgrades contain the ARM patches as well.<br>
<br>
Comparing my morty branch (with update to gcc 6.4 by backporting<br>
incremental gcc updates from master) and today's morty-next (which<br>
updates gcc 6.2 -> 6.4 with a single commit) the only differences are:<br>
<br>
- My branch lacks all the new x86 specific patches (OK, since they<br>
are appearing here first)<br>
<br>
- Today's morty-next is lacking one patch, which was added to oe-core<br>
master as a backport (from gcc master) to gcc 6.3:<br>
<br>
<a href="http://git.openembedded.org/openembedded-core/commit/?id=d2631f45a057c53797b7ba657662f35f66a2b04e" rel="noreferrer" target="_blank">http://git.openembedded.org/openembedded-core/commit/?id=d2631f45a057c53797b7ba657662f35f66a2b04e</a><br>
<br>
I don't have any strong opinions on the patch, but presumably it fixed<br>
some issue Khem was seeing, it still applies cleanly to gcc 6.4 and we<br>
have it in rocko so on balance I'd say it should probably be in morty<br>
too.<br>
</blockquote><div dir="auto"><br></div><div dir="auto">Yes this patch fixes an arm regression </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Overall this looks great though and I'm very happy to see gcc updates<br>
landing in the release branches. Thanks Juro!<br>
</blockquote></div></div>